Bug 117020 - EDITING Spellchecker should not be recovered together with the file
Summary: EDITING Spellchecker should not be recovered together with the file
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha0+
Hardware: All Windows (All)
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Spell-Checking Document-Recovery
  Show dependency tree / graph
 
Reported: 2018-04-15 12:23 UTC by Emil Tanev
Modified: 2023-08-10 11:48 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
large Excel file (9.29 MB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2018-04-15 12:23 UTC, Emil Tanev 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil Tanev 2018-04-15 12:23:49 UTC 
Created attachment 141380 [details]
large Excel file

Open the attached file in Calc
Click Spellchecker from the toolbar
Spellchecker and Calc hang
Force quit Calc from Task manager
Open the file again - choose Recover
Issue: Upon Recover, the Spellchecker is active again, so Calc hangs again.

Spellchecker should not be auto-resumed upon recover, because large files may not be recovered if it keeps making Calc hang.
https://screencast-o-matic.com/watch/cFfolDDWn7

Version: 6.1.0.0.alpha0+ (x64)
Build ID: d39a8e791618a40328c0f90bece3cc246dcf57f7
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-04-06_00:59:07
Locale: en-US (en_US); Calc: group
Comment 1 m_a_riosv 2018-04-15 14:19:05 UTC 
I can't reproduce the hang. What should be the language?, have you tried Restart in Safe Mode.
Comment 2 Emil Tanev 2018-04-21 07:01:36 UTC 
The language is English, and yes, the hang happens in Safe mode as well. 
The bug is that after recovery of the document, Spellchecker is recovered as well and starts spell checking again. Not the actual hang. So, you can reproduce the Spellchecker recovery without the hang, by force quitting an empty Calc document and recovering it. Then compare the same behavior with Writer - Spellchecker does start automatically. At the very least, we want to be consistent across the products.
Comment 3 m_a_riosv 2018-04-21 12:00:19 UTC 
I can't reproduce the hang with:
Version: 6.1.0.0.alpha0+
Build ID: c8c74a0b4ca6f3a3619f423b6548c80c52392ae0
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-04-14_22:59:27
Locale: en-US (es_ES); Calc: group

Forcing the quit to get a recovery, the Spellcheck has the same status as before.
Comment 4 Emil Tanev 2018-04-22 09:50:28 UTC 
Spellchecker should not start automatically with recovery. This behavior is not consistent with Writer.
Comment 5 Emil Tanev 2018-04-22 10:18:10 UTC 
Reproduced with the hang in this builds as well

Version: 6.0.5.0.0+
Build ID: e58dc868a6ac0df24adf88f32f90a9e4fc6fdae9
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86@42, Branch:libreoffice-6-0, Time: 2018-04-19_23:05:52
Locale: en-US (en_US); Calc: group
Comment 6 Buovjaga 2018-04-23 12:20:52 UTC 
I reproduce the spellchecker appearing upon recovery.

Version: 6.1.0.0.alpha0+
Build ID: 104b26b246c94c8c66864b20d00e419d96b15961
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86@39, Branch:master, Time: 2018-04-16_08:30:15
Locale: fi-FI (fi_FI); Calc: group
Comment 7 Justin L 2023-08-10 11:48:30 UTC 
surprising - but confirmed with 24.2. The spell checker dialog actually does appear when recovering (in my case from a SessionSave). (I had the spell checker running when I initiated the session save.)