If you wanted to check a menu item by its name, you had to do it like this: pGearMenu->CheckItem( pGearMenu->GetItemId("gear_iconOnly") ); Now we can do it just like this: pGearMenu->CheckItem( "gear_iconOnly" ); There are still some instances of the old-style calls that needs to be changed. You can search with "git grep CheckItem" for such instances, and change them to the new style. Just make sure it is a call to the CheckItem method of the Menu class (or one of its sub-classes), but not a call to CheckItem method of an unrelated class. Example commit: https://cgit.freedesktop.org/libreoffice/core/commit/?id=66ed9797ba8f61994a187dfcc189f375dcd0cdcc
Hi, I will work on that bug.
A polite ping, still working on this bug?
Hi, Didn't have time recently, but I will !
Arnold Dumas committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0b73990b2f1e0ea4312d29ef530ad6ca7134c470 tdf#117058: Simplify calls to Menu::CheckItem It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arnold Dumas committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=7d6a139bbb63a5b3c472b2460d15d6fdb0b7fb80 tdf#117058: Simplify calls to Menu::CheckItem It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Well, I would like, but my main computer has a broken screen, thanks to a cat attack, followed by the encouter with the ground...
Let's keep this open for new contributors. @Kevin: Please don't hesitate to assign it back to yourself if you are willing to solve and close it.
I would like to finish the work on this bug. Doing a quick git grep shows that there are not that many occasions left. But it is a bit unclear to me wether the remaining occasions are actually calls to a subclass of Menu or an unrelated class. Is there any easy way to get some kind of dependency graph or general inheritance overview?
Seems completed.