Description: when nvda does not announce automaticly how many items are replaced, i cant understand the result of my work and i dont know how many items libreoffice found and replaced. libreoffice dialogs and messages were very great and accessible in 4.3 and 4.4, but i dont understand why it becomes less accessible in every release! in previous versions like 4.3 and 4.4, i could read easily the messages using tab, but now, even nvda does not announce them automaticly! Steps to Reproduce: 1- in libreoffice 5.2 and later, open a file in writer. 2- activate nvda screen reader. 3- press control+h to activate find and replace dialog. 4- write one word in the first edit box and one another word to replace it in the second edit box (replace with). 5- press replace all button. 6- do the above steps with libreoffice 5.1 and previous versions. Actual Results: in libreoffice 5.2 and later, nvda does not announce how many items are replaced automaticly. even you cant read informations using tab key. Expected Results: in libreoffice 5.2 and later, like versions 5.1 and previous ones, nvda announces automaticly how many items are replaced and also even you can read this information using tab. Reproducible: Always User Profile Reset: Yes Additional Info: i am sure that this problem is related to https://bugs.documentfoundation.org/show_bug.cgi?id=98539 it is not an inhancement and positive point for libreoffice, it just adds one another issue for screen reader users. note: in openoffice i cant read the information for how many items are replaced by using tab, but nvda announces this information automaticly in replace all! User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:52.0) Gecko/20100101 Firefox/52.0
Bisected to https://cgit.freedesktop.org/libreoffice/core/commit/?id=beeef93480fae65840646e4e36aa888efe92579a tdf#98417, tdf#98539: DIALOG: Improvements to the Find & Replace dialog. Added Find Previous Button. Replaced backward checkbox with 'Replace Backward' from other options. Modified Dialog Layout as per the attachment in bug report. Removed vertical spacing in parent_container_box to reduce height of the dialog. Removed InfoBox from ReplaceAll functionality in writer, shifted it to SearchLabel. Attribute labels only show up when attribues are used in search, else they remain hidden. Change-Id: I0e9ded854fc2601524d6fc2a0ba5e9cb602e11a4 Reviewed-on: https://gerrit.libreoffice.org/23057 Committer has stopped working on LibreOffice so I will not CC him. Also reproduced with 6.1 alpha1 on Win 10.
Search results are writen to Dialog GUI as text label, with no a11y event recording result. The dialog can be read back with AT provided screen review or graphics API, but there is no accessible event or navigable / focusable results for search or replacement actions. https://opengrok.libreoffice.org/xref/core/svx/source/dialog/srchdlg.cxx?a=true&h=2460#2463
i believe that it relates to https://bugs.documentfoundation.org/show_bug.cgi?id=98539 am i right? i did not find any change or new feature in 5.2 that caused this regression. recently, i learnt how to use expert configuration. can someone please tell me exactly which item should i write in the search box and how should i edit it to return previous behaviour of libreoffice in search dialog and using replace all? thanks so much for any help, i am waiting for your help about your advice for changing expert configuration settings, God bless you all!
(In reply to zahra from comment #3) > i believe that it relates to > https://bugs.documentfoundation.org/show_bug.cgi?id=98539 > am i right? Yes that is where the regression occurred, an information box was removed and replaced with a Label showing the results to dialog. By convention, labels are not normally exposed the AT tools. > can someone please tell me exactly which item should i write in the search > box and how should i edit it to return previous behaviour of libreoffice in > search dialog and using replace all? Sorry, there is nothing you can do with your user configuration. A developer will decide how they'd like to fix this. But at least on Windows with NVDA the label is exposed to Screen review, and via graphics API with mouse over. Linux users with ORCA can not navigate to the search/replace result label--but it will sound during reading the dialog frame. When this rework of the Find & Replace dialog was implemented at 5.2 release the impact of labeling the GUI on accessibility slipped through. @Thorsten, Caolán -- with removal of message box/info box in https://gerrit.libreoffice.org/#/c/23057/ is there actually some way to make labels on UI directly accessible? Or, do they have to be changed to another object type and be able to take focus to sound with results?
> @Thorsten, Caolán -- with removal of message box/info box in > https://gerrit.libreoffice.org/#/c/23057/ is there actually some way to make > labels on UI directly accessible? Or, do they have to be changed to another > object type and be able to take focus to sound with results? I've also added Samuel in CC because it has worked with Hypra on accessibility non regression check tool on LibreOffice. @Samuel: I assume your input we'll be helpful to help us to find the better way to figure out this issue. Best regards, Alex.
AIUI, using a STATIC role would fix it, see https://bugs.documentfoundation.org/show_bug.cgi?id=116542 for discussing about adding it.
> can someone please tell me exactly which item should i write in the search > box and how should i edit it to return previous behaviour of libreoffice in > search dialog and using replace all? Sorry, there is nothing you can do with your user configuration. A developer will decide how they'd like to fix this. for me who cant and dont use new version of libreoffice, the fix in the future, does not make a difference. i wish that change expert configuration and i ment which item i should write in the expert configuration and how i change it to have previous behaviour? or, should i use 5.1.6 forever that not have this issue!
(In reply to zahra from comment #7) > Sorry, there is nothing you can do with your user configuration. A developer > will decide how they'd like to fix this. > > for me who cant and dont use new version of libreoffice, the fix in the > future, does not make a difference. > i wish that change expert configuration and i ment which item i should write > in the expert configuration and how i change it to have previous behaviour? > or, should i use 5.1.6 forever that not have this issue! @Zahra, sorry but it can not be corrected by any user action from 5.2.0 builds onward, so you are limited to a 5.1.6 release--or to using NVDAs graphics API or Screen review mode-- while you are stuck with Windows XP. Your choice...
Adding Cc: to Akshay Deep
Dear zahra, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
I tried version 6.3.0.0.alpha1+ b26b6cab5d8147d35f76a21c333719c80840d08d (2019-05-20_23:15:15), it does give a static role to the text that zahra wants pronounced, but Orca does not seem to be pronouncing it when it gets updated (I'm using Orca master). Joanmarie, the following event is sent by libreoffice's widget with static role, is anything else needed for Orca to pronounce it? object:text-changed:insert(0, 32, Terme recherché remplacé 2 fois.) source: [static | ] application: [application | soffice]
Ah, this was discussed in https://gitlab.gnome.org/GNOME/orca/issues/12 , we'd actually need to use a NOTIFICATION role https://bugs.documentfoundation.org/show_bug.cgi?id=119788 , thus adding the dependency.
Jamie, I don't know if the current 6.3 version with static role does get the feedback spoken? As mentioned in https://bugs.documentfoundation.org/show_bug.cgi?id=119788 , perhaps another role would be needed for NVDA to consider speaking the text?
Hello. i tested today with version 5.4.7.2 on windows xp. and nvda did not read found items for me and how many items are found! even find-replace and using replace all, is not very easy to use for screen readers.
Dear zahra, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Created attachment 181648 [details] accessiblity information message dialog option Request for comments on an accessibility option to show information dialogs for screen reader use. https://gerrit.libreoffice.org/c/core/+/137914
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/26e33cb1fc7024d04b68569f904ffd8583aef1fb tdf#117173 make search label read by screen reader It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/155e8b1683f10847ff18e75287e2466220242bb1 tdf#117173: qt a11y: Forward changes to SHOWING state It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/947fe0d89dee75ee43515ef7dfb43837d65a45bc tdf#119788 tdf#117173 add accessibility NOTIFICATION role It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c26d6cc3c4878d356328a538b5bf11e4e6a0e7dc tdf#117173 a11y: Send SHOWING state change event on Window{Show,Hide} It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/995d17697d1e46f66df67ca3132369d76caea29e tdf#117173 wina11y: Send EVENT_SYSTEM_ALERT when notification shows It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Commit Notification from comment #19) > Jim Raykowski committed a patch related to this issue. > It has been pushed to "master": > > https://git.libreoffice.org/core/commit/ > 947fe0d89dee75ee43515ef7dfb43837d65a45bc > > tdf#119788 tdf#117173 add accessibility NOTIFICATION role That's the main commit, the ones from comment 18, comment 20 and comment 21 are related changes needed for qt6 and Windows in addition. -> Thanks, Jim! Closing as FIXED. (In reply to Samuel Thibault from comment #13) > Jamie, I don't know if the current 6.3 version with static role does get the > feedback spoken? As mentioned in > https://bugs.documentfoundation.org/show_bug.cgi?id=119788 , perhaps another > role would be needed for NVDA to consider speaking the text? At the moment, the ALERT role, together with an extra EVENT_SYSTEM_ALERT is used to make NVDA speak the notification text (which is what I observed was happening for browser alerts in Firefox and Edge), s. the commit from comment 21. If there's a better way to do it, input is welcome. macOS hasn't been tested yet, so any feedback from macOS users would also be welcome.
Created attachment 182694 [details] Screencast with master: working announcement Attached a screencast with current LO master and Orca 43.0, i.e. the LO changes mentioned in this ticket as well as Orca MR https://gitlab.gnome.org/GNOME/orca/-/merge_requests/134 (to avoid double announcement) in place Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 995d17697d1e46f66df67ca3132369d76caea29e CPU threads: 4; OS: Linux 5.19; UI render: default; VCL: gtk3 Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded
We decided to get rid of the heavy red background when a search key is not found in bug 156227. To make the interaction a11y-friebdly it might be necessary to show a message box, ideally with a checkbox "[x] Show this dialog" and even better only if a11y is needed. Michael, what do you think?
(In reply to Heiko Tietze from comment #24) > We decided to get rid of the heavy red background when a search key is not > found in bug 156227. To make the interaction a11y-friebdly it might be > necessary to show a message box, ideally with a checkbox "[x] Show this > dialog" and even better only if a11y is needed. > > Michael, what do you think? IIUC, that's independent of this change here, which was about making screen readers announce the search result - and that should continue to work just fine regardless of the background color. Whether the suggestion to drop the background requires something else instead for visually impaired (but not blind users) is a different question. I'll comment in tdf#156227, but I'm not a big fan of introducing an extra dialog that explicitly needs to be enabled in the settings. (Then, rather make the background color configurable.)