Description: RTF file with tables. LibreOffice 4 - work fine, table draw correctly LibreOffice 5,6 - all words mixed, tables not drawing. Steps to Reproduce: 1. Opened rtf file, go to page 10 Actual Results: tables are damaged Expected Results: i want valid tables Reproducible: Always User Profile Reset: No Additional Info: see attachments below User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Created attachment 141671 [details] original rtf file
Created attachment 141672 [details] LO 4.1.1 all work fine
Created attachment 141673 [details] LO 5 - tables damaged
Created attachment 141674 [details] LO 6 - tables damaged
Created attachment 141675 [details] wordpad in wine - ok
Regression introduced by: author Miklos Vajna <vmiklos@suse.cz> 2013-08-17 11:38:45 +0200 committer Miklos Vajna <vmiklos@suse.cz> 2013-08-17 12:30:56 +0200 commit b9c1a9b9aa41dbbb6bed0c77f4370ab6105c7fb1 (patch) tree 68c3a70a739bb3ba0abeec191894140c02956ef4 parent 4f20c9f6f95c117bcdb520682df4fa1429a56477 (diff) fdo#44715 RTF import: reset styles in tables on RTF_PARD Commit 4a507f732d82c188ad81b022cbe3037951e58ac3 added an exception to RTF_PARD (reset paragraph properties) handling: when we're inside a table, it should not reset the fact that we're inside a table (which is a paragraph property). However, instead of just re-adding that property, it disabled resetting for all properties, and we had a growing list of exceptions since then. The next thing to add there would be the paragraph attributes, which contains the style information. Instead of growing that ad-hoc list, reset everything again and just re-add the "in table" SPRM. This makes the second and later paragraphs in the A1 cell of the bugdoc have proper font size. Bisected with: bibisect-42max Adding Cc: to Miklos Vajna
Any fix come soon? :) Without fix, information systems such as Consultant+ (https://www.consultant.ru/sys/english/) and other can not work
Created attachment 141855 [details] Minimal test case It's the minimal reproducing example. We have two tables here, first of which imports as text even in older (4.1) versions. The problem here is that the generating software (Consultant+) puts \itap0 control word into every paragraph, even into those that are inside tables. [RTF 1.9.1] tells about this control word: > \itapN Paragraph nesting level, where 0 is the main document, 1 is a > table cell, 2 is a nested table cell, 3 is a doubly nested table > cell, and so forth (default is 1). Well, Consultant+ explicitly tells that the paragraph is *not* inside a table. This contradicts with the fact that the paragraph is inside \trowd...\cellx...\cell; and Word chooses to ignore \itap value in this contradicting case, while we choose to honor it. I am not sure it's a bug (the file is ill-formed, since it contains inconsistent information); nor that it's a regression. And I'm not sure that we should try to mimic Word's way of dealing with errors. The Consultant+ developers seem to ignore the format specifications, but produce garbage that only test with Word to see it happens to render as they want. I believe that the proper way of dealing with this is to file the bug against Consultant+, and choose to not support creating more ill-formed documents in the wild.
https://gerrit.libreoffice.org/53790
Mike Kaganski committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=247dabcb0b92a62b233ec0237deac84e6675325c tdf#117268: treat erroneous \itap0 the same way as Word does It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
i downloaded 6.1alpha from https://dev-builds.libreoffice.org/daily/master/Linux-rpm_deb-x86_64@70-TDF/2018-05-04_01.13.51/ all working fine!
Pending: - backport to 6-0: https://gerrit.libreoffice.org/53813 - backport to 5-4: https://gerrit.libreoffice.org/53834
Verified in Version: 6.1.0.0.alpha1+ Build ID: 213f12be2cab2106dde4a0e859faaa8259627c1a CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group @Mike, Thanks for fixing this!!
Mike Kaganski committed a patch related to this issue. It has been pushed to "libreoffice-5-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=aa51623f7a8a11e0701913a34eab8c0a11316733&h=libreoffice-5-4 tdf#117268: treat erroneous \itap0 the same way as Word does It will be available in 5.4.8. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mike Kaganski committed a patch related to this issue. It has been pushed to "libreoffice-6-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=fe3ddff71af9298cc389ce05f6c1474bc0aeb715&h=libreoffice-6-0 tdf#117268: treat erroneous \itap0 the same way as Word does It will be available in 6.0.5. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mike Kaganski committed a patch related to this issue. It has been pushed to "libreoffice-5-4-7": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6f1781cb1e0209aa2d2fcaaf4f1adbd4c36d7f54&h=libreoffice-5-4-7 tdf#117268: treat erroneous \itap0 the same way as Word does It will be available in 5.4.7. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.