Bug 117408 - Clean up dictionary file headers from licenses and whitespace
Summary: Clean up dictionary file headers from licenses and whitespace
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Linguistic (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, topicCleanup
Depends on:
Blocks:
 
Reported: 2018-05-03 12:36 UTC by Pander
Modified: 2019-03-29 04:00 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pander 2018-05-03 12:36:43 UTC
Please, remove license information from dictionary files. The .dic files should be as clean as possible. License information should be stored in the appropriate README, LICENSE or COPYRIGHT files. There is also more place and avoids that license info is maintained in multiple places.

Additionally, and most importantly, encoding problems can arise from characters with diacritics in license information, especially names of authors. On top of that, this information is added in different ways, by using whitespace, # or /



1) For Danish, remove on the first line all after the number, including the whitespace

161315 # (c) Stavekontrolden.dk

See
- https://cgit.freedesktop.org/libreoffice/dictionaries/tree/da_DK/da_DK.dic



2) For German, remove line numbers 2 to 18, where line 18 is an empty line and the rest start with #

See
- https://cgit.freedesktop.org/libreoffice/dictionaries/tree/de/de_AT_frami.dic
- https://cgit.freedesktop.org/libreoffice/dictionaries/tree/de/de_CH_frami.dic
- https://cgit.freedesktop.org/libreoffice/dictionaries/tree/de/de_DE_frami.dic

(Something similar has been found in the non-frami German dictionaries. If possible, address those too.)



3) For Italian, remove line numbers 2 to 34 that start with #

See
- https://cgit.freedesktop.org/libreoffice/dictionaries/tree/it_IT/it_IT.dic



4) For Guarani, remove whitespace and word "wordlist" from the first line and remove the second line that is empty

See
- https://cgit.freedesktop.org/libreoffice/dictionaries/tree/gug/gug.dic



5) For Dutch, remove the last empty line

See
- https://cgit.freedesktop.org/libreoffice/dictionaries/tree/nl_NL/nl_NL.dic#n142520



6) For Arabic, remove empty line number 13553

See
- https://cgit.freedesktop.org/libreoffice/dictionaries/tree/ar/ar.dic#n13553
- https://bugs.documentfoundation.org/show_bug.cgi?id=117389



7) For Nepal, remove empty line number 38029. Note that this is better observed in the plain file (second url).

See:
- https://cgit.freedesktop.org/libreoffice/dictionaries/tree/ne_NP/ne_NP.dic#n38029
- https://cgit.freedesktop.org/libreoffice/dictionaries/plain/ne_NP/ne_NP.dic



8) After cleaning up these files, please check also that the line count in the first line is correct. I.e. the total lines in the files excludes (if I'm not mistaken):
- the first line
- any line starting with comment
- any line starting with slash
- any empty lines
- any lines with only whitespace

This could be a general QA check for the dictionary files. I've noticed these minor improvements as developing for Hunspell/Nuspell and have scripts available for QA or reporting on this. I'm willing to contribute these, however I am completely unfamiliar with the LibreOffice development habitat.
Comment 1 Pander 2018-05-03 12:57:00 UTC

9) Convert .aff and .dic files from DOS format line terminators to UNIX format line terminators with e.g. `flip -u` or `flip -b -u` This concerns:

- hu_HU/hu_HU.aff: Non-ISO extended-ASCII text, with very long lines, with LF, NEL line terminators
- pt_BR/pt_BR.dic: Non-ISO extended-ASCII text, with CRLF line terminators
- pt_BR/pt_BR.aff: ISO-8859 text, with CRLF line terminators
- ru_RU/ru_RU.dic: ISO-8859 text, with CRLF, LF line terminators
- ne_NP/ne_NP.dic: UTF-8 Unicode text, with CRLF, LF line terminators

Some extra inspection regarding long lines should be done for:
- da_DK/da_DK.aff: UTF-8 Unicode text, with very long lines
- si_LK/si_LK.dic: UTF-8 Unicode text, with very long lines

See also:
- for i in `find dictionaries -type f|grep -v hyph`; do file $i; done|grep 'long lines'
- for i in `find dictionaries -type f|grep -v hyph`; do file $i; done|grep 'line terminators'
Comment 2 Xisco Faulí 2019-02-11 17:17:52 UTC
Adolfo, any opinion here ?
Comment 3 Xisco Faulí 2019-03-21 12:01:54 UTC
@Sophi, do you think we could turn this issue into an easyhack ?
Comment 4 sophie 2019-03-25 12:13:35 UTC
(In reply to Xisco Faulí from comment #3)
> @Sophi, do you think we could turn this issue into an easyhack ?

I guess yes, it seems Pander has well documented the issue already.
Comment 5 Xisco Faulí 2019-03-28 19:17:42 UTC
Let's turn this into an easy hack then...