Bug 117412 - Update installer uninstalls dejavu fonts from windows systems
Summary: Update installer uninstalls dejavu fonts from windows systems
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Installation (show other bugs)
Version:
(earliest affected)
6.0.2.1 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-03 14:21 UTC by marnick.leau
Modified: 2018-12-05 10:41 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description marnick.leau 2018-05-03 14:21:47 UTC
Description:
If you had the full dejavu font family installed before an update, most of them have now been removed and instead you only have the subset bundled with libreoffice installed. In my case the Sans Condensed and such were removed, which noticeably screwed up some GUIs where I had that font configured to be used.

The installer should not uninstall any fonts from the system. The installer has no grounds on which to decide if any given font is ok to remove or not, even if it's suspected the font was installed by libreoffice in the first place.

Steps to Reproduce:
1) have any recent version of libreoffice installed (specifically 6.0.*)
2) have the dejavu font family installed
3) download and install an updated version of libreoffice (e.g. 6.0.2 -> 6.0.3)

Actual Results:  
dejavu fonts largely uninstalled

Expected Results:
no fonts should be uninstalled from the OS


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36
Comment 1 V Stuart Foote 2018-05-03 14:48:47 UTC
Thanks for filing...

The font replacement logic in the installer was reworked to correctly test the release version and reference count of each font. If the DejaVu fonts you've installed outside LibreOffice have earlier version IDs there could be an issue--but ref count should protect.

What is your source for the DejaVu fonts being clobbered? Could you extract the build details from them and post.

Aslo, we would need a verbose installation log, e.g. msiexec.exe /i LibreOffice_6.0.4.1_Win_x64.msi /L*v lo6041install.txt

Zip it an attach it.
Comment 2 QA Administrators 2018-11-05 16:08:32 UTC Comment hidden (obsolete)
Comment 3 marnick.leau 2018-11-06 19:38:01 UTC
I download them from https://dejavu-fonts.github.io/ (windows truetype files)

The files I've been using for a while now are marked version 2.37

I thought I noticed a few weeks ago when I installed an update, that the fonts got messed up again, but I just now downloaded the installer and ran it, and it doesn't seem to have done anything to my fonts anymore. Thanks for the fix.

I tried attaching the log file but I got a server error that it's too large...
Comment 4 Xisco Faulí 2018-12-05 10:41:42 UTC
Thanks for retesting with the latest version.
Setting to RESOLVED WORKSFORME as the commit fixing this issue hasn't been identified.