Bug 117415 - Colibre theme shows wrong icon for underline in Dutch language
Summary: Colibre theme shows wrong icon for underline in Dutch language
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Localization (show other bugs)
Version:
(earliest affected)
6.0.3.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.1.0.1 target:6.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-03 16:31 UTC by Pjotr
Modified: 2018-08-28 07:47 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot wrong underline icon in Dutch Galaxy theme (122.79 KB, image/png)
2018-05-03 16:40 UTC, Pjotr
Details
Screenshot of Galaxy toolbar with incorrect underline icon (47.16 KB, image/png)
2018-05-03 16:45 UTC, Pjotr
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pjotr 2018-05-03 16:31:45 UTC
Description:
In LO's theme Galaxy's Dutch localisation 3 icons are shown as V C U instead of V C O. This is due to an incorrect path to the icon subdirectory where these are stored. It concerns the files lc_underline.png and sc_underline.png. The path to the container used is /usr/share/libreoffice/share/config/images_galaxy.zip and the subfolder in the container /cmd/nl/lc_underline.png or
sc_underline.png. Now the icons used are those in /cmd/lc_underline.png and
sc_underline.png. It was correct in the past but recently this error was introduced.

Steps to Reproduce:
1.Fresh install
2.Choose Dutch language as GUI language
3.Choose Galaxy as toolbar icon theme

Actual Results:  
It shows the toolbar with the wrong icon...

Expected Results:
Show the correct localised icon


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Versie: 6.0.3.2
Build ID: 1:6.0.3~rc2-0ubuntu0.16.04.1~lo2
CPU-threads: 4; Besturingssysteem: Linux 4.4; UI-render: standaard; VCL: gtk2; 
Locale: nl-NL (nl_NL.UTF-8); Calc: group

But it started in LO version 5 already. Only due to my local profile it did not show. In a fresh install it does.


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Comment 1 Pjotr 2018-05-03 16:40:46 UTC
Created attachment 141877 [details]
Screenshot wrong underline icon in Dutch Galaxy theme
Comment 2 Pjotr 2018-05-03 16:45:18 UTC
Created attachment 141878 [details]
Screenshot of Galaxy toolbar with incorrect underline icon
Comment 3 Pjotr 2018-05-18 09:15:46 UTC
The same error shows in Windows 7 as well, it seems to be platform independent
Comment 4 Buovjaga 2018-06-08 17:58:10 UTC
Galaxy theme has been replaced by Colibre. I have shown your report to Colibre creator and I assume he will make sure this error is not in Colibre.
Closing.
Comment 5 Pjotr 2018-06-16 07:43:39 UTC
OK, I have downloaded and installed the beta.
Indeed Galaxy is gone and Colibre took it's place.
Colibre, as shown in this beta is OK for me, though I like Galaxy more.

The reported error in the bug, however, still stands.
I installed it again in the Dutch language. I have seen in the zip that contains the icons that there IS an icon that has underscore O but the icon show has underscore U.

As I said, it is not the maintainer of the icons but the maintainer of the code that defines the path to the icons in the script.
Please reopen the bug as it still stand as reported. Also in 6.1 beta!
Comment 6 Commit Notification 2018-06-16 17:47:54 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0c3c9f19a10ba12615866db3a403d72e4a3c7cf5&h=libreoffice-6-1

tdf#117415 write underline icons in colibre language translation

It will be available in 6.1.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2018-06-16 17:48:03 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5d680efbcce0ba73487314a910337ac5b0e8060b

tdf#117415 write underline icons in colibre language translation

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Buovjaga 2018-06-16 18:43:42 UTC
Andreas delivers, changing summary and status accordingly.
Comment 9 Cor Nouws 2018-08-28 07:47:54 UTC
verified in Versie: 6.1.0.3
Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1
CPU-threads: 4; Besturingssysteem: Linux 4.15; UI-render: standaard; VCL: gtk2; 
Locale: nl-NL (nl_NL.UTF-8); Calc: group threaded