Bug 117416 - FILEOPEN: DOCX: Floating table (aligned to bottom of margin) is imported in the wrong position
Summary: FILEOPEN: DOCX: Floating table (aligned to bottom of margin) is imported in t...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: DOCX-Floatingtable
  Show dependency treegraph
 
Reported: 2018-05-03 18:05 UTC by Xisco Faulí
Modified: 2023-04-24 09:28 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
sample doc (30.61 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2018-05-03 18:05 UTC, Xisco Faulí
Details
comparison MSO 2010 and LibreOffice 6.1 (152.99 KB, image/png)
2018-05-03 18:08 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2018-05-03 18:05:16 UTC
Created attachment 141879 [details]
sample doc

Steps to reproduce:
1. Open attached document
2. Check the floating table on the bottom

Observed behaviour: it's displayed in the middle of the page, while it should be displayed on the bottom

Reproduced in

Version: 6.1.0.0.alpha1+
Build ID: f1579d3d6c5f5f3a651825e035b93bee7a4f43c6
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group
Comment 1 Xisco Faulí 2018-05-03 18:07:15 UTC
Regression introduced by:

author	Mike Kaganski <mike.kaganski@collabora.com>	2018-02-07 01:03:32 +0300
committer	Mike Kaganski <mike.kaganski@collabora.com>	2018-02-07 07:23:57 +0100
commit 76d6fcd05c630a928dd3bd028d560792d9c904ca (patch)
tree 06bf8a8b6b8e48a0511d0f99bd2930baa77aba84
parent 9751a273747a2a6ba80c8b2e6012d788eee7c461 (diff)
tdf#114217: Consider relative width when importing floating table
Unit test included

Bisected with: bibisect-linux64-6.1

Adding Cc: to Mike Kaganski
Comment 2 Xisco Faulí 2018-05-03 18:08:07 UTC
Created attachment 141880 [details]
comparison MSO 2010 and LibreOffice 6.1
Comment 3 QA Administrators 2019-05-06 02:45:55 UTC Comment hidden (obsolete)
Comment 4 Eyal Rozenberg 2019-05-15 08:36:36 UTC
Bug still manifests with:

Version: 6.2.3.2
Build ID: aecc05fe267cc68dde00352a451aa867b3b546ac
CPU threads: 4; OS: Linux 4.9; UI render: default; VCL: gtk3; 
Locale: he-IL (en_IL); UI-Language: en-US
Comment 5 Justin L 2020-06-03 12:52:02 UTC
This looks like a somewhat unique version of bug 80717
Comment 6 Justin L 2021-08-27 06:54:05 UTC
Perhaps it is best to just not inline a table positioned "at bottom".
Comment 7 Mike Kaganski 2021-08-27 07:12:52 UTC
(In reply to Justin L from comment #6)
> Perhaps it is best to just not inline a table positioned "at bottom".

or maybe even generally positioned relative not to paragraph, but to page margins...
Comment 8 Roman Kuznetsov 2023-04-22 08:49:43 UTC
No repro in

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 5cd9de202765e243e41416802f3e4486b8a96f16
CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL threaded

bottom table is in bottom part of page now

closed as WFM
Comment 9 Eyal Rozenberg 2023-04-22 09:40:43 UTC
(In reply to Roman Kuznetsov from comment #8)

Did something get relevant get committed recently? Since with a 7.6 build from March 2023, I'm still seeing the bug manifest.
Comment 10 Mike Kaganski 2023-04-22 10:44:46 UTC
(In reply to Eyal Rozenberg from comment #9)

Of course - the massive amount of change seen at

https://gerrit.libreoffice.org/q/owner:vmiklos%2540collabora.com+sw+floattable

and

https://gerrit.libreoffice.org/q/owner:vmiklos%2540collabora.com+sw+floatable

with the recent commits from April enabling this stuff by default.
Comment 11 Timur 2023-04-24 09:28:09 UTC
Seen from: 

author	Miklos Vajna <vmiklos@collabora.com>	2023-04-12 08:13:07 +0200
committer	Miklos Vajna <vmiklos@collabora.com>	2023-04-12 09:12:17 +0200
commit ce3308a926f036b87515b8cd97d2b197063dc77a (patch)
tdf#61594 sw floattable: import floating tables as split flys by default

Fixed with:

commit d477fa8ac1b0d3ee81427217bbb5950278ab16db	[log]
author	Miklos Vajna <vmiklos@collabora.com>	Fri Mar 17 14:00:17 2023 +0100
committer	Miklos Vajna <vmiklos@collabora.com>	Fri Mar 17 14:10:34 2023 +0000
tree eff80bbdb718f81b11e0c7eb5c96dbf2f96508df
parent 57914a4084da9107ec6815b1916a4be117c400bf [diff]

sw floattable: unconditionally map <w:tblpPr> to SwFormatFlySplit

Fix the problem by never going via m_aPendingFloatingTables in the
SW_FORCE_FLY_SPLIT=1 case, since that was only a workaround for layout
limitations. This conditionally reverts commit 78d1f1c2835b9fae0f91ed771fc1d594c7817502 (fdo#68607 bnc#816593
DomainMapperTableHandler: don't always start a frame, 2013-09-03).

Also add a SwModelTestBase::FlySplitGuard, so it's just a one-liner
change to test the SW_FORCE_FLY_SPLIT=1 case from cppunit. The goal is
to have this on by default once it's mature enough.