Bug Hunting Session
Bug 117489 - The existing formatting isn't replaced consistently when applying a table style
Summary: The existing formatting isn't replaced consistently when applying a table style
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.2 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
Depends on:
Blocks: Writer-Tables-Style
  Show dependency treegraph
 
Reported: 2018-05-07 20:47 UTC by Telesto
Modified: 2018-07-23 11:04 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2018-05-07 20:47:53 UTC
Description:
The existing formatting isn't replaced consistently replaced when applying a table style

Steps to Reproduce:
1. Insert a table (2x2) (without formatting)
2. Table -> Properties -> Background
3. Select Color & Select table -> Press OK
4. Open the styles pane in the sidebar -> Table styles -> Select a style
5. No change in the first cell

Actual Results:  
Cell A1 doesn't change formatting after applying a style

Expected Results:
Should be changing to


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.1.0.0.alpha1+
Build ID: 08441d466dd70c203a519a133aaf1a5997adbbd3
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-05-06_23:59:40
Locale: nl-NL (nl_NL); Calc: CL


User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Comment 1 Dieter Praas 2018-05-08 07:29:38 UTC
Not reproducible for me with

Version: 6.1.0.0.alpha1+ (x64)
Build ID: 775d0f26beecffccf3ed27a6a011aff20d91f842
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-04-26_01:05:25
Locale: en-US (de_DE); Calc: CL

I changed the background color to red. It was applied to all styles(of course with the exception of Box List Blue, Green and Yellow and Simle Grid Rows), including cell A1.
Comment 2 Telesto 2018-05-08 08:43:07 UTC
(In reply to Dieter Praas from comment #1)
You're right, steps aren't working as expected :-). Small change (leave it at cell instead of table)

1. Insert a table (2x2) (without formatting)
2. Select 1 or more cell's 
2. Table -> Properties -> Background
3. Select Color & Select Cell -> Press OK
4. Open the styles pane in the sidebar -> Table styles -> Select a style
5. No change in the first cell (if a single cell is selected)/ Or table if all cells are modified this way
Comment 3 Telesto 2018-05-08 08:45:10 UTC
Same type of problem can be observed with table borders. 

1. Insert a table (2x2) (without formatting)
2. Table -> Properties -> Borders
3. Change the line width/color -> OK
4. Open the styles pane in the sidebar -> Table styles -> Select a style
Comment 4 Dieter Praas 2018-05-09 12:42:59 UTC
(In reply to Telesto from comment #2)
> (In reply to Dieter Praas from comment #1)
> You're right, steps aren't working as expected :-). Small change (leave it
> at cell instead of table)
> 
> 1. Insert a table (2x2) (without formatting)
> 2. Select 1 or more cell's 
> 2. Table -> Properties -> Background
> 3. Select Color & Select Cell -> Press OK
> 4. Open the styles pane in the sidebar -> Table styles -> Select a style
> 5. No change in the first cell (if a single cell is selected)/ Or table if
> all cells are modified this way

Now it's reproducible for me with

Version: 6.1.0.0.alpha1+ (x64)
Build ID: 775d0f26beecffccf3ed27a6a011aff20d91f842
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-04-26_01:05:25
Locale: en-US (de_DE); Calc: CL
Comment 5 Xisco Faulí 2018-05-30 13:55:52 UTC
Also reproduced in

Version: 5.2.0.0.alpha0+
Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53
Threads 4; Ver: 4.13; Render: default; 

@Jim, I thought you might be interested in this one...
Comment 6 Jim Raykowski 2018-06-13 06:48:37 UTC
Would the expected result be the same as applying a table style and using Ctrl-M to clear direct formatting?
Comment 7 Telesto 2018-07-14 15:46:00 UTC
(In reply to Jim Raykowski from comment #6)
> Would the expected result be the same as applying a table style and using
> Ctrl-M to clear direct formatting?

In my opinion, yes. However, lets ask UX-advise to be sure..
Comment 8 Heiko Tietze 2018-07-23 11:04:52 UTC
TS is not a real style but a template. But in any case the question is whether or no a direct formatting should be overridden. If the first cell has no particular definition in the TS it keeps what has been done by the user. BTW, TS work also in Calc where the selection is important.

I would say it's a WF/NOB due to the tainted definition of the feature.