Created attachment 141977 [details] comparison MSO 2010 and LibreOffice 6.1 Steps to reproduce: 1. Open attachment 90844 [details] from bug 72764 Observed behaviour: The first line misses the left indent. See the attached image Reproduced in Version: 6.1.0.0.alpha1+ Build ID: 1e2afc9bd3062cfba6b65b45c17a08f298014239 CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group [Bug found by office-interoperability-tools]
Regression introduced by: author Justin Luth <justin_luth@sil.org> 2018-01-23 21:56:00 +0300 committer Miklos Vajna <vmiklos@collabora.co.uk> 2018-01-26 12:41:18 +0100 commit cc1c9c7484d97167021301f32c3397124c4d79f5 (patch) tree 06985e54fbd97618f6c2fc948a00540b582780b8 parent 232251e11aecf051bc0e2a915e5af6c0d3650469 (diff) tdf#95377 ooxmlimport: treat default style like named styles Bisected with: bibisect-linux64-6.1 Adding Cc: to Justin Luth
Note: remove the comment, and the document opens as expected.
Created attachment 142011 [details] tdf117504_debugging.diff: fix plus looking for pre-existing unit tests, but none found.
It seems like this has exposed an existing problem. Proposed fix: https://gerrit.libreoffice.org/54085 tdf#117504 ooxmlimport: check paragraph props for actual style and preparatory commit https://gerrit.libreoffice.org/54084 writerfilter NFC: save ConvertedParaStyleName, not WW8Name In fact, I should consider removing m_sCurrentParaStyleName altogether in the 6.2 branch.
Justin Luth committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=8920d865ee148518bf71f71ce1866b24cc17c07e tdf#117504 ooxmlimport: check paragraph props for actual style It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in Version: 6.1.0.0.beta1+ Build ID: da49f4aeb8d5e9a7d2cba8855d911e7cc1d2f1e2 CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group @Justin Luth, Thanks for fixing this!!
(In reply to Justin L from comment #4) > In fact, I should consider removing m_sCurrentParaStyleName altogether in > the 6.2 branch. m_sCurrentParaStyleName might be still needed - it can apparently be set at a section context level, where it cannot be written as a property. Although removing it does not break any unit tests, there is no point in removing it since there is a regression potential.