Description: Crash after cut and paste operation of a chart stick Steps to Reproduce: 1. Launch Writer 2. Insert a chart 3. Select the yellow chart bar 4. Cut 5. Paste 6. Cut 7. Paste -> Crash Actual Results: Crash Expected Results: No crash Reproducible: Always User Profile Reset: No Additional Info: Version: 6.1.0.0.alpha1+ Build ID: c5f8a296fcfc08f8ac441cb8300a7565caa50b53 CPU threads: 4; OS: Windows 6.3; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2018-05-10_03:01:48 Locale: nl-NL (nl_NL); Calc: CL User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Similar 1. Launch Draw 2. Insert a chart 3. Copy the chart 4. Close Libo (CTRL+Q) 5. Launch Draw 6. Paste 7. Copy item again 8. Close Libo (CTRL+Q) 9. Launch Draw 10. Paste -> CRASH
Repeating the steps from the description in a debug build, after the first cut and paste, there is an assert: Expression: eType == OBJECTTYPE_DATA_SERIES https://opengrok.libreoffice.org/xref/core/chart2/source/controller/sidebar/ChartSeriesPanel.cxx#271 This also appears to be a regression, as there's no problem in 6.0. Bibisected to the following commit using repo bibisect-win32-6.1. Adding Cc: to Noel Grandin, please take a look. https://cgit.freedesktop.org/libreoffice/core/commit/?id=3d44b720f58366398e7f59c00dba6339712a670f author Noel Grandin <noel.grandin@collabora.co.uk> 2018-04-12 15:40:12 +0200 committer Noel Grandin <noel.grandin@collabora.co.uk> 2018-04-16 08:22:30 +0200 loplugin:useuniqueptr in SfxItemPool_Impl
Hmmm, reverting that commit makes no difference to me. Also, reproducable on Linux, using writer seems to be more reliable, I can't reproduce the crash in draw under Linux.
There seems to be more than one bug here. Running a build from the commit mentioned by Telesto shows a crash for me in the SfxItemSet constructor, while I see a crash in chart2 when running current master. I'll investigate some more.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9e60d29be40dfcc66604cb642e699d4febf032dc tdf#117539 Crash after cut and paste operation of a chart stick It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
If someone has a dbgutil bibisect repo, perhaps they could bisect the assert showing up in chart2 when trying the writer thing? It predates my problematic commit by quite a long way (I've built all the way back to 8000 revisions before my commit and I still see the assert).
We have this gdbutil repositories -> https://wiki.documentfoundation.org/QA/Bibisect/Linux#Older_dbgutil_daily_repos @Noel, what exactly we need to bisect here?
@Xisco, we're looking for the assert mentioned in comment 2
I downloaded lo-linux-dbgutil-daily-till60 and i can reproduce with the oldest commit Version: 5.5.0.0.alpha0+ Build ID: b5d72331053ce19942463ac6e688eac74e01e649 CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group will try with an older repository...
Actually, I've found the range of commit with lo-linux-dbgutil-daily-till51 where the assert started to happen -> https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=5a61d7f049a81d6e747d9d097f364ae45f58697b..14257152b19c08618a107c6eb0f684de11483da8
(In reply to Xisco Faulí from comment #10) > Actually, I've found the range of commit with lo-linux-dbgutil-daily-till51 > where the assert started to happen -> > https://cgit.freedesktop.org/libreoffice/core/log/ > ?qt=range&q=5a61d7f049a81d6e747d9d097f364ae45f58697b.. > 14257152b19c08618a107c6eb0f684de11483da8 @Markus, I see some commit of you in the range of commits mentioned above, I thought you might be interested in this bug...
Testing this I've also found bug 117864. Adding to See also
(In reply to Xisco Faulí from comment #11) > (In reply to Xisco Faulí from comment #10) > > Actually, I've found the range of commit with lo-linux-dbgutil-daily-till51 > > where the assert started to happen -> > > https://cgit.freedesktop.org/libreoffice/core/log/ > > ?qt=range&q=5a61d7f049a81d6e747d9d097f364ae45f58697b.. > > 14257152b19c08618a107c6eb0f684de11483da8 > > @Markus, I see some commit of you in the range of commits mentioned above, I > thought you might be interested in this bug... The crash is not directly related to chart. #4 0x00007ffff2cac823 in SfxItemSet::SfxItemSet(SfxItemPool&) (this=0x6519988, rPool=...) at /home/moggi/devel/libo/svl/source/items/itemset.cxx:96 #5 0x00007ffff1568a07 in SdrPaintView::SdrPaintView(SdrModel&, OutputDevice*) (this=0x65197b0, rSdrModel=..., pOut=0x0) at /home/moggi/devel/libo/svx/source/svdraw/svdpntv.cxx:195 #6 0x00007ffff157582a in SdrSnapView::SdrSnapView(SdrModel&, OutputDevice*) (this=0x65197b0, rSdrModel=..., pOut=0x0) at /home/moggi/devel/libo/svx/source/svdraw/svdsnpv.cxx:192 #7 0x00007ffff144709e in SdrMarkView::SdrMarkView(SdrModel&, OutputDevice*) (this=0x65197b0, rSdrModel=..., pOut=0x0) at /home/moggi/devel/libo/svx/source/svdraw/svdmrkv.cxx:155 #8 0x00007ffff13915df in SdrEditView::SdrEditView(SdrModel&, OutputDevice*) (this=0x65197b0, rSdrModel=..., pOut=0x0) at /home/moggi/devel/libo/svx/source/svdraw/svdedtv.cxx:94 #9 0x00007ffff1571fb9 in SdrPolyEditView::SdrPolyEditView(SdrModel&, OutputDevice*) (this=0x65197b0, rSdrModel=..., pOut=0x0) at /home/moggi/devel/libo/svx/source/svdraw/svdpoev.cxx:50 #10 0x00007ffff13dcfc9 in SdrGlueEditView::SdrGlueEditView(SdrModel&, OutputDevice*) (this=0x65197b0, rSdrModel=..., pOut=0x0) at /home/moggi/devel/libo/svx/source/svdraw/svdglev.cxx:35 #11 0x00007ffff13b8076 in SdrObjEditView::SdrObjEditView(SdrModel&, OutputDevice*) (this=0x65197b0, rSdrModel=..., pOut=0x0) at /home/moggi/devel/libo/svx/source/svdraw/svdedxv.cxx:96 #12 0x00007ffff1595ec5 in SdrExchangeView::SdrExchangeView(SdrModel&, OutputDevice*) (this=0x65197b0, rSdrModel=..., pOut=0x0) at /home/moggi/devel/libo/svx/source/svdraw/svdxcgv.cxx:64 #13 0x00007ffff138cc64 in SdrDragView::SdrDragView(SdrModel&, OutputDevice*) (this=0x65197b0, rSdrModel=..., pOut=0x0) at /home/moggi/devel/libo/svx/source/svdraw/svddrgv.cxx:77 #14 0x00007ffff1368be4 in SdrCreateView::SdrCreateView(SdrModel&, OutputDevice*) (this=0x65197b0, rSdrModel=..., pOut=0x0) at /home/moggi/devel/libo/svx/source/svdraw/svdcrtv.cxx:200 #15 0x00007ffff158ebf2 in SdrView::SdrView(SdrModel&, OutputDevice*) (this=0x65197b0, rSdrModel=..., pOut=0x0, __in_chrg=<optimized out>, __vtt_parm=<optimized out>) and not related to my changes.
Created attachment 149775 [details] gdb bt On pc Debian x86-64 with master sources updated today + enable-dbgutil, I could reproduce this.
Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ebbf3ccf693d5b6813746e72719e04e1c7cd438d tdf#117539 Assert after cut and paste operation of a chart stick It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 181007 [details] gdb bt (gtk3 rendering) On pc Debian x86-64 with master sources updated today (273f59bdb5f446c119e1de4000e5bc7fb7266ea6) so including Noel's patch, I still reproduce this.
Noel: bts are similar but not identical, should we reopen this tracker or do you prefer we submit a new one?
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ff6fc9927241afe4dc95580bf6bb987fe62a191d tdf#117539 Assert after cut and paste operation of a chart stick It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
The latest patch should fix the SfxItemSet assert
Created attachment 181011 [details] Hangs (gtk3) On pc Debian x86-64 with master sources updated today (including last patch), I don't reproduce the assertion but had an hang with gtk3 rendering. Since I saw accessibility part, I gave a try with gen rendering, I don't reproduce the hang so must be specific to accessibility part and that's another pb. Thank you Noel!