Bug 117544 - A large 3D object gets pasted as a single dot
Summary: A large 3D object gets pasted as a single dot
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Armin Le Grand (allotropia)
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Regressions-AW080
  Show dependency tree / graph
 
Reported: 2018-05-10 09:39 UTC by Telesto
Modified: 2018-06-03 22:26 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2018-05-10 09:39:26 UTC 
Description:
A large 3D object gets pasted as a single dot

Steps to Reproduce:
1. Open Draw
2. Insert a 3D Object
3. Copy it
4. Paste it

Actual Results:  
The 3d object gets pasted a single dot (can be enlarged with by dragging)

Expected Results:
Normal size


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.1.0.0.alpha1+
Build ID: c5f8a296fcfc08f8ac441cb8300a7565caa50b53
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-05-10_03:01:48
Locale: nl-NL (nl_NL); Calc: CL


User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Comment 1 Jacques Guilleron 2018-05-10 11:57:55 UTC 
Hi Telesto

I reproduce with
LO  6.1.0.0.alpha1+ (x64) Build ID: c5f8a296fcfc08f8ac441cb8300a7565caa50b53
CPU threads: 2; OS: Windows 6.1; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-05-10_01:41:43
Locale: fr-FR (fr_FR); Calc: CL
and
LO  6.1.0.0.alpha1+ (x64) Build ID: 4c5b4752786ae2c174cd8fa8aa42b27a0994f34a
CPU threads: 2; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-05-08_23:43:34
Locale: fr-FR (fr_FR); Calc: CL
but not with
LO  6.1.0.0.alpha0+ Build ID: dd4f1b1bd31daf080dc0420524712dc244e539b5
CPU threads: 2; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-03-20_23:26:38
Locale: en-US (fr_FR); Calc: CL
Next, crashes on paste into Writer on masters from
LO 6.1.0.0.alpha1+ (x64) Build ID: 08441d466dd70c203a519a133aaf1a5997adbbd3
CPU threads: 2; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-05-07_01:12:11
to 
TinderBox: Win-x86@42, Branch:master, Time: 2018-04-30_23:24:36
Comment 2 raal 2018-05-11 14:17:02 UTC 
This seems to have begun at the below commit.
Adding Cc: to Armin Le Grand ; Could you possibly take a look at this one? Thanks
 693876e8d9b0a7d42f13669503d936555eb436f4 is the first bad commit
commit 693876e8d9b0a7d42f13669503d936555eb436f4
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Mon Apr 16 21:18:01 2018 -0700

    source fda4b0f65eb23b597612113686a927a90f11a0f0

author    Armin Le Grand <Armin.Le.Grand@cib.de>    2018-04-11 19:22:52 +0200
committer    Armin Le Grand <Armin.Le.Grand@cib.de>    2018-04-16 21:21:37 +0200
commit    fda4b0f65eb23b597612113686a927a90f11a0f0 (patch)
tree    b39c1b8abb7a6d50eee862ad01f7f999e554421f
parent    6703b806a7d33f27bdec53d5c897beac94308fd9 (diff)
Take care of E3DObjList
E3DObjList is not needed, remove. Remove memeber from
E3DObject, derive E3DScene directly from SdrObjList, some
cleanups in SdrObject, too
Comment 3 Armin Le Grand (allotropia) 2018-05-18 11:32:30 UTC 
Could reproduce, adding to regression MetaTask
Comment 4 Armin Le Grand (allotropia) 2018-05-18 14:18:16 UTC 
Found: SetRectsDirty() needed in E3dScene::operator=, we need bSnapRectDirty to be true which it is after using SdrObject::operator=, but set to false again using CopyObjects. Also corrected in SdrObjGroup::operator= and adapted parent-function-calls to correct SdrObject-class.
Solution on gerrit (see https://gerrit.libreoffice.org/#/c/54546/)
Comment 5 Armin Le Grand (allotropia) 2018-05-19 18:09:56 UTC 
Checked with fix in current master, done
Comment 6 raal 2018-05-21 14:13:18 UTC 
verified Version: 6.1.0.0.alpha1+
Build ID: 0834546e5165521654d8ef9ae9404f55f2081063
Thanks Armin!