Bug 117638 - FILEOPEN: Corrupt grouped shape when loading RTF file
Summary: FILEOPEN: Corrupt grouped shape when loading RTF file
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.0 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: notBibisectable, regression
Depends on:
Blocks: RTF-Grouped-Shapes
  Show dependency treegraph
 
Reported: 2018-05-16 08:38 UTC by Milan Bouchet-Valat
Modified: 2024-09-06 03:17 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
RTF file to reproduce the problem (403.72 KB, application/rtf)
2018-05-16 08:38 UTC, Milan Bouchet-Valat
Details
DOCX file which is loaded correctly (273.58 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2018-05-16 08:39 UTC, Milan Bouchet-Valat
Details
how it looks in MS2010 (164.13 KB, image/png)
2018-05-30 15:34 UTC, Xisco Faulí
Details
The example RTF and the DOCX version in current master (433.47 KB, image/png)
2022-09-01 23:45 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Milan Bouchet-Valat 2018-05-16 08:38:25 UTC
Description:
In the attached RTF file, the first image isn't rendered correctly. And when saving it to an external file, only a small part of the actual image is used.

The correct image can be seen by loading the second attached file, which is a .docx version of the first one, saved using MS Word.

Steps to Reproduce:
Load attached .rtf file.

Actual Results:  
Image is corrupt.

Expected Results:
Image should look like in the .docx file.


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Comment 1 Milan Bouchet-Valat 2018-05-16 08:38:54 UTC
Created attachment 142122 [details]
RTF file to reproduce the problem
Comment 2 Milan Bouchet-Valat 2018-05-16 08:39:35 UTC
Created attachment 142123 [details]
DOCX file which is loaded correctly
Comment 3 Milan Bouchet-Valat 2018-05-16 08:40:08 UTC
I should have noted that the problem is still in present in LO 6.0.3.2.
Comment 4 Roman Kuznetsov 2018-05-20 06:34:18 UTC
Confirmed on LO 6.0.4.2 (64 bit) on Xubuntu 17.10 (64-bit)

Milan, please add info from dialogue Help > About
Comment 5 Xisco Faulí 2018-05-30 15:34:05 UTC
Created attachment 142412 [details]
how it looks in MS2010
Comment 6 Xisco Faulí 2018-05-30 15:42:47 UTC
I can reproduce it back to

Version: 5.0.0.0.alpha1+
Build ID: 0db96caf0fcce09b87621c11b584a6d81cc7df86
Locale: ca-ES (ca_ES.UTF-8)

but not in

Version: 4.5.0.0.alpha0+
Build ID: 2c5ce8ea8eb98f2d82986448af448d11b60a3ea1
Locale: ca_ES

it needs to be bisected with bibisect-50max
Comment 7 Buovjaga 2018-06-07 08:26:00 UTC
I declare this notBibisectable after about 2 hours of trying, having to mostly git bisect skip due to General error in opening. I got as far as "756 revisions left to test after this" (Win 5.0 repo)
Comment 8 Aron Budea 2018-12-09 07:11:50 UTC
A note here, this bug started in two steps, because even before the change in 5.0, the order of images is reversed. In 3.3.0 the order is correct, in 3.5.0.3 the images aren't imported, and in 4.2.0.4 they appear, but the legend is above the chart, while it should be below.
Comment 9 QA Administrators 2019-12-10 04:00:22 UTC Comment hidden (obsolete)
Comment 10 Roman Kuznetsov 2019-12-30 09:03:37 UTC
still repro in

Version: 6.5.0.0.alpha0+ (x64)
Build ID: 42a1a1c6b91907f81e15066ffab219411f18c4db
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded
Comment 11 QA Administrators 2021-12-30 03:47:02 UTC Comment hidden (obsolete)
Comment 12 Milan Bouchet-Valat 2022-01-06 09:54:16 UTC
Still present in 7.2.4.1.
Comment 13 Gabor Kelemen (allotropia) 2022-09-01 23:45:28 UTC
Created attachment 182166 [details]
The example RTF and the DOCX version in current master

This seems to have gotten better in:

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: cba119c2a44bcef4684073412798aec193fbd1b5
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

Previously the blue-orange columns legend image was badly distorted. This got better after:

https://git.libreoffice.org/core/commit/57d9cc81b058757421cd082e5dbe32a919716807

tdf#127806: RTF import: use shape dimensions for pib picture

But: this is a grouped shape originally, and now there are two instances of the blue-orange chart and its legend image. 
One set at the top of the first page as grouped shape:
- This is anchored incorrectly to the first empty paragraph of the document below the TextFrame with the title.
- There is an extra empty rectangle image below it, similar in size as the shape containing the blue-orange legend.

And another set as two individual, overlapping images at the top of the second page, these seem to be anchored to the second-to-bottom paragraph, before the page break. This is a correct anchoring, for the wrong objects.

Let's refocus this bugreport to the correct import of grouped shapes from RTF.
Comment 14 QA Administrators 2024-09-06 03:17:41 UTC
Dear Milan Bouchet-Valat,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug