Bug 117788 - use library resvg for work with SVG file
Summary: use library resvg for work with SVG file
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: filters and storage (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha1+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-24 20:58 UTC by Roman Kuznetsov
Modified: 2018-06-07 12:16 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2018-05-24 20:58:01 UTC
Description:
use library resvg for work with SVG file instead existing module svgio.

GitHUB - https://github.com/RazrFalcon/resvg

Steps to Reproduce:
1. May be anybody will be interested with integration resvg instead svgio
2.
3.

Actual Results:  
we use svgio

Expected Results:
we use resvg


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Comment 1 Jean-Baptiste Faure 2018-06-03 21:33:17 UTC
Why ? Please elaborate a bit.

Best regards. JBF
Comment 2 Roman Kuznetsov 2018-06-04 08:39:38 UTC
(In reply to Jean-Baptiste Faure from comment #1)
> Why ? Please elaborate a bit.

because:
1. We have a lot of problem with SVG now in LibreOffice
2. We don't have any developers for improvement our svgio
3. resvg is external library with own author.
4. resvg has license MPL 2.0, that allows use it in to LibreOffice

but of course needs check quality work with SVG between svgio and resvg
Comment 3 Xisco Faulí 2018-06-04 11:38:58 UTC
(In reply to kompilainenn from comment #2)
> (In reply to Jean-Baptiste Faure from comment #1)
> > Why ? Please elaborate a bit.
> 
> because:
> 1. We have a lot of problem with SVG now in LibreOffice

I don't think svgio is buggy, yes, we have some bugs, but not so many. OTOH, there's a tender to port the SVG filter to SVGio -> https://blog.documentfoundation.org/blog/2017/05/03/tender-deprecate-libreoffices-svg-filter-favour-svgio-201705-02/

> 2. We don't have any developers for improvement our svgio
Armin, who implemented SVGio, is active in the project and I also did some work in the past.

> 3. resvg is external library with own author.
it seems only one guy is working on it. It concerns me he will stop working on it at some point and the lib will no longer be maintained.

> 4. resvg has license MPL 2.0, that allows use it in to LibreOffice
> 
> but of course needs check quality work with SVG between svgio and resvg

Personally, I would say, RESOLVED WONTFIX... but just my 2 cents...
Comment 4 Roman Kuznetsov 2018-06-07 11:05:26 UTC
Hi, Armin. Please say your opinion about this enhancement and resvg library.
Comment 5 Armin Le Grand (allotropia) 2018-06-07 12:12:41 UTC
>1. We have a lot of problem with SVG now in LibreOffice

Not my opinion. Do you talk about import or export? SVGIO is currently only import. Using something else will also need *lots* of work - I do not think that an external library will import to Objects that we iternally use?
With an own lib we can fix needed stuff anytime, we have control.

>2. We don't have any developers for improvement our svgio

I am here :-) And others, too.

>3. resvg is external library with own author.

One guy, right. Will he fix bugs we request to-be-fixed? Will he add stuff that we need? Will he stay?

>4. resvg has license MPL 2.0, that allows use it in to LibreOffice

true.

As said, we have no good SVG export, but import using svgio is fine. It converts with high quality to Primitives, it keeps the unchanged SVG as original in ODF, it can be broken to SdrObjects.
That last step can (always) be improved. SdrObjects can do less things that SVG -> will never be optimal.

But that's exactly the same with an external lib.
If you expect to use an external lib and then be able e.g. to edit SVG in Draw/Impress/otherApps, that's not the case.
Comment 6 Xisco Faulí 2018-06-07 12:16:05 UTC
after Armin's answer, I believe we can close this as RESOLVED WONTFIX.