Bug 118118 - external file links still chased even if entry containing them deleted (change tracking enabled)
Summary: external file links still chased even if entry containing them deleted (chang...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsDevAdvice
Depends on:
Blocks: Calc-Track-Changes
  Show dependency treegraph
 
Reported: 2018-06-11 20:56 UTC by Ted Lee
Modified: 2023-01-08 03:23 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ted Lee 2018-06-11 20:56:12 UTC
1.Create a new calc spreadsheet, enter something in any cell.  Save the spreadsheet but leave the window open.
2.Create a second new calc spreadsheet.
3.Turn change tracking on (edit > track changes > record changes.)
4. Click on a cell, enter =, then click on the cell you filled in in step 1, hit return.
5. The cell you filled in in step 4 should now show the value entered in step 1 (and if you look at the formula that has been entered it will start "='file///…")
6. Delete the contents of the cell.
7. Save and close the second spreadsheet.
8. Open the second spreadsheet.
You will get a message (which message you get depends on the version of LibreOffice) saying your spreadsheet has links to an external file and giving you the option of following them.

As best I can tell, the only way to stop the message (other than enabling automatic linking) is to stop recording changes, which of course loses ALL change history.
(I've tried accepting or rejecting the change on just the cell in question and that doesn't stop the message.)

I believe the problem is that because the change history remembers the external file link even after the formula containing it has been deleted (or replaced by something else) the program attempts to follow it when the spreadsheet is loaded, even though the result won't actually be used.  This is even true if the change deleting the external has been accepted: the change history still remembers the old value as having been changed.

I believe the "right" implementation here would be to process external file links only if the result will be "used" in the spreadsheet.  (I don't know what happens, or, to be honest, what should happen, if an external link is in a conditional expression of some kind and is used dependent on what the condition evaluates to, although that may be a related issue.) 

This "bug" (behavior) is present in 3.3, 6.0, and 6.1.0.0beta1.
Comment 1 Buovjaga 2018-06-24 10:16:45 UTC
I confirm, but I think we need dev insight.
Comment 2 Xisco Faulí 2018-10-18 15:02:32 UTC
Let put it to NEW...
Comment 3 QA Administrators 2019-10-19 02:42:45 UTC Comment hidden (obsolete)
Comment 4 QA Administrators 2023-01-08 03:23:36 UTC
Dear Ted Lee,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug