Bug 118143 - Toolbar Icon selection of Colibre in Extra Large icon size does not link icons
Summary: Toolbar Icon selection of Colibre in Extra Large icon size does not link icons
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Icon-Theme-Colibre
  Show dependency tree / graph
 
Reported: 2018-06-13 14:32 UTC by V Stuart Foote
Modified: 2018-06-13 16:28 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description V Stuart Foote 2018-06-13 14:32:55 UTC 
On Windows 10 Home 64-bit en-US with
Version: 6.2.0.0.alpha0+ (x64)
Build ID: 90e4c55d01637178418c33ffe818263114a53374
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-06-11_23:27:09
Locale: en-US (en_US); Calc: CL

Selecting Extra Large from Tools -> Options -> View: User Interface Toolbar Icon Size when Colibre is the icon them results in just a few icons showing. Most buttons just show their labels.

Selecting Breeze, Karasa Jaga, Sifr or Tango show a full icon set.
Comment 1 V Stuart Foote 2018-06-13 14:37:27 UTC 
And to be expected, in Extra Large size Tango with its fallback now to Colibre has a few missing icons (text label only) on the toolbar as well.
Comment 2 V Stuart Foote 2018-06-13 16:13:11 UTC 
Oops sorry, guess the incomming 32px Colibre icons [1] should take care of this--for some reason I'd thought the "Extra Large" icons [2] would be using SVG rather than 32px PNG icons, helps to at least read the code.

Sorry for the noise.


=-ref-=
[1] https://gerrit.libreoffice.org/#/q/project:core+owner:andreas_kainz+colibre+32px

[2] http://cgit.freedesktop.org/libreoffice/core/commit/?id=b1426b5b502fd591402d666994e3f1fb3a8ad959
Comment 3 andreas_k 2018-06-13 16:28:08 UTC 
Colibre start with 32px icon size support. But its fare from complete.

For 6.1 release I plan to have extra large icon support.