Bug 118158 - in high contrast mode the preview of table borders shows no colors
Summary: in high contrast mode the preview of table borders shows no colors
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.2 all versions
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks: High-Contrast
  Show dependency treegraph
 
Reported: 2018-06-14 09:50 UTC by Regina Henschel
Modified: 2023-01-09 09:50 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2018-06-14 09:50:46 UTC
Switch to a high-contrast theme of Windows. Start LibreOffice and insert a table. Open the properties dialog tab Borders. Select a border line in the preview on the left side of the dialog. Increase border width, so you can better see the border line in the preview. Change the color of the border line to something different from black. Notice that the color in the preview do not change. OK. Notice, that the color in the document has changed.

The problem is, that you only need the dialog, if you want some special border line settings, e.g. different colors for outer and inner lines. And exact that is not visible in high-contrast mode.
Comment 1 Regina Henschel 2018-06-14 10:09:55 UTC
The situation is worse for other objects, that use the same dialog. For example a frame does not show the applied color at all, but it has still the default black. But the color is set, which you will notice in the thumbnail and of cause is pdf export and print.
Comment 2 Buovjaga 2018-06-24 10:23:55 UTC
Repro.

Merge adjacent line styles has to be unticked, if we modify a single line.

Version: 6.2.0.0.alpha0+ (x64)
Build ID: 2c85607101e2e04e870e3b87362f39f9a9148e6c
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-06-16_00:12:37
Locale: fi-FI (fi_FI); Calc: group threaded
Comment 3 QA Administrators 2019-06-26 02:46:22 UTC Comment hidden (obsolete)
Comment 4 Stéphane Guillou (stragu) 2022-12-19 19:11:58 UTC
Reproduced in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9b46020c262045aed0beace4708565235c2523cc
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: threaded

No colour in the border preview. (No colour preview either in the Background tab, by the way.)

Also on Linux with GNOME high contrast:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ad387d5b984c6666906505d25685065f710ed55d
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

For Linux, it started in 7.3, which is the version that started being more responsive to OS high contrast (at least in document display and icon set):

Version: 7.3.7.2 / LibreOffice Community
Build ID: e114eadc50a9ff8d8c8a0567d6da8f454beeb84f
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Caolán, what are your thoughts, seeing your recent work on high contrast?
Comment 5 Caolán McNamara 2022-12-19 20:11:26 UTC
LibreOffice takes a11y HighContrast to mean it has to do this sort of thing:
https://learn.microsoft.com/en-us/windows/win32/winauto/high-contrast-parameter

"Map all colors to a single pair of foreground and background colors. Use the GetSysColor function to determine the appropriate foreground and background colors, using either a combination of COLOR_WINDOWTEXT and COLOR_WINDOW or a combination of COLOR_BTNTEXT and COLOR_BTNFACE. The GetSysColor function returns the colors selected by the user through the Control Panel.
    Omit any bitmapped images that would typically be displayed behind text. Such images are visually distracting to a user who needs high contrast.
    Images that would typically be drawn in multiple colors should be drawn using the foreground and background colors selected for text."

And there is a surprising amount of code to try and do all this. It is a bit opaque to me whether what we currently do is what is truly useful and desirable for a11y or if we've gone too far. Competitive comparison with contemporary MS office suite and web browsers with a11y HighContrast enabled is probably indicated.
Comment 6 Stéphane Guillou (stragu) 2023-01-08 08:32:53 UTC
On Windows 10 with High Contrast turned on (default settings), in MS Word, in a table's Borders and Shading dialog:

- The colour pickers show the different colours in the palette and the currently selected colour
- The Border and Page Border previews only uses black and white despite picking a different colour
- The Shading preview _does_ show the selected fill colour

So even there, some inconsistencies in what the high contrast previews show.

Version:
Microsoft® Word for Microsoft 365 MSO (Version 2211 Build 16.0.15831.20098) 64-bit
Comment 7 Caolán McNamara 2023-01-09 09:50:05 UTC
It is a bit of a mystery what exactly the right thing to do should be