Bug 118322 - Section view blinking in Explorer when multiple used and invisible ones exist
Summary: Section view blinking in Explorer when multiple used and invisible ones exist
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Armin Le Grand (allotropia)
URL:
Whiteboard: target:6.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-22 13:10 UTC by Armin Le Grand (allotropia)
Modified: 2018-06-28 07:33 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
TestFile showing the effect (16.97 KB, application/vnd.oasis.opendocument.text)
2018-06-22 13:10 UTC, Armin Le Grand (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Armin Le Grand (allotropia) 2018-06-22 13:10:36 UTC
Created attachment 143041 [details]
TestFile showing the effect

Will add a TestFile showing the effect.
Creation is somewhat complicated:

- New Writer
- F5 (open Explorer)
- Move Explorer aside Writer-View
- Prepare some texts to embed as Sections (at least two, better four)
- insert/Section...
- Insert all prepared texts as sections
- Open 'Section' part of Explorer to show these
- Choose one, Edit, make invisible (Hide)
-> Explorer content constantly blinking when WriterEditView has focus

Or:
Load test document (answer update question with 'no')
Comment 1 Armin Le Grand (allotropia) 2018-06-22 13:15:25 UTC
Reason is the methjod the Explorer gets updated:
- Timer-based content is re-created every second
- Then checked for changes
- If changed, repaint -> blinking

Result for 'is changed' wrong in these cases due to entries for list in 'Section' compared currently at creation-time with the old versions. This fails due to now a sorted-list is used.

Needed change: Compare after new list is completety created.
Comment 2 Commit Notification 2018-06-22 23:58:23 UTC
Armin Le Grand committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f5f6781acb292783033caea0147ff98490c78d89

tdf#118322 Avoid blinking in Exporer for 'Section' part

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Armin Le Grand (allotropia) 2018-06-27 07:30:56 UTC
Checked against test doc and another one with content (original complex one), looks good. Checking linux version...
Comment 4 Armin Le Grand (allotropia) 2018-06-28 07:33:35 UTC
All good, done.