Bug 118344 - No suggest flag for African English is used incorrectly
Summary: No suggest flag for African English is used incorrectly
Status: REOPENED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Linguistic (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Dictionaries
  Show dependency treegraph
 
Reported: 2018-06-24 10:41 UTC by Pander
Modified: 2022-07-13 08:36 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
en_GB total wordlist (32.42 KB, image/png)
2022-07-12 11:53 UTC, Marco A.G.Pinto
Details
en_ZA total wordlist (31.77 KB, image/png)
2022-07-12 11:54 UTC, Marco A.G.Pinto
Details
Words in ZA that are missing in GB (67.94 KB, text/plain)
2022-07-13 06:39 UTC, Marco A.G.Pinto
Details
Uppercase words missing in GB (56.56 KB, text/plain)
2022-07-13 08:33 UTC, Marco A.G.Pinto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pander 2018-06-24 10:41:53 UTC
In the affix file

https://cgit.freedesktop.org/libreoffice/dictionaries/tree/en/en_ZA.aff

The exclamation mark ! is designated for word that may not be used in a suggestion, such as profane words. In the dictionary file

https://cgit.freedesktop.org/libreoffice/dictionaries/tree/en/en_ZA.dic

these are used incorrectly, see

!hotnot/S
!koedoe
!soutpiel
!boerbul
!boerseun
!likable
!pomp
!gatvol
!kak
!poes

which should be 

hotnot/S!
koedoe/!
soutpiel/!
boerbul/!
boerseun/!
likable/!
pomp/!
gatvol/!
kak/!
poes/!
Comment 1 Xisco Faulí 2018-07-25 09:34:47 UTC
Hello Pander,
Thanks for reporting the issue.
Would you like to submit a patch for this issue to gerrit? you have more information on how to do it here -> https://wiki.documentfoundation.org/Development/gerrit
Comment 2 Pander 2018-12-24 09:32:51 UTC
Dear Xisco,

I am a developer of the spell checker Nuspell and only found these errors. Best is that the maintainer of this reviews the proposed changes and fixes this himself or herself. Perhaps, these words need more changes.

I could not find contact information of a maintainer, so it is good to find that out first, because unmaintained is more of a risk.

Could you set this bug to confirmed please?

Can you track down who made this? Is it David Bartlett or Andrew Brown?

Best,

Pander
Comment 3 sophie 2019-05-16 11:54:55 UTC
I just checked and we have no more translators for en_ZA in our l10n teams to help here. I'll make a call on the LO channel to try to find some help.
Comment 4 Xisco Faulí 2019-10-21 12:06:20 UTC
(In reply to sophie from comment #3)
> I just checked and we have no more translators for en_ZA in our l10n teams
> to help here. I'll make a call on the LO channel to try to find some help.

Moving to NEW meanwhile...
Comment 5 Aron Budea 2021-08-09 02:40:11 UTC
Based on Marco's information in [1], the maintainer of the en_ZA dictionary is Dwayne Bailey... if he's still actively maintaining it, that is.

[1] https://github.com/marcoagpinto/aoo-mozilla-en-dict
Comment 6 Marco A.G.Pinto 2021-08-09 06:16:20 UTC
(In reply to Aron Budea from comment #5)
> Based on Marco's information in [1], the maintainer of the en_ZA dictionary
> is Dwayne Bailey... if he's still actively maintaining it, that is.
> 
> [1] https://github.com/marcoagpinto/aoo-mozilla-en-dict

@Arón,

The developer of the ZA dictionary also vanished from the Internet.

His dictionary for Thunderbird disappeared years ago.

If you well remember, it was me who did fixes in it months ago.

I will try to fix this in the November commit to Gerrit.
Comment 7 Pander 2022-07-05 17:14:33 UTC
Hi Marco, do you have an update on this? Thanks.
Comment 8 Marco A.G.Pinto 2022-07-05 17:22:24 UTC
(In reply to Pander from comment #7)
> Hi Marco, do you have an update on this? Thanks.

Yes, I forgot to fix it myself.

I did some fixes, but forgot these.

I will fix the ! flags this month.

I only release dictionary updates once a month, around day 1 of every month.

Still some weeks before the date right now, a lot of time to fix it.

If I don't post here that it is done, one week before next month, remember me again.
Comment 9 Marco A.G.Pinto 2022-07-12 11:53:20 UTC
Created attachment 181237 [details]
en_GB total wordlist
Comment 10 Marco A.G.Pinto 2022-07-12 11:54:14 UTC
Created attachment 181238 [details]
en_ZA total wordlist

123K fewer words than en_GB dictionary
Comment 11 Marco A.G.Pinto 2022-07-12 11:57:02 UTC
I have fixed it:
  - Fixed the flag ! at start of words;
  - Removed duplicate words;
  - Sorted alphabetically the dictionary.

I will release it at the end of the month for LibreOffice and OpenOffice.

But notice that the dictionary is unmaintained, look at the two screenshots I have attached… there is a difference of 120K words between GB and ZA.
Comment 12 Adolfo Jayme Barrientos 2022-07-13 02:11:10 UTC
IMHO, the ZA locale should be removed from LibreOffice — the GB variant suffices.
Comment 13 Marco A.G.Pinto 2022-07-13 05:50:44 UTC
@Adolfo

Where can I ask if people agree removing the ZA speller?
Comment 14 Marco A.G.Pinto 2022-07-13 06:39:17 UTC
Created attachment 181244 [details]
Words in ZA that are missing in GB

There are 7207 words in the ZA dictionary that don't appear in the GB one.
Comment 15 Marco A.G.Pinto 2022-07-13 08:33:54 UTC
Created attachment 181249 [details]
Uppercase words missing in GB

Hello!

Here are the 6057 uppercase words missing in GB.

If you go through this list and delete the ones that are not OBSOLETE proper names (people and cities, and that accept possessive “'S”), I will add them to GB, and we will remove the unmaintained ZA dictionary for good.
Comment 16 Marco A.G.Pinto 2022-07-13 08:36:47 UTC
Ahhhh…

What I mean is: I only want proper names, and they must not be obsolete and must accept possessive ('S).