Bug 118369 - Needs ellipsis: "Insert Image" button text on Properties sidebar
Summary: Needs ellipsis: "Insert Image" button text on Properties sidebar
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.0.4.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.2.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicDesign
Depends on:
Blocks:
 
Reported: 2018-06-25 08:30 UTC by Explorer09
Modified: 2018-07-04 18:06 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of Properties sidebar on Master View (88.87 KB, image/png)
2018-07-04 04:53 UTC, Explorer09
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Explorer09 2018-06-25 08:30:09 UTC
Description:
The "Insert Image" button on Properties sidebar in Impress.
The button text should have an ellipsis suffix.

Steps to Reproduce:
1. Open the sidebar, and the Properties deck in it.
2. Deselect all objects on a slide.
3. See "Slide" section -> "Background" -> "Insert Image" button.
4. Similar button can be seen on Master Slide View, Properties sidebar -> "Master Slide" section -> "Background" -> "Insert Image" button.

Actual Results:
Button text is "Insert Image"

Expected Results:
Button text should be "Insert Image..."


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Explorer09 2018-06-25 08:33:23 UTC
I see the button text error in both en-US and zh-TW UI languages. Perhaps the error exists in all locales.
Comment 2 Julien Nabet 2018-06-26 09:33:29 UTC
On Win7 + LO 6.0.5, I've got slightly different results.
In sidebar, I got just "Insert image" ("Insérer une image"). So the same as reporter
In slide menu, I got "Define background image..." (At least in French "Définir l'image d'arrière plan..."). Different from the reporter since there's no submenu.


Heiko: thought you might be interested in this one.
Comment 3 Xisco Faulí 2018-06-26 10:13:29 UTC
Since the button is opening a dialog, I belive it should contain the ellipses

Code-pointers: https://opengrok.libreoffice.org/search?project=core&q=%22Insert+Image%22&defs=&refs=&path=&hist=&type=
Comment 4 Heiko Tietze 2018-06-26 15:02:02 UTC
(In reply to Xisco Faulí from comment #3)
> Since the button is opening a dialog, I belive it should contain the ellipses

Yes, let's do that.

(In reply to Julien Nabet from comment #2)
> In slide menu, I got "Define background image..."

Do you talk about Master View: Slide > Set Background Image...? If so, this will change all slides as it applies to the master while "Insert Image..." changes the current slide only (see bug 112650).
Comment 5 Julien Nabet 2018-07-03 17:51:29 UTC
Sorry Heike for the delay and the confusion, I had tried menu instead of focusing on sidebar for both cases.

On sidebar, I reproduce 3. from initial description, so first case reproduced.

When trying 4., I click on "Master Slides" button on Sidebar but then I got 3 sections:
- Used in This Presentation
- Recently Used
- Available for Use
so no "Background" section here.
=> second case can't be tested.
Comment 6 Explorer09 2018-07-04 04:53:22 UTC
Created attachment 143299 [details]
Screenshot of Properties sidebar on Master View
Comment 7 Explorer09 2018-07-04 04:55:41 UTC
(In reply to Julien Nabet from comment #5)
> 
> On sidebar, I reproduce 3. from initial description, so first case
> reproduced.
> 
> When trying 4., I click on "Master Slides" button on Sidebar but then I got
> 3 sections:
> - Used in This Presentation
> - Recently Used
> - Available for Use
> so no "Background" section here.
> => second case can't be tested.

Sorry Julien. I didn't explain it properly. It isn't the "Master Pages" button on the sidebar that you should click. Your sidebar should have "Properties" remain open, then, go to View->Master Slide from the menu bar.
Comment 8 Commit Notification 2018-07-04 10:09:05 UTC
Abhyudaya Sharma committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1413cd01ae4a7962902c03d56838bdb5cd299be7

tdf#118369 Add Ellipsis to "Insert Image"

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Heiko Tietze 2018-07-04 18:06:18 UTC
(In reply to Explorer09 from comment #0)
> 4. Similar button can be seen on Master Slide View, Properties sidebar ->
> "Master Slide" section -> "Background" -> "Insert Image" button.

(In reply to Julien Nabet from comment #5)
> When trying 4., I click on "Master Slides" button on Sidebar but then I got
> 3 sections:

The mentioned button should be the same on master. With Abhyudaya's patch it should have ellipsis now.