Bug 118390 - GTK3: opening Special character dialog takes a long time
Summary: GTK3: opening Special character dialog takes a long time
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: x86-64 (AMD64) Linux (All)
: medium major
Assignee: Caolán McNamara
URL:
Whiteboard: target:6.2.0 target:6.1.0.1
Keywords: haveBacktrace, perf
Depends on:
Blocks: GTK3 Special-Character
  Show dependency tree / graph
 
Reported: 2018-06-26 10:52 UTC by Buovjaga
Modified: 2018-07-16 15:30 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Callgrind output from master (1.55 MB, application/x-xz)
2018-06-26 13:51 UTC, Buovjaga 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Buovjaga 2018-06-26 10:52:05 UTC 
Insert - Special character takes almost a minute to open with GTK3 backend

Arch Linux 64-bit
Version: 6.2.0.0.alpha0+
Build ID: eff395c2d2a3026d9d65121e273af336fb0cfb19
CPU threads: 8; OS: Linux 4.17; UI render: default; VCL: gtk3; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group threaded
Built on June 26th 2018
Comment 1 Xisco Faulí 2018-06-26 11:06:32 UTC 
It takes 4 seconds in

Version: 6.2.0.0.alpha0+
Build ID: 2dac65c50481684863433d67999c0ecf81c67e6b
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded
Comment 2 Julien Nabet 2018-06-26 12:21:29 UTC 
dup of tdf#118356?
Buovjaga: could you give it a try with a build which includes https://cgit.freedesktop.org/libreoffice/core/commit/?id=96c43a21da48e9ef50f199b9418e089da42a8ebb ?
Comment 3 Buovjaga 2018-06-26 13:51:28 UTC 
Created attachment 143133 [details]
Callgrind output from master

Julien: it is not a dup

Arch Linux 64-bit
Version: 6.2.0.0.alpha0+
Build ID: eff395c2d2a3026d9d65121e273af336fb0cfb19
CPU threads: 8; OS: Linux 4.17; UI render: default; VCL: gtk3; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group threaded
Built on June 26th 2018
Comment 4 Julien Nabet 2018-06-26 14:11:57 UTC 
> ...
> Julien: it is not a dup
> ...
> Build ID: eff395c2d2a3026d9d65121e273af336fb0cfb19
> ...

Indeed your build includes the quoted patch.

Caolán: thought you might be interested in this one since it concerns gtk3.
Comment 5 Xavier Van Wijmeersch 2018-06-26 14:44:43 UTC 
It takes 3 seconds

Version: 6.2.0.0.alpha0+
Build ID: 2e142c0ee54744d35517f0b9c49a24302fb32d47
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: gtk3; 
Locale: nl-BE (en_US.UTF-8); Calc: group threaded
build on 20180626
Comment 6 Caolán McNamara 2018-06-26 20:14:11 UTC 
I imagine Buovjaga has more fonts installed than others, I believe https://gerrit.libreoffice.org/#/c/56485/ will fix this
Comment 7 Buovjaga 2018-06-27 05:43:11 UTC 
(In reply to Caolán McNamara from comment #6)
> I imagine Buovjaga has more fonts installed than others, I believe
> https://gerrit.libreoffice.org/#/c/56485/ will fix this

You imagined correctly (I have Google fonts collection installed) and your patch drops the time to open to a mere 3 seconds.
Comment 8 Buovjaga 2018-06-29 15:00:48 UTC 
Hmm, there was a typo in the commit message, so this report did not get the comments. The merged commit is here: https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=a2937b4af3b1d148fbead50f06e7a196bf5850cb

Thanks!