Bug 118423 - Crash on opening writing aids options
Summary: Crash on opening writing aids options
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.1.0.0.beta2+
Hardware: x86-64 (AMD64) Linux (All)
: high critical
Assignee: Not Assigned
URL:
Whiteboard: target:6.2.0 target:6.1.0
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-27 19:18 UTC by Jean-Baptiste Faure
Modified: 2018-06-29 05:35 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
bt with debug symbols (8.25 KB, text/plain)
2018-06-28 17:14 UTC, Julien Nabet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Baptiste Faure 2018-06-27 19:18:37 UTC
Steps to reproduce:
1/ launch LibreOffice
2/ menu Tools > Options > Language Settings > Writing Aids

=> crash

Reproducible with LO 6.1.0.0.beta2+:Version: 6.1.0.0.beta2+
Build ID: ee81a4cd7778e3733b8237380b996fd3e4fee77b
Threads CPU : 4; OS : Linux 4.4; UI Render : par défaut; VCL: gtk3; 
Ubuntu_16.04_x86-64
Locale : fr-FR (fr_FR.UTF-8); Calc: threaded

Reproducible with LO 6.2.0.0.alpha0+: Version: 6.2.0.0.alpha0+
Build ID: 043701c56cae1e281e1be90a262caa14ed936867
CPU threads: 4; OS: Linux 4.4; UI render: GL; VCL: gtk3; 
Ubuntu_16.04_x86-64
Locale: fr-FR (fr_FR.UTF-8); Calc: threaded

Crash with a clean new user profile too.

Best regards. JBF
Comment 1 Drew Jensen 2018-06-27 19:26:50 UTC
looks to be language specific.

Using Ubuntu 18.04 (64bit) and build: Version: 6.1.0.0.beta2+
Build ID: 66881028595257fcf11985fd0e8835f4360632a0
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:libreoffice-6-1, Time: 2018-06-27_02:21:25
Locale: en-US (en_US.UTF-8); Calc: group threaded

and Version: 6.2.0.0.alpha0+
Build ID: aae64e0f9cd1582c0dc31992aa22b849d2527c80
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-06-23_02:31:34
Locale: en-US (en_US.UTF-8); Calc: group threaded

I can open that set of options, make changes, save the changes.
Everything worked fine.
Comment 2 Jean-Baptiste Faure 2018-06-27 20:11:40 UTC
(In reply to Drew Jensen from comment #1)
> looks to be language specific.
> 
It's not clear for me: my LO 6.1 is configured in French and my LO 6.2 is configured in English.

Best regards. JBF
Comment 3 Jean-Baptiste Faure 2018-06-27 20:22:02 UTC
Well, if I launch LO 6.1 in the terminal, I get the following error messages:

terminate called after throwing an instance of 'com::sun::star::uno::RuntimeException'


Fatal exception: Signal 6
Stack:
/home/libo/60/instdir/program/libuno_sal.so.3(+0x13cf3)[0x7f551cc02cf3]
/home/libo/60/instdir/program/libuno_sal.so.3(+0x3d892)[0x7f551cc2c892]
/lib/x86_64-linux-gnu/libc.so.6(+0x354b0)[0x7f551c5a24b0]
/lib/x86_64-linux-gnu/libc.so.6(gsignal+0x38)[0x7f551c5a2428]
/lib/x86_64-linux-gnu/libc.so.6(abort+0x16a)[0x7f551c5a402a]
/usr/lib/x86_64-linux-gnu/libstdc++.so.6(+0x8c8f7)[0x7f551bc448f7]
/usr/lib/x86_64-linux-gnu/libstdc++.so.6(+0x92a46)[0x7f551bc4aa46]
/usr/lib/x86_64-linux-gnu/libstdc++.so.6(+0x91aa9)[0x7f551bc49aa9]
/usr/lib/x86_64-linux-gnu/libstdc++.so.6(__gxx_personality_v0+0x2e8)[0x7f551bc4a458]
/lib/x86_64-linux-gnu/libgcc_s.so.1(+0x10573)[0x7f551b6a7573]
/lib/x86_64-linux-gnu/libgcc_s.so.1(_Unwind_Resume+0x125)[0x7f551b6a7df5]
/home/libo/60/instdir/program/libvcllo.so(+0x57af04)[0x7f551584df04]
/home/libo/60/instdir/program/libuno_sal.so.3(+0x16d22)[0x7f551cc05d22]
/home/libo/60/instdir/program/libuno_sal.so.3(+0x3d762)[0x7f551cc2c762]
/lib/x86_64-linux-gnu/libc.so.6(+0x354b0)[0x7f551c5a24b0]
/lib/x86_64-linux-gnu/libc.so.6(gsignal+0x38)[0x7f551c5a2428]
/lib/x86_64-linux-gnu/libc.so.6(abort+0x16a)[0x7f551c5a402a]
/home/libo/60/instdir/program/libvcllo.so(_ZN16SalUserEventList18DispatchUserEventsEb+0x3c1)[0x7f5515829ee1]
/home/libo/60/instdir/program/libvclplug_gtk3lo.so(+0x7d779)[0x7f550231e779]
/lib/x86_64-linux-gnu/libglib-2.0.so.0(g_main_context_dispatch+0x15a)[0x7f550df0f04a]
/lib/x86_64-linux-gnu/libglib-2.0.so.0(+0x4a3f0)[0x7f550df0f3f0]
/lib/x86_64-linux-gnu/libglib-2.0.so.0(g_main_context_iteration+0x2c)[0x7f550df0f49c]
/home/libo/60/instdir/program/libvclplug_gtk3lo.so(+0x7ea94)[0x7f550231fa94]
/home/libo/60/instdir/program/libvcllo.so(_ZN11Application5YieldEv+0x2e)[0x7f55158489ae]
/home/libo/60/instdir/program/libvcllo.so(_ZN11Application7ExecuteEv+0x45)[0x7f551584a195]
/home/libo/60/instdir/program/libsofficeapp.so(+0x28a1e)[0x7f551c95fa1e]
/home/libo/60/instdir/program/libvcllo.so(+0x57c896)[0x7f551584f896]
/home/libo/60/instdir/program/libvcllo.so(_Z6SVMainv+0x30)[0x7f551584f9a0]
/home/libo/60/instdir/program/libsofficeapp.so(soffice_main+0x115)[0x7f551c989d85]
/home/libo/60/instdir/program/soffice.bin[0x4006db]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0)[0x7f551c58d830]
/home/libo/60/instdir/program/soffice.bin[0x400719]

If nobody can reproduce I will rebuild in debug mode and run LO through gdb.

Best regards. JBF
Comment 4 Xisco Faulí 2018-06-27 21:12:50 UTC
I can't reproduce it in

Version: 6.2.0.0.alpha0+
Build ID: 6ebc026e34d0c119067e7dfbad8d932f92844760
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded
Comment 5 malboarg 2018-06-27 23:08:46 UTC
I can not reproduce the bug in

Version: 6.0.5.1
Build ID: 0588a1cb9a40c4a6a029e1d442a2b9767d612751
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
Locale: es-AR (es_AR.UTF-8); Calc: group
Comment 6 Xavier Van Wijmeersch 2018-06-28 05:51:00 UTC
I can not reproduce

Version: 6.2.0.0.alpha0+
Build ID: 2e142c0ee54744d35517f0b9c49a24302fb32d47
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: gtk3; 
Locale: nl-BE (en_US.UTF-8); Calc: group threaded
Comment 7 Julien Nabet 2018-06-28 17:14:04 UTC
Created attachment 143192 [details]
bt with debug symbols

On pc Debian x86-64 with master sources updated today, I could reproduce this.

I noticed this:
Python exception: <class 'NameError'>: name 'lightproof_impl_pt_BR' is not defined, traceback follows
  File "/home/julien/lo/libreoffice/instdir/share/extensions/dict-pt-BR/Lightproof.py", line 153, in getServiceDisplayName
    return lightproof_impl_pt_BR.name
Comment 8 Xisco Faulí 2018-06-28 17:18:08 UTC
(In reply to Julien Nabet from comment #7)
> Created attachment 143192 [details]
> bt with debug symbols
> 
> On pc Debian x86-64 with master sources updated today, I could reproduce
> this.
> 
> I noticed this:
> Python exception: <class 'NameError'>: name 'lightproof_impl_pt_BR' is not
> defined, traceback follows
>   File
> "/home/julien/lo/libreoffice/instdir/share/extensions/dict-pt-BR/Lightproof.
> py", line 153, in getServiceDisplayName
>     return lightproof_impl_pt_BR.name

Seems related to the work done by Tor in bug 104332
Comment 9 Julien Nabet 2018-06-28 17:39:01 UTC
Band-aid fix:
In instdir/share/extensions/dict-pt-BR/Lightproof.py add this line before the return on line 153:
import lightproof_impl_pt_BR
So you've got:
    151     # XServiceDisplayName
    152     def getServiceDisplayName(self, aLocale):
    153         import lightproof_impl_pt_BR
    154         return lightproof_impl_pt_BR.name

Again, it's just a band-aid, I don't think it's the right fix.

The pb is Writing aids lists "language modules" which include
"Lightproof grammar checker (Portuguese Brazilian)"
So if the module isn't imported at this moment, "lightproof_impl_pt_BR" var is unknown from Python and so it crashes.

Of course, with the band-aid, a delay appears when clicking on "Writing aids" since it loads some info.
Comment 10 How can I remove my account? 2018-06-28 17:44:15 UTC
Suggested fix (for 6.1) at https://gerrit.libreoffice.org/#/c/56613/ . The same as the "band-aid". Sure, it introduces a delay, but that is the same delay there used to be after typing the first character in Writer, or before a Writer window opens (it depends on platform when the delay happened).
Comment 11 Julien Nabet 2018-06-28 18:20:19 UTC
(In reply to Tor Lillqvist from comment #10)
> Suggested fix (for 6.1) at https://gerrit.libreoffice.org/#/c/56613/ . The
> same as the "band-aid". Sure, it introduces a delay, but that is the same
> delay there used to be after typing the first character in Writer, or before
> a Writer window opens (it depends on platform when the delay happened).

No pb about the delay, I understand the goal is to avoid it at the launching of LO.
The real fix would be a way to diminish the loading time of it but that's another story.
Comment 12 Julien Nabet 2018-06-28 18:22:44 UTC
Ok for putting it FIXED considering the patch has been pushed on master and for the 2 other branches 6.1 and 6.0, it's on gerrit?
Comment 13 Jean-Baptiste Faure 2018-06-29 05:35:54 UTC
Verified fixed in both master and LO 6.1.0.0.beta2+.

Thank you very much !

Best regards. JBF