Description: In the case of a javascript macro embedded with errors editing the macro is impossible. Steps to Reproduce: 1. Open the attached file and try to edit the javascript macro "MacroERROR" 2. Tools -> Macros -> Organize Macros -> Javascript... 3. In the document select embedded macro "MacroERROR" in "Library1" 4. Press "Edit" buttton Actual Results: There is a error message and then the Rhino debugger appears without the macro code. Expected Results: Appears the Rhino debugger with the macro code and the macro can be edited. Reproducible: Always User Profile Reset: Yes Additional Info:
Created attachment 143194 [details] Test file
On pc Debian x86-64 with master sources updated yesterday, I could reproduce this.
just a guess: https://opengrok.libreoffice.org/xref/core/scripting/java/com/sun/star/script/framework/provider/javascript/ScriptEditorForJavaScript.java?r=49cdc1da#199 https://opengrok.libreoffice.org/xref/core/external/rhino/rhino1_5R5.patch?r=57adce8b#811 https://opengrok.libreoffice.org/xref/core/external/rhino/rhino1_5R5.patch?r=57adce8b#832 https://opengrok.libreoffice.org/xref/core/scripting/examples/java/debugger/OORhinoDebugger.java?r=3f43627a#85 I haven't checked but the code maybe calls https://opengrok.libreoffice.org/xref/core/external/rhino/rhino1_5R5.patch?r=57adce8b#515 so the code tries to compile the script? minor note 1: currently LibreOffice fetches rhino from https://opengrok.libreoffice.org/xref/core/Makefile.fetch?r=f54478cc#211 https://opengrok.libreoffice.org/xref/core/download.lst?r=e8b1dab6#227 https://dev-www.libreoffice.org/src/ minor note 2: later than the version of rhino gui debugger Libreoffice references, the file was splitted into two files, but this hasn't changed. https://github.com/mozilla/rhino/commit/2e82602eb1211d4009a62a6472713b525c827751#diff-bdb1bb5b444802085cf1fe7116bb4e1dR1769
this = the fact that the rhino gui debugger tries to compile the script.
Also reproducible in Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)
>https://opengrok.libreoffice.org/xref/core/scripting/examples/java/debugger/OORhinoDebugger.java?r=3f43627a#85 Oops, I was referring to "examples" one, I should have linked to the one in Main.java, which existed until the following commit. https://github.com/mozilla/rhino/commit/88ff0e32f500c9b0fa04f4831bf266b3744a2900#diff-7afcd3364868d28a10547b0eba24a8aeL2780
I have tried original Rhino debugger (version 5R5 and 7R1) to see behavior before changes to adapt to LO. When you Open a script the debugger tries to compile. If the script contains an error and can't be compiled then an error message is issued but the script file is not loaded. So in LO this behavior is not changed.
Dear Luis, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Repro 7.3+.
Dear Luis, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Reproduced as described with sample file in: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 069bf61cea5e3aea07ffd5a1bb9f55324651cb35 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded However, with 58c4457a902c846229dc3383cc31bbc8f4b3aed9 now merged in trunk (and planned to be included in 24.8 release), the debugger/editor window is gone, so closing as "won't fix".