Created attachment 143204 [details] step to reproduce Problem description: When you open the navigator on calc and change the drag mode by right-clicking on the sheets icon it doesn't work, you must not use the main button drag mode. Steps to reproduce: 1. Open a calc file. 2. Open the navigator. 3. Oo right-clicking on sheets icon. 4. Change drag mode. 5. nothing happen you must change it from the main icon. I try all version before 5.4.0.0.alpha0+ and everything work fine. Operating System: All Version: 5.4.0.0.alpha0+ to Master
On pc Debian x86-64 with master sources updated yesterday, I confirm changing the drag-mode doesn't do anything. Indeed, when selecting "Insert as Link", then right clicking again and select drag mode, it's still "Insert as Hyperlink".
Salim : I noticed you assigned yourself, do you want to work on it and fix LO code?
yes
I bibisected with win-54 repo to range https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=169bd7718264b0e312052757f9bbd2321e1399c2...ff8b873936aa72b17309da4bfc2775573a5b1f55 I piped a git log command to grep in order to show all commits touching navipi: git log --stat --pretty=short --graph 169bd7718264b0e312052757f9bbd2321e1399c2...ff8b873936aa72b17309da4bfc2775573a5b1f55 | grep -B 10 -A 10 "navipi" There were four from Caolán and this stood out: https://cgit.freedesktop.org/libreoffice/core/commit/?id=73295fa4e0df4637f1ddcca30311481efc1009e3 convert RID_POPUP_DROPMODE menu to .ui
Thank you Salim for your feedback. Let's put ASSIGNED status then.
I guess Salim assigned it to himself by mistake, putting it back to NEW. If I'm wrong, please put it back as it was. @Jim, @Caolán, I thought you could be interested in this issue...
(In reply to Salim Habchi from comment #3) > yes Oh, sorry for the noise...
> There were four from Caolán and this stood out: > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=73295fa4e0df4637f1ddcca30311481efc1009e3 > convert RID_POPUP_DROPMODE menu to .ui Indeed, regression introduced by: author Caolán McNamara <caolanm@redhat.com> 2017-04-10 10:10:34 +0100 committer Caolán McNamara <caolanm@redhat.com> 2017-04-10 10:38:28 +0100 commit 73295fa4e0df4637f1ddcca30311481efc1009e3 (patch) tree 9f6930bb09d2636bba4a7b3842a90ef2a9498773 parent 9781272a4057b795a7dca013f335020ac4985fee (diff) convert RID_POPUP_DROPMODE menu to .ui Bisected with: bibisect-linux-64-5.4 Adding Cc: to Caolán McNamara
Hello, I propose a patch for this bug. https://gerrit.libreoffice.org/#/c/57269/
SalimHabchi committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=7cc85bfd54645d3786828816972a2f039cb134e9 tdf#118453 Reactivate navitagor submenu drag mode and display It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
On Win7 Version: 6.2.0.0.alpha0+ (x64) Build ID: 7119184f4b5441600f7b3eae7ec6771c094bbb7f CPU threads: 2; OS: Windows 6.1; UI render: default; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-07-23_05:38:07 it still doesn't work with right click LO 5.3.7.2 works LO 5.4.7.2 not
Hello Zineta, You build version 5.4.7.2 with my patch ? because the patch is available on LibreOffice 6.2.
Zineta: your build from master sources doesn't include Salim's patch 7cc85bfd54645d3786828816972a2f039cb134e9 Compare: - https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=7cc85bfd54645d3786828816972a2f039cb134e9 which corresponds to Salim's patch and - https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=7119184f4b5441600f7b3eae7ec6771c094bbb7f which corresponds to your buildid. So you should use a slightly more recent build from master branch.
Zineta: I put you in cc just in order you may be alerted about this bugtracker and read https://bugs.documentfoundation.org/show_bug.cgi?id=118453#c13 Feel free to uncc yourself of course.
"Change the drag mode" works now. "Insert as Hyperlink" works, "Insert as Copy" works. "Insert as Link" I don't see that works, probably another issue.
(In reply to Timur from comment #15) > "Change the drag mode" works now. > "Insert as Hyperlink" works, "Insert as Copy" works. "Insert as Link" I > don't see that works, probably another issue. I don't reproduce this. When changing the drag mode, I can see different icons: - link for Hyperlink - red flag for Link - 2 sheets + green arrow for Copy (Elementary theme) Perhaps I missed something.
Now it works poroperly, Version: 6.2.0.0.alpha0+ Build ID: 1b21ff86effe58ae368457de8fec654ba4c8edd9 CPU threads: 2; OS: Windows 6.1; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2018-07-30_03:13:35
Verified in Version: 6.2.0.0.alpha0+ Build ID: c86a47a9d3debbc7e8ee6247f573e7f98c611f19 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded @Salim Habchi, thanks for fixing this!! patch for 6-1 waiting for review: https://gerrit.libreoffice.org/#/c/58685/1
SalimHabchi committed a patch related to this issue. It has been pushed to "libreoffice-6-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4eb27c796350d041675cfc963ed88bc08cd34b82&h=libreoffice-6-1 tdf#118453 Reactivate navitagor submenu drag mode and display It will be available in 6.1.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.