Bug 118555 - Garbled text in Expert Configuration
Summary: Garbled text in Expert Configuration
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.1.0.1 rc
Hardware: All Windows (All)
: high major
Assignee: Not Assigned
URL:
Whiteboard: target:6.2.0 target:6.1.0.2
Keywords: bibisected, bisected, regression
: 118646 118757 (view as bug list)
Depends on:
Blocks: CommonSalLayout-refactoring-regressions
  Show dependency treegraph
 
Reported: 2018-07-05 16:19 UTC by Xisco Faulí
Modified: 2020-09-16 16:21 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot (85.35 KB, image/png)
2018-07-05 16:19 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2018-07-05 16:19:04 UTC
Created attachment 143321 [details]
screenshot

Steps to reproduce:
1. Go to tools - Options - LibreOffice - Advanced - Expert Configuration
2. Search 'undo'

-> See attached image

Reproduced in

Versión: 6.1.0.1
Id. de compilación: 378e26bd4f22a135cef5fa17afd5d4171d8da21a
Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; 
Configuración regional: es-ES (es_ES); Calc: group threaded
Comment 1 Xisco Faulí 2018-07-05 16:41:30 UTC
Regression introduced by:

author	Jan-Marek Glogowski <glogow@fbihome.de>	2017-12-26 15:14:31 +0000
committer	Khaled Hosny <khaledhosny@eglug.org>	2018-05-08 00:55:27 +0200
commit bdccb7e9991d83029eb2f2f11327b54534a00db8 (patch)
tree c32e95c49849647dc72c1071f375f3d2b67d8d7a
parent 9615e45d2e2bac79c252a018846e4f20012cfa34 (diff)
Refactor CommonSalLayout font handling
Moves all platform specific code from CommonSalLayout into the
platform specific plugins. This way the vcl library won't depend
on the Qt5 libraries and the Qt5Font header can be moved into the
qt5 VCL plugin.

While at it, switch the CommonSalLayouts font reference from the
FontSelectPattern to the LogicalFontInstance and also add the
harfbuzz font handling to the instance.

Bisected with: bibisect-win32-6.1

Adding Cc: to Jan-Marek Glogowski
Comment 2 Commit Notification 2018-07-09 20:12:22 UTC
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=fad862e290d727fc9fefe206f6e4b807482c4175

tdf#118555 fix HFONT fallback handing / lifecycle

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Xisco Faulí 2018-07-10 13:57:05 UTC
Verified in

Version: 6.2.0.0.alpha0+
Build ID: c290f692dd28094d41dff686f3faa1c4e14b556e
CPU threads: 16; OS: Windows 6.3; UI render: default; 
Locale: en-GB (en_GB); Calc: group threaded

@Jan-Marek, thanks for fixing this! Should it be closed as RESOLVED FIXED?
Comment 4 Commit Notification 2018-07-10 17:45:55 UTC
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=392a36b83c5288106a59acf76b3a89da31d5e4d1&h=libreoffice-6-1

tdf#118555 fix HFONT fallback handing / lifecycle

It will be available in 6.1.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2018-07-11 13:38:32 UTC
*** Bug 118646 has been marked as a duplicate of this bug. ***
Comment 6 Xisco Faulí 2018-07-14 13:34:22 UTC
*** Bug 118757 has been marked as a duplicate of this bug. ***