Bug 118622 - Unhandled exception when selecting remote server if parameters are null
Summary: Unhandled exception when selecting remote server if parameters are null
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Android Viewer (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Mert Tumer
URL:
Whiteboard: target:6.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-08 14:54 UTC by Mert Tumer
Modified: 2018-11-23 16:48 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mert Tumer 2018-07-08 14:54:32 UTC
Description:
Unhandled exception occurs when selecting remote server if parameters like host is empty

Actual Results:
07-08 17:48:05.625 12033-12094/org.example.libreoffice E/ReadRemoteFileOperation: Synchronizing  file /: Unexpected exception
    java.lang.IllegalArgumentException: host parameter is null
        at org.apache.commons.httpclient.HttpConnection.<init>(HttpConnection.java:206)
        at org.apache.commons.httpclient.HttpConnection.<init>(HttpConnection.java:155)
        at org.apache.commons.httpclient.MultiThreadedHttpConnectionManager$HttpConnectionWithReference.<init>(MultiThreadedHttpConnectionManager.java:1145)
        at org.apache.commons.httpclient.MultiThreadedHttpConnectionManager$ConnectionPool.createConnection(MultiThreadedHttpConnectionManager.java:762)
        at org.apache.commons.httpclient.MultiThreadedHttpConnectionManager.doGetConnection(MultiThreadedHttpConnectionManager.java:476)
        at org.apache.commons.httpclient.MultiThreadedHttpConnectionManager.getConnectionWithTimeout(MultiThreadedHttpConnectionManager.java:416)
        at org.apache.commons.httpclient.HttpMethodDirector.executeMethod(HttpMethodDirector.java:153)
        at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:397)
        at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:323)
        at com.owncloud.android.lib.common.OwnCloudClient.executeMethod(OwnCloudClient.java:217)
        at com.owncloud.android.lib.common.OwnCloudClient.executeMethod(OwnCloudClient.java:187)
        at com.owncloud.android.lib.resources.files.ReadRemoteFileOperation.run(ReadRemoteFileOperation.java:82)
        at com.owncloud.android.lib.common.operations.RemoteOperation.execute(RemoteOperation.java:130)
        at org.libreoffice.storage.owncloud.OwnCloudProvider.createFromUri(OwnCloudProvider.java:84)
        at org.libreoffice.storage.owncloud.OwnCloudProvider.getRootDirectory(OwnCloudProvider.java:77)
        at org.libreoffice.ui.LibreOfficeUIActivity$4.doInBackground(LibreOfficeUIActivity.java:435)
        at org.libreoffice.ui.LibreOfficeUIActivity$4.doInBackground(LibreOfficeUIActivity.java:428)
        at android.os.AsyncTask$2.call(AsyncTask.java:333)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:245)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
        at java.lang.Thread.run(Thread.java:764)

Expected Results:
handled exception like alerting ui like theres no host given


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Commit Notification 2018-07-12 13:57:22 UTC
Mert Tumer committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ec025525eb892b22a1874a295772f9653624c608

tdf#118622 fix unhandled exception when selecting remove server

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 raal 2018-09-08 06:54:45 UTC
Hello, can this issue be closed as Fixed?
Comment 3 Xisco Faulí 2018-10-17 17:27:15 UTC
A polite ping to Mert Tumer:
Is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Otherwise, Could you please explain what's missing?
Thanks
Comment 4 Xisco Faulí 2018-11-21 13:07:27 UTC
(In reply to raal from comment #2)
> Hello, can this issue be closed as Fixed?

Mert ?