Bug 118980 - No "clear list" or "no list style" control on Formatting (Styles) toolbar
Summary: No "clear list" or "no list style" control on Formatting (Styles) toolbar
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.0.0.2 rc
Hardware: All All
: medium enhancement
Assignee: Heiko Tietze
URL:
Whiteboard: target:6.2.0
Keywords:
Depends on:
Blocks: Writer-Styles-List
  Show dependency treegraph
 
Reported: 2018-07-28 20:37 UTC by peter josvai
Modified: 2018-08-04 08:14 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description peter josvai 2018-07-28 20:37:28 UTC
Description:
this problem is absolutely analogous to direct formatting "italic" and "bold" and applying the style "emphasis" and "strong"... 

the resolution of these two should be the same.. logically..

applying a list formatting to a section actually WORKS as expected :) :) 
cause no matter if you give it a list style through "styles" or "direct formatting" (say, shift+f12)... hitting shift+f12 again will revoke it!! :) :)
and it is gorgeous :) 

still, if you do not attempt top revoke the formatting by hitting "shift+f12", 
AND if you do not have the OLD direct formatting toolbar, you would be surprised.. cause you cannot revoke it...

therefore, just like "default character" or "no character style", or "clear character style" menu item, there should be a "no list" button (and menu item in the menu), too, by which to revoke the list styling...


sorry if I, again, misunderstood something... :)


Steps to Reproduce:
1. select a line and hit "bullet list style" in styles toolbar
2. try to revoke it
3.

Actual Results:
you can't... 

you can't find a button next to the buttons by which you apply a list style formatting to the text...

you can't clear it with "default character" either.. (nevertheless, I wouldn't expect to be able to do that like this)

you can clear it by hitting the direct formatting "list" icon... (pleasant surprise, perhaps the "EM" / "italic" and "strong" / "bold" should work like this, too.. "clearable" by the direct formatting "clear".. BUT.. perhaps not..

Expected Results:
I would expect a button before the first "list style" button to be there by which to clear it... "no list"...


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.2.0.0.alpha0+
Build ID: 5a7d18e432571fb1e9b2cd54d6168353d25c6f19
CPU threads: 2; OS: Linux 4.15; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-07-26_22:07:10
Locale: en-US (en_US.UTF-8); Calc: group threaded
Comment 1 peter josvai 2018-07-28 20:43:00 UTC
the other way to revoke a "list style" could be like the old way, which actually works beautifully... that you click on the list style again, and it disappears..

and accordingly, hit shift+f12 again.. and it disappears..

BUT... if it is solved like this... then the same route should be applied to "EM", "strong", and the 2 others in the other radio button set, too :)
the "clicking it again" method...

personally, I think a universal clearing method is better... like the "CRTL+m" used to be for direct formatting...


(I do hope I didn't misunderstood something :))
Comment 2 peter josvai 2018-07-28 22:15:03 UTC
I think the "do and redo" way is very good.. I mean, used to be very good...

like "CRTL+i" italic.. then "CRTL+i again, and the italic has gone :)
same with f12... and f12 again...

now I use CRTL+i to assign "emphasis".. but how do I revoke it?
to be able to revoke it by hitting CRTL+i again would be very a comfortable way...

and in this case (assuming that both EM and strong AND the list styles will work the same way) NO "clear list style" button would be needed...
Comment 3 V Stuart Foote 2018-07-29 18:45:12 UTC
Confirmed on 6.0.5.2 on Windows 10 Home 64-bit en-US with
Version: 6.0.5.2 (x64)
Build ID: 54c8cbb85f300ac59db32fe8a675ff7683cd5a16
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
Locale: en-US (en_US); Calc: CL

Once a range of paragraphs have been converted to List objects and styled, there is no convenient way in GUI to revert them to be simple default styled paragraphs.

A button on the Formatting (Styles) toolbar linked to the .uno:RemoveBullets (assigned <Ctrl><Shfit>+F12) is needed, in addition to work on bug 101965 to add a no-list entry to the Sidebar's Styles -> List Styles
Comment 4 peter josvai 2018-07-29 21:44:53 UTC Comment hidden (no-value)
Comment 5 Heiko Tietze 2018-08-02 08:18:26 UTC
We discussed the requests about clear style in bug 118969, bug 18979, and this ticket in the design meeting. There are many side effects and possible complications (nested styles, direct formatting on top of styles) and we think that keeping the status quo is the best option. Users just have to learn how to use styles.

Things are a little bit different for lists since we have the UNO command .uno:RemoveBullets that easily could be added to the formatting toolbar (not the standard). Patch (untested) is at https://gerrit.libreoffice.org/#/c/58467/
Comment 6 Commit Notification 2018-08-04 07:48:33 UTC
heiko tietze committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=b512cea37ebbb62a5dfaa21ec0a35de78fe4c05a

tdf#118980 - No "clear list" control on formatting toolbar

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Heiko Tietze 2018-08-04 08:14:35 UTC
The Numbering Off command is now part of the Formatting (Styles) toolbar by default.