Bug 119057 - ADDRESS function >> syntax of formula is changed after saving, if "ABS" argument is empty (hand input)
Summary: ADDRESS function >> syntax of formula is changed after saving, if "ABS" argum...
Status: CLOSED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
3.6.7.2 release
Hardware: All All
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Calc-Function
  Show dependency tree / graph
 
Reported: 2018-08-02 08:03 UTC by Andrey
Modified: 2019-02-26 10:00 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Video proof (20.87 MB, video/x-ms-wmv)
2018-08-02 13:12 UTC, Andrey 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey 2018-08-02 08:03:20 UTC 
Description:
Result of formula calculation doe not changed. Changes only syntax (text) of formula

Steps to Reproduce:
1. Run LibreOffice calc
2. Enter following formulas to A1 cell:
=ADDRESS(1,1,)
3. Enter following formulas to A2 cell:
=FORMULA(A1)
4. Save and close the file, and reopen it
5. Observe result in A2 cell

Actual Results:
=ADDRESS(1,1,1)

Expected Results:
=ADDRESS(1,1,)



Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Additional Info:
Version: 6.0.6.1 (x64)
Build ID: dc68ad6c5cde3c62874b96422f2e5e8252499bad
CPU threads: 4; OS: Windows 10.0; UI render: default; 
Locale: en-US (en_US); Calc: CL
Comment 1 Roman Kuznetsov 2018-08-02 11:02:47 UTC 
(In reply to Andrey from comment #0)
> Description:
> Result of formula calculation doe not changed. Changes only syntax (text) of
> formula
> 
> Steps to Reproduce:
> 1. Run LibreOffice calc
> 2. Enter following formulas to A1 cell:
> =ADDRESS(1,1,)
> 3. Enter following formulas to A2 cell:
> =FORMULA(A1)
> 4. Save and close the file, and reopen it
> 5. Observe result in A2 cell
> 
> Actual Results:
> =ADDRESS(1,1,1)
> 
> Expected Results:
> =ADDRESS(1,1,)

Why do you use "," for separation of arguments? You should use ";" for that
Comment 2 Andrey 2018-08-02 12:53:42 UTC 
it doesn't matter, issue reproduced for all types of separators.
Comment 3 Roman Kuznetsov 2018-08-02 13:03:05 UTC 
(In reply to Andrey from comment #2)
> it doesn't matter, issue reproduced for all types of separators.

I can't repro with ";".
Comment 4 Andrey 2018-08-02 13:12:15 UTC 
Created attachment 143931 [details]
Video proof
Comment 5 Andrey 2018-08-02 13:18:09 UTC 
(In reply to kompilainenn from comment #3)
> (In reply to Andrey from comment #2)
> > it doesn't matter, issue reproduced for all types of separators.
> 
> I can't repro with ";".

Sorry about music, I forgot about it -_-
Comment 6 Buovjaga 2018-09-02 16:01:02 UTC 
I can repro. In a sense it is logical: if you leave a tracing , or ; Calc thinks you forgot something. So it fills the default value for reference (Abs).
Yet, this does not happen with, for example, MATCH.

In 3.3.0, the ADDRESS result is Err:511.
In 3.6.7 it behaves like today.

Arch Linux 64-bit
Version: 6.2.0.0.alpha0+
Build ID: 1c59d021b3dd27c8c0255312bd0d53ad25965bab
CPU threads: 8; OS: Linux 4.18; UI render: default; VCL: gtk3_kde5; 
Locale: fi-FI (fi_FI.UTF-8); Calc: threaded
Built on September 1st 2018
Comment 7 Eike Rathke 2019-02-26 10:00:27 UTC 
ABS(1,1,) has an empty omitted 3rd argument, which is semantically equivalent to ABS(1,1,1). As Buovjaga noted, older releases could not handle the omitted argument, thus it is stored as 1 for backward compatibility. Not a bug.