Bug 119158 - MacOS: WindowServer memory usage increases pointlessly every time when opening dialogs from the context menu
Summary: MacOS: WindowServer memory usage increases pointlessly every time when openin...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: All macOS (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: perf
: 118633 (view as bug list)
Depends on:
Blocks: Memory
  Show dependency treegraph
 
Reported: 2018-08-08 15:34 UTC by Telesto
Modified: 2022-12-21 12:53 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2018-08-08 15:34:55 UTC
Description:
MacOS: WindowServer memory usage increases with 15 MB every time when opening the table properties using the context menu

Steps to Reproduce:
1. Open Writer
2. Insert a table; say 2x2
3. Double finger tab on the touchpad ("right click menu")
4. table Properties
5. Press cancel
6. Repeat 3-5 (continuing bump in MemoryServer usage)

It's only happing using the context menu (not happening when doing the same with toolbar or menu item)

The Instrument leak profile is detecting some leaking, but it doesn't match the WindowServer issue

Actual Results:
WindowServer memory increases (with release)

Expected Results:
Same behaviour as when using the menu/toolbar


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.2.0.0.alpha0+
Build ID: 76bf3939b0583212a56c317c85aea110f8ac6fee
CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2018-07-27_06:01:47
Locale: nl-NL (nl_NL.UTF-8); Calc: group threaded
Comment 1 Telesto 2018-08-08 15:45:30 UTC
Not specific to tables; also happens with any dialog openend from the 'right click' context menu
Comment 2 Telesto 2018-08-16 11:37:57 UTC
Something similar happening when using the context menu spell checker. WindowServer increases around 0,2 MB for every correction applied from the context menu
Comment 3 Telesto 2018-08-27 08:54:35 UTC
Repro with
Version: 6.2.0.0.alpha0+
Build ID: 85818da3307a28b2d9c6fa5c1c97ca7833dfe24c
CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2018-08-22_04:15:46
Locale: nl-NL (nl_NL.UTF-8); Calc: threaded

Note, for what it's worth: WindowsServer memory usage won't drop back to proportions, even after closing LibreOffice. However, running a presentation (F5) after re-lauching LibO fixes it.
Comment 4 Telesto 2018-08-27 08:56:52 UTC
@Alex
Would you mind to (un)confirm this?
Comment 5 Alex Thurgood 2018-08-27 09:42:39 UTC
Confirming with

Version: 6.2.0.0.alpha0+
Build ID: b8658c0e847afe1ed199c5fa7a2dd5d1d61ccbac
CPU threads: 4; OS: Mac OS X 10.13.6; UI render: default; 
Locale: fr-FR (fr_FR.UTF-8); Calc: threaded
Comment 6 Alex Thurgood 2018-08-27 09:45:02 UTC
When watching the trace in the Instruments.app, I see All Heap and VM Allocations increasing each time by about 10Mb when the Properties dialog is called up via the context menu, and only about 5Mb being release when the menu is closed, which means that on average an additional 5Mb memory is being used each context menu cycle for the table properties.
Comment 7 Alex Thurgood 2018-08-27 10:03:54 UTC
For example :

1) Start LibreOffice, wait for StartCenter window to appear : 39 Mb persistent

2) Start Writer blank document : 50Mb persistent

3) Add 2x2 table : shoots up to 64Mb persistent

4) RMB Table Properties : shoots up to 78 Mb persistent

5) Cancel dialog : drops to 75Mb persistent

6) Repeat step 4 : shoots up to 83Mb persistent

7) Repeat step 5 : drops to 80Mb persisten

8) Repeats steps 4 and 5 again : increase to 88Mb, then drops to 85Mb

9) Repeat steps 4 and 5 again : increase to 93Mb, then drops to 90Mb

and so on...
Comment 8 Telesto 2018-08-27 11:38:24 UTC
*** Bug 118633 has been marked as a duplicate of this bug. ***
Comment 9 Telesto 2018-08-27 12:31:52 UTC
(In reply to Alex Thurgood from comment #6)
> When watching the trace in the Instruments.app, I see All Heap and VM
> Allocations increasing each time by about 10Mb when the Properties dialog is
> called up via the context menu, and only about 5Mb being release when the
> menu is closed, which means that on average an additional 5Mb memory is
> being used each context menu cycle for the table properties.

The dialogs are leaking for sure. However I should note that is was (and is) about the increase of the WindowsServer process. Not about internal LibO leaking. 
It's quite possible that both are related, though.
Comment 10 QA Administrators 2021-01-11 03:55:55 UTC
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug