Bug 119167 - The Track changes toolbar is appended to the Table toolbar, should be stacked and pinned left
Summary: The Track changes toolbar is appended to the Table toolbar, should be stacked...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.3 all versions
Hardware: All All
: medium normal
Assignee: Gabor Kelemen (allotropia)
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Writer-Toolbars
  Show dependency treegraph
 
Reported: 2018-08-09 09:52 UTC by Gabor Kelemen (allotropia)
Modified: 2020-08-13 18:03 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments
Example document with tracked changes in a table (10.61 KB, application/vnd.oasis.opendocument.text)
2018-08-09 09:52 UTC, Gabor Kelemen (allotropia)
Details
Track changes toolbar with a changed paragraph. (26.67 KB, image/png)
2018-08-09 09:54 UTC, Gabor Kelemen (allotropia)
Details
Track changes toolbar and Table toolbar (40.95 KB, image/png)
2018-08-09 09:55 UTC, Gabor Kelemen (allotropia)
Details
Track changes toolbar and Bullets/Numbering toolbar (38.60 KB, image/png)
2018-08-09 09:56 UTC, Gabor Kelemen (allotropia)
Details
Screenshot of proposed patch (67.12 KB, image/png)
2019-02-25 23:40 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2018-08-09 09:52:55 UTC
Created attachment 144054 [details]
Example document with tracked changes in a table

When a document contains tracked changes in a table and one uses the Track changes toolbar to move between changes or accept/reject them, the Table toolbar appears at the bottom left of the window, pushing the Track changes toolbar to the right.

If the user was continuously pushing the Next change button of the TC toolbar and enters the table, she finds the Add column button of the Table toolbar under the cursor, so she has to reposition the cursor to continue reviewing the changes - and back again once out of the table.

As a comparison, if the document contains tracked changes in a Bulleted / Numbered list the Bullets/Numbering toolbar automatically appears above the Track changes toolbar at the bottom of the window without interfering with it.

Similar behavior of the Table toolbar would be a good solution.

Version: 6.2.0.0.alpha0+
Build ID: ea59fc4831b9d2430de51faa8c3e0a24e6d90cd1
CPU threads: 4; OS: Windows 6.3; UI render: default; 
Locale: hu-HU (hu_HU); Calc: CL
Comment 1 Gabor Kelemen (allotropia) 2018-08-09 09:54:14 UTC
Created attachment 144055 [details]
Track changes toolbar with a changed paragraph.

Click Next Change here a few times...
Comment 2 Gabor Kelemen (allotropia) 2018-08-09 09:55:54 UTC
Created attachment 144056 [details]
Track changes toolbar and Table toolbar

...now click once more carelessly and you add a column right of the current change.
Comment 3 Gabor Kelemen (allotropia) 2018-08-09 09:56:53 UTC
Created attachment 144057 [details]
Track changes toolbar and Bullets/Numbering toolbar

The Bullets/Numbering toolbar however does not interfere with the workflow.
Comment 4 Cor Nouws 2018-08-22 17:26:02 UTC
+1
Comment 5 Dieter 2018-08-26 12:56:14 UTC
I changed status to NEW. It is clear, that design team can decide WONTFIX.
Comment 6 V Stuart Foote 2018-08-26 13:33:31 UTC
Agree, the Table toolbar should be keep in its position. The Track Changes toolbar should be stacked above it (or below it) and pinned left, rather than being appended to Table toolbar.
Comment 7 Heiko Tietze 2018-08-27 07:09:32 UTC
+1
Comment 8 Xisco Faulí 2018-08-27 14:21:35 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=6f8f053a22a9010b50e6142443909bd31d5501df

author	Caolán McNamara <caolanm@redhat.com>	2016-11-21 14:33:31 +0000
committer	Caolán McNamara <caolanm@redhat.com>	2016-11-21 14:54:58 +0000
commit 6f8f053a22a9010b50e6142443909bd31d5501df (patch)
tree bfa9a22031e1b0f111b11b489d4aaf6f4c8a1030
parent 66ccfcd2908445b8194c364c89778056374b02af (diff)
set the search toolbar so it doesn't move around wrt table/numbering toolbars

Bisected with: bibisect-linux-64-5.3

Adding Cc: to Caolán McNamara
Comment 9 Gabor Kelemen (allotropia) 2019-02-25 23:40:26 UTC
Created attachment 149587 [details]
Screenshot of proposed patch

With my patch this is how the bottom docked toolbars look.

When one creates a change tracked numbering in a table cell and shows the Search toolbar, all four appear on top of each other.

https://gerrit.libreoffice.org/68365
Comment 10 Commit Notification 2019-02-26 07:26:39 UTC
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/0631a91c1dafbd754a8d2bc2ccae03b547754cbd%5E%21

tdf#119167 Show Table toolbar above Track Changes toolbar

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Heiko Tietze 2019-02-26 07:26:58 UTC
(In reply to Gabor Kelemen from comment #9)
> When one creates a change tracked numbering in a table cell and shows the
> Search toolbar, all four appear on top of each other.

Pushed to master. At least it wont jump too much but the pile is quite large. Let's see if users accept it.
Comment 12 Dieter 2019-07-19 15:05:26 UTC
I don't get the result, that is shown in attachment 149587 [details].

Table toolbar is placed left of the track changes toolbar. This is better than before, but I hope that an improvement is still possible.

Shall I reopen the bug?

Version: 6.4.0.0.alpha0+ (x64)
Build ID: 2f2f4767089512c34514896bc37823f9310e9dd4
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-07-10_02:13:57
Locale: de-DE (de_DE); UI-Language: en-US
Calc: threaded
Comment 13 Dieter 2020-08-13 18:03:08 UTC
It looks perfect to me with

Version: 7.1.0.0.alpha0+ (x64)
Build ID: <buildversion>
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded

=> VERIFIED FIXED