Bug 119176 - AutoCorrect: Small interruptions cause additional words which don't exist (comment 7 isue 2)
Summary: AutoCorrect: Small interruptions cause additional words which don't exist (co...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.3 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, regression
Depends on:
Blocks: AutoCorrect-Complete
  Show dependency treegraph
 
Reported: 2018-08-09 13:48 UTC by Telesto
Modified: 2018-09-10 19:26 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Bibisect log (6.63 KB, text/plain)
2018-09-05 09:36 UTC, Telesto
Details
Autocorrect behaviour (43.67 KB, image/png)
2018-09-07 14:20 UTC, Regis Perdreau
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2018-08-09 13:48:33 UTC
Description:
Autocomplete is a little overzealous. I get three entries Word completion entr's when typing the composition word "hulpvaardigheid"  
1. Hulpvaar (a non-existing word)
2. Hulpvaardig (a normal dictionary word)
3. Hulpvaardigheid (a normal dictionary word)

I would only expect hulpvaardigheid

Steps to Reproduce:
1. Open Writer (with a dutch language & dutch dictionary)
2. Type "hulpvaardigheid" 
3. Type "hulpvaardigheid" again an take notice at the suggestions or look at Tools -> AutoCorrect -> Autocorrect options -> Word Completion

Actual Results:
Three entries in the Word completion list

Expected Results:
Only one entry


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.2.0.0.alpha0+
Build ID: 76bf3939b0583212a56c317c85aea110f8ac6fee
CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2018-07-27_06:01:47
Locale: nl-NL (nl_NL.UTF-8); Calc: group threaded
Comment 1 Telesto 2018-08-09 13:59:09 UTC
Same happening when typing "Characters". Two entries
Comment 2 Buovjaga 2018-09-02 17:17:47 UTC
Xavier: can you repro this?

I don't repro with "Characters".
Comment 3 Xavier Van Wijmeersch 2018-09-02 18:35:17 UTC
@Buovjaga

I do not use Word completion, sorry about that.

Version: 6.2.0.0.alpha0+
Build ID: cecf71c18da5430c10daa8522d38d5144edefc14
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; 
Locale: nl-BE (en_US.UTF-8); Calc: threaded
Comment 4 Dieter Praas 2018-09-02 18:58:50 UTC
I confirm it with german language and

Version: 6.0.6.2 (x64)
Build-ID: 0c292870b25a325b5ed35f6b45599d2ea4458e77
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; 
Gebietsschema: de-DE (de_DE); Calc: group

Example: Datenspeicher
When I type Dat LO gives the suggestion "Datenspeiche" (word doesn't exist). Entra in Word-Completion are "Datenspeiche" and "Datenspeicher"
Comment 5 Telesto 2018-09-03 08:42:55 UTC
No repro with
Version: 4.3.7.2
Build ID: 8a35821d8636a03b8bf4e15b48f59794652c68ba
Comment 6 Xisco Faulí 2018-09-03 17:42:13 UTC
Any way to reproduce it in English ?
Comment 7 Telesto 2018-09-03 19:44:06 UTC
(In reply to Xisco Faulí from comment #6)
> Any way to reproduce it in English 

There are in fact two issues. 
1. The fact that multiple words are added to autocomplete while typing 1 word. Example: painlessness adds: painless & painlesness. 'proper' suggestions, but unwanted. Also found in 4.0.0.3 & only happening with spell checker enabled

2. The seconds issue is with a arithmetic typing pace. Small interruptions cause additional words which don't exist. For Dutch: type: hulpvaardighei (wait 2 sec) type d. hulpvaardighei will be added to the suggestions. Not happening in 4.3.7.2)
German: Datenspeicher When I type Dat LO gives the suggestion "Datenspeiche" (word doesn't exist). Entra in Word-Completion are "Datenspeiche" and "Datenspeicher"

No clue how to reproduce it in English. Tried a few times, but can't come up with something..
Comment 8 Telesto 2018-09-04 14:17:41 UTC
Bisected comment 7 issue 2 about "hulpvaardighei" as auto complete suggestion

$ git bisect skip
There are only 'skip'ped commits left to test.
The first bad commit could be any of:
8bd0d65a2f8b8b9ebaf4fb235705975d8919b8ff
6b98ad36f8ae972792caca5ce41e3d22fdc5e6b8
952e9feecaa5671020aae8cf96fc3a1d36aa7cec
210e1edcd151d5307f959368a5ecc11f20348a8e
We cannot bisect more!

Commit https://cgit.freedesktop.org/libreoffice/core/commit/?id=aebf05f324661a07f4124a4c48b6fc889d4bfbf6 looks like possible candidate. There is change in "EdtAutoCorrDoc"
Comment 9 Telesto 2018-09-04 14:36:02 UTC
Splitting: new bug for comment 7 under 1
Comment 10 Xisco Faulí 2018-09-04 14:39:58 UTC
> Commit
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=aebf05f324661a07f4124a4c48b6fc889d4bfbf6 looks like possible candidate.
> There is change in "EdtAutoCorrDoc"

Adding Noel to the loop
Comment 11 Noel Grandin 2018-09-04 20:50:38 UTC
What do the other commits in the bisect range correspond to?
Comment 12 Telesto 2018-09-05 09:36:34 UTC
Created attachment 144691 [details]
Bibisect log

# possible first bad commit: [210e1edcd151d5307f959368a5ecc11f20348a8e] source s                                                    ha:c840c49b62b919ec4d0d947fe8cd530a785cf80d
# possible first bad commit: [6b98ad36f8ae972792caca5ce41e3d22fdc5e6b8] source s                                                    ha:fc88ed47a66e76d279471c1da1193ce90ad8e9e5
# possible first bad commit: [8bd0d65a2f8b8b9ebaf4fb235705975d8919b8ff] source s                                                    ha:aebf05f324661a07f4124a4c48b6fc889d4bfbf6
# possible first bad commit: [952e9feecaa5671020aae8cf96fc3a1d36aa7cec] source s                                                    ha:29a9e97db65bcf5914aed9bf8cb8e8f38c3c5fc0

Hmm, "convert ATTRSPECIAL to scoped enum" can't be it. It's working (not sure why I skipped it)..  However I do reproduce it with:
 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=29a9e97db65bcf5914aed9bf8cb8e8f38c3c5fc0 (loplugin field-can-be-private in include/vcl..xmlscript)
Comment 13 Xisco Faulí 2018-09-07 09:28:45 UTC
Hi Telesto,
I'm trying to reproduce this issue but I don't know if I'm following the steps correctly.

1. Install Dutch spelling extension: https://extensions.openoffice.org/en/project/dutch-spelling-and-hyphenation-dictionary
2. Change document language to Dutch
3. Type 'hulpvaardighei'
4. Wait a few seconds
5. Type d after 'hulpvaardighei'
6. Press space bar
7. Go to Tools - AutoCorrect - AutoCorrect Options - Word Completion

-> 'hulpvaardid', 'hulpvaardighei' and 'hulpvaardigheid' are displayed on the list...
Comment 14 Regis Perdreau 2018-09-07 14:20:00 UTC
Created attachment 144740 [details]
Autocorrect behaviour
Comment 15 Regis Perdreau 2018-09-07 14:20:56 UTC
Reproduced in french and dutch, if i have understood the procedure ... see attachment. ( i have changed the language for all text)

Version: 6.0.3.2
Build ID: 1:6.0.3-0ubuntu1
Threads CPU : 4; OS : Linux 4.15; UI Render : par défaut; VCL: x11; 
Locale : nl-NL (fr_FR.UTF-8); Calc: group
Comment 16 Telesto 2018-09-07 15:11:32 UTC
(In reply to Xisco Faulí from comment #13)
1. Copy the dictionary's from a normal release build (share/extensions) (but extension should work to)
2. Change document language to Dutch (for me default setting, but doesn't matter
3. Type hulpvaardigheid (without pause; not really needed)
4. Press Enter
5. Type hulpvaardigheid again
6. Go to Tools - AutoCorrect - AutoCorrect Options - Word Completion

-> Three entry's: hulpvaardig (unwanted; but not wrong); hulpvaardighei (wrong) and hulpvaardigheid
Comment 17 Telesto 2018-09-10 16:51:51 UTC
The underlying issue might be older...

Hulpvaardigheid is working fine with 4.3.7.2. However, weirdness happens with:
bewijslast -> wrong: bewijsla & bewijslas
bewijsrisico -> bewijsris
Comment 18 Telesto 2018-09-10 19:26:00 UTC
(In reply to Telesto from comment #17)
> The underlying issue might be older...
> 
> Hulpvaardigheid is working fine with 4.3.7.2. However, weirdness happens
> with:
> bewijslast -> wrong: bewijsla & bewijslas
> bewijsrisico -> bewijsris

Typing bewijslas + pause+ t & enter (3x) = entry bewijslas

Found in:
Version: 4.3.0.4
Build ID: 62ad5818884a2fc2e5780dd45466868d41009ec0

but not in 
4.2.0.4