Bug 119246 - Dimensions dialog has wrong values in fields "Line distance", "Left guide" and "Right guide"
Summary: Dimensions dialog has wrong values in fields "Line distance", "Left guide" an...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
4.2.0.4 release
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Julien Nabet
URL:
Whiteboard: target:7.5.0 target:7.4.1 target:7.3.6
Keywords: bibisectNotNeeded, regression
Depends on:
Blocks: Dialog
  Show dependency treegraph
 
Reported: 2018-08-13 12:11 UTC by Regina Henschel
Modified: 2022-08-11 08:21 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Dimension line shape to reproduce the bug (9.57 KB, application/vnd.oasis.opendocument.graphics)
2018-08-13 12:11 UTC, Regina Henschel
Details
Commented screenshot (105.80 KB, application/vnd.oasis.opendocument.graphics)
2018-08-13 12:12 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2018-08-13 12:11:17 UTC
Created attachment 144142 [details]
Dimension line shape to reproduce the bug

Open attached file. Click on the measure line and open the Dimensions dialog from the context menu. Notice, that the fields "Line distance", "Left guide" and "Right guide" do not show the actual values. In fact the values in these fields are limited to 1cm, although the values in the drawing can be larger.

It was OK in Version 4.0.1.2 (Build ID: 84102822e3d61eb989ddd325abf1ac077904985)

It fails in Version: 4.5.0.0.alpha0+
Build ID: 40b1e8266e47792d354cd457c652bfb0f0a21e69
TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2015-02-11_00:13:43
Locale: en_US
Comment 1 Regina Henschel 2018-08-13 12:12:42 UTC
Created attachment 144143 [details]
Commented screenshot

The file has a commented screenshot, so that you can easier see, which distance in the drawing belongs to which field in the dialog.
Comment 2 Buovjaga 2018-09-07 18:35:24 UTC
Repro.

Tried to bibisect on Linux with 42max, but unfortunately it has many commits, where the dialog is shown in a huge size with only the OK, Cancel, Help buttons visible.

When I did git bisect visualize, the remaining suspects included a repo commit with a large number of non-buildable commits.

Arch Linux 64-bit
Version: 6.2.0.0.alpha0+
Build ID: 033a68c49fe2b8aa397832d92d400eb0259ea809
CPU threads: 8; OS: Linux 4.18; UI render: default; VCL: gtk3_kde5; 
Locale: fi-FI (fi_FI.UTF-8); Calc: threaded
Built on September 5th 2018
Comment 3 QA Administrators 2021-02-22 04:00:01 UTC Comment hidden (obsolete)
Comment 4 Regina Henschel 2021-02-22 12:50:27 UTC
The error still exists in Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: d49277fc7c017c5a62a0c28af782cfc04a6460ab
CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL
Comment 5 Julien Nabet 2022-07-28 09:14:22 UTC
The mechanism is in cui/uiconfig/ui/dimensionlinestabpage.ui and 
cui/source/tabpages/measure.cxx

Taking a look at git history of cui/source/tabpages/measure.cxx, I noticed: a8dd49b9fc59371ff8edb31082bbd4f1b6179b1c
Convert dimension lines tab page to widget UI
(see https://cgit.freedesktop.org/libreoffice/core/commit/?id=a8dd49b9fc59371ff8edb31082bbd4f1b6179b1c)

There was:
-    MetricField MTR_LINE_DIST
-    {
-        HelpID = "cui:MetricField:RID_SVXPAGE_MEASURE:MTR_LINE_DIST";
-        Border = TRUE ;
-        Pos = MAP_APPFONT ( 78 , 14  ) ;
-        Size = MAP_APPFONT ( 42 , 12 ) ;
-        TabStop = TRUE ;
-        Repeat = TRUE ;
-        Spin = TRUE ;
-        Unit = FUNIT_MM ;
-        DecimalDigits = 2 ;
-        Minimum = -10000 ;
-        First = -10000 ;
-        Maximum = 10000 ;
-        Last = 10000 ;
-        SpinSize = 10 ;
-    };

so we should have range between -1000 and +1000 cm.
Comment 6 Julien Nabet 2022-07-28 09:25:57 UTC
I gave a try with https://gerrit.libreoffice.org/c/core/+/137553
Comment 7 Commit Notification 2022-07-28 11:05:31 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d39a6726b8583086215a4452ce6867eb20c118d8

tdf#119246: Dimensions dialog has wrong values in several fields

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Julien Nabet 2022-07-28 11:06:57 UTC
Patch waiting for review in 7.4 here:
https://gerrit.libreoffice.org/c/core/+/137523
Comment 9 Commit Notification 2022-07-28 11:54:53 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/38bd5a2a8c967acaf3bc79ca4a1167b3cdbddd8d

tdf#119246: Dimensions dialog has wrong values in several fields

It will be available in 7.4.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2022-08-09 15:07:30 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/f60240494420b590d00c064a2469922a921a4a19

tdf#119246: Dimensions dialog has wrong values in several fields

It will be available in 7.3.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2022-08-11 08:21:09 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/957bc2fe7093aa060f2e0abbc52cf107156e9a43

tdf#119246: sd: Add UItest

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.