Bug 119330 - BASE crash if WRITER is under tab interface
Summary: BASE crash if WRITER is under tab interface
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Julien Nabet
URL:
Whiteboard: target:6.2.0
Keywords: bibisected, haveBacktrace, regression
Depends on:
Blocks:
 
Reported: 2018-08-17 15:41 UTC by surbun
Modified: 2018-08-21 11:42 UTC (History)
4 users (show)

See Also:
Crash report or crash signature: ["libc-2.27.so"]


Attachments
A BASE file containing some forms (427.82 KB, application/vnd.oasis.opendocument.database)
2018-08-17 15:46 UTC, surbun
Details
gdb bt (20.53 KB, text/plain)
2018-08-18 16:30 UTC, Julien Nabet
Details
screen shot Base form w/Tabbed notebook bar (240.20 KB, image/png)
2018-08-19 12:29 UTC, Drew Jensen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description surbun 2018-08-17 15:41:48 UTC
Description:
If WRITER is configured using any other interface options beside the standard one, BASE crash on opening a form.

When WRITER interface is standard, no crash occur otherwise, BASE crash everytimes.

Steps to Reproduce:
1.Open WRITER
2.Choose "View" - "User Interface" - "Tabbed"
3.Open a BASE file with some forms
4.Open any of the existing forms

Actual Results:
BASE crash

Expected Results:
BASE open the required form



Reproducible: Always


User Profile Reset: Yes



Additional Info:
If these steps is followed, BASE won't crash

1.Open WRITER
2.Choose "View" - "User Interface" - "Standard Toolbar"
3.Open a BASE file with some forms
4.Open any of the existing forms
Comment 1 surbun 2018-08-17 15:46:22 UTC
Created attachment 144254 [details]
A BASE file containing some forms

I join a BASE file for tests
Comment 2 Drew Jensen 2018-08-18 15:58:04 UTC
Confirmed with Ubuntu 18.04 and 6.2 

Crash report at 
crashreport.libreoffice.org/stats/crash_details/d8e08f62-e23d-463d-8db8-5506fdb221e9
Comment 3 Drew Jensen 2018-08-18 16:02:29 UTC
it does not happen using Version: 6.1.1.0.0+ 
Build id: 30c178dcb3301527ad92bbd245d1525ab77e314e

marking as regression and bibisectRequest

Will go ahead and start that bibisect against the daily master repo.
Comment 4 Julien Nabet 2018-08-18 16:30:54 UTC
Created attachment 144272 [details]
gdb bt

On pc Debian x86-64 with master sources updated today, I could reproduce this.

I attached a bt (+gdb session) with some console logs.

To retrieve this bt, I had to add a breakpoint:
b vcl/source/window/builder.cxx:367
Comment 5 Drew Jensen 2018-08-18 16:55:09 UTC
OK, the bibisect tool says the issue arrived with commit: f33ca5e3ba342e8251ab8177105a9b4b231b73e0

ofz#7621 tight OUString concat loop causes libfuzzer oom
it doesn't get a chance to release memory and falls over with
an oom

Change-Id: I20eb91223de3aa00f3e2f4131ad212f1cfde6ff3

1 file changes: svtools/source/svhtml/parhtml.cxx

author	Caolán McNamara <caolanm@redhat.com> (adding to CC)
Comment 6 Julien Nabet 2018-08-18 17:32:09 UTC
I think it rather eems related to https://cgit.freedesktop.org/libreoffice/core/commit/?id=dcbb65f2a4a3ee70ccd4896d7a5e975dbd9e6509
I'm taking a look. If I don't find why, I'll revert my commit.
Comment 7 Julien Nabet 2018-08-18 17:55:31 UTC
Patch submitted on gerrit here:
https://gerrit.libreoffice.org/#/c/59296/
Comment 8 Commit Notification 2018-08-18 19:35:38 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6c89f41b02fcd8918e535460994daac4ecd5d37e

tdf#119330: fix regression in SfxNotebookBar.cxx

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Julien Nabet 2018-08-18 19:37:23 UTC
Let's put this one to FIXED.

Don't hesitate to reopen this tracker if you still reproduce this.
Comment 10 Drew Jensen 2018-08-19 12:29:10 UTC
Created attachment 144300 [details]
screen shot Base form w/Tabbed notebook bar

Well, that did stop it from crashing.

Now the problem is that the 'oddball' UI is present when the Base form (writer file) is opened and most of that doesn't work in this context - but it looks really cool ;-) 

Not quite sure what to do with this issue therefore?
Comment 11 Julien Nabet 2018-08-19 12:37:52 UTC
(In reply to Drew Jensen from comment #10)
> Created attachment 144300 [details]
> screen shot Base form w/Tabbed notebook bar
> 
> Well, that did stop it from crashing.
> 
> Now the problem is that the 'oddball' UI is present when the Base form
> (writer file) is opened and most of that doesn't work in this context - but
> it looks really cool ;-) 
> 
> Not quite sure what to do with this issue therefore?

I don't understand what you mean, what "oddball"? I don't see anything strange on the screenshot.
I used Tabbed interface and could fill a line in the same form. There's no hang or some kind of freeze
Comment 12 Drew Jensen 2018-08-19 12:57:54 UTC
If the notebook (tabbed or otherwise) interface is now available for Base forms that is new (the interface is oddball in that it was not available here before, that is what I meant). 

Also, there was no way to leave the new notebook bar with a Form (the menu item did nothing)

However, Reports (not the designer) also displayed the notebook bar, but the items are more fully working and here you can return to the standard toolbar interface. 

With that change made in the Report document window a Forms are back the Standard Toolbar again, and again in the Form window you can not change it back to notebook.

You can change back to notebook UI in the Report window however and that will again change the Forms.
Comment 13 Julien Nabet 2018-08-19 13:24:33 UTC
Drew: please create a new bugtracker since there's no more crash here.

I don't know what's expected, moreover Tabbed is experimental.
I don't know if my commits reveal a bug or created the bug.
In all cases, feel free to revert my commits since the initial purpose was just to remove one of the many annoying error console logs that almost nobody ever cares.

I don't know why we got so much experimental features. After some time (a year?), if nobody cares about an experimental feature, it should be removed.
Comment 14 Drew Jensen 2018-08-19 14:54:39 UTC
(In reply to Julien Nabet from comment #13)
> Drew: please create a new bugtracker since there's no more crash here.
> 

Will do.