Bug 119416 - Use Enter key to open Special characters dialog when keyboard focus is on Insert Special characters drop down button
Summary: Use Enter key to open Special characters dialog when keyboard focus is on Ins...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Jim Raykowski
URL:
Whiteboard: target:6.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-22 07:19 UTC by Jim Raykowski
Modified: 2018-09-23 18:38 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
6.1 vs 6.2 (1.98 MB, video/mp4)
2018-09-15 14:58 UTC, BogdanB
Details
f6 - arrow - ENTER (196.10 KB, video/mp4)
2018-09-17 05:07 UTC, BogdanB
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Raykowski 2018-08-22 07:19:03 UTC
This would be consistent with Enter key action when keyboard focus is on Insert Table or Insert Fields split buttons.
Comment 1 V Stuart Foote 2018-08-22 13:57:34 UTC
Yup, it is needed UX for keyboard navigation and wold match the dialog opening behavior of other insertion split buttons: Table, Field--as noted--but also Section, and AutoText

Frame (Interactively) the exception as it is the complex alternate to Frame dialog.
Comment 2 Jim Raykowski 2018-08-23 21:17:13 UTC
I have mistakenly refered to this toolbar control as a split. It is actually a drop down control.

Here is a patch to provide for the Special Characters dialog to open when focus is on this toolbar item and the Enter key is press:
https://gerrit.libreoffice.org/#/c/59528/

Testing and comments are appreciated.
Comment 3 Commit Notification 2018-08-24 13:03:10 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=80d6cba424439803704dbddf4fc832bd73e90e97

tdf#119416 Open Special Characters dialog on Enter key press

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 BogdanB 2018-09-15 14:58:23 UTC
Created attachment 144897 [details]
6.1 vs 6.2

Please see the video. I tested this insert button on both versions: 6.1 and 6.2. On both test I type "TEST" to see the ENTER action. 

On 6.1 if I am on Insert Special button and click ENTER: I modify paragraf.

On 6.2 if I am on Insert Special button and click ENTER nothing is happening. After one click I open a new little menu, and here I can click ENTER and open the Insert Special window. This is how it should be?
Comment 5 Jim Raykowski 2018-09-17 00:02:09 UTC
(In reply to BogdanB from comment #4)
Hello BogdanB,

There are two versions of the Insert Special Characters toolbar function. One is a push button and the other is a drop down button. Both versions open the Special Characters dialog when they have keyboard focus and the Enter key is pressed. 

Observing the video you made, even though the button is highlighted when the mouse pointer is placed on the Insert Special Character button, the keyboard focus is still in the document view as can be seen by the flashing cursor in the document view. Keyboard focus can be moved to the Insert Special Characters button by pressing the F6 key until keyboard focus is on the first button in the Standard toolbar and then pressing the right arrow key to move the focus to the Insert Special Characters button. Pressing the Enter key when keyboard focus is on the Insert Special Characters button will then open the Special Characters dialog.
Comment 6 BogdanB 2018-09-17 05:07:02 UTC
Created attachment 144924 [details]
f6  - arrow - ENTER

I made a new video, tested with F6 and arrows and finally ENTER. This is the right behaviour?
Comment 7 Jim Raykowski 2018-09-23 17:42:15 UTC
(In reply to BogdanB from comment #6)
> Created attachment 144924 [details]
> f6  - arrow - ENTER
> 
> I made a new video, tested with F6 and arrows and finally ENTER. This is the
> right behaviour?

Yes