Bug 119491 - FILESAVE: password protected shared spreadsheet loses password on save
Summary: FILESAVE: password protected shared spreadsheet loses password on save
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha1+
Hardware: All All
: high major
Assignee: Balázs Varga (allotropia)
URL:
Whiteboard: target:7.5.0 target:7.4.0.2
Keywords: bibisected, bisected
Depends on:
Blocks: Password-Protected
  Show dependency treegraph
 
Reported: 2018-08-25 09:01 UTC by Oliver Brinzing
Modified: 2022-07-19 17:56 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
with pw "test" protected shared document (11.56 KB, application/vnd.oasis.opendocument.spreadsheet)
2018-08-25 09:01 UTC, Oliver Brinzing
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Brinzing 2018-08-25 09:01:39 UTC
Created attachment 144418 [details]
with pw "test" protected shared document

steps to reproduce:
- create a new spreadsheet
- enter some text in a cell
- save with password: test
- Menu Tools/Share Spreadsheet...
  [x] Share this spreadsheet with other users
- MsgBox: This file contains queries. 
          The results of these queries were not saved.
          Do you want these queries to be repeated?
- [Yes]
- save
- close
- open - enter password: test
- enter some text in a cell
- save
- close
- open - no password required
Comment 1 MM 2018-08-25 17:52:12 UTC
Confirmed on windows 7 x64 with Version: 6.0.6.2 (x64)
Build ID: 0c292870b25a325b5ed35f6b45599d2ea4458e77
CPU threads: 3; OS: Windows 6.1; UI render: default

You can already see that it's not protected anymore, as you can see the content of the file in the preview / recent files window.
Comment 2 Xisco Faulí 2018-08-27 15:37:38 UTC
Not reproducible it Save as is used in the second save
Comment 3 Xisco Faulí 2018-08-27 15:53:17 UTC
Before https://cgit.freedesktop.org/libreoffice/core/commit/?id=669c12d59b6131f44945f166c77ae98df52ebb9e, it wasn't possible to save the document the second time -> See the steps: https://bugs.documentfoundation.org/show_bug.cgi?id=56173#c0

Now, it's possible to save it but the password is gone.

@Markus Mohrhard, I thought you could be interested in this issue...
Comment 4 QA Administrators 2019-09-02 09:27:47 UTC Comment hidden (noise)
Comment 5 Oliver Brinzing 2019-09-02 16:58:42 UTC Comment hidden (obsolete)
Comment 6 QA Administrators 2022-07-13 03:30:13 UTC Comment hidden (noise)
Comment 7 Oliver Brinzing 2022-07-14 05:34:54 UTC
reproducible with:

Version: 7.3.4.2 (x64) / LibreOffice Community
Build ID: 728fec16bd5f605073805c3c9e7c4212a0120dc5
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc:
Comment 8 Commit Notification 2022-07-19 13:41:17 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8fa6a1f628ca9df5d910db2b2aa7328e1d6220d7

tdf#119491 sc odf export: fix password protection of shared files

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2022-07-19 17:56:34 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/e0688221202176cb4d5dfb91ae777afb3075d956

tdf#119491 sc odf export: fix password protection of shared files

It will be available in 7.4.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.