Bug 119531 - Rotation Dial for Image Does Not Work
Summary: Rotation Dial for Image Does Not Work
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Mike Kaganski
URL:
Whiteboard: target:6.2.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2018-08-27 08:17 UTC by Rizal Muttaqin
Modified: 2018-08-29 09:55 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Rotation dial (3.17 KB, image/jpeg)
2018-08-27 08:18 UTC, Rizal Muttaqin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rizal Muttaqin 2018-08-27 08:17:35 UTC
Description:
Insert an image to Writer, in the sidebar click Properties -> Position and Size there's graphical rotation dial. I could not change image rotation by using the rotation dial.

Reproducible also in Calc, Impress and Draw module.

It's happen in master, not in 6.1

Steps to Reproduce:
1. Open up Writer
2. Insert a image/picture
3. Try using rotation dial in Properties sidebar

Actual Results:
Rotation dial does not work

Expected Results:
Rotation dial work


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.2.0.0.alpha0+
Build ID: 58f2e4690b57f0fa7a95be3a023d54d8967f5529
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-08-23_23:45:59
Locale: id-ID (id_ID.UTF-8); Calc: threaded
Comment 1 Rizal Muttaqin 2018-08-27 08:18:43 UTC
Created attachment 144475 [details]
Rotation dial
Comment 2 Xisco Faulí 2018-08-27 09:15:50 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=8c48d69f06ddb3cb6c807a1e7db62dddb9778ded

author	Mike Kaganski <mike.kaganski@collabora.com>	2018-08-04 10:37:17 +0300
committer	Mike Kaganski <mike.kaganski@collabora.com>	2018-08-04 20:51:27 +0200
commit 8c48d69f06ddb3cb6c807a1e7db62dddb9778ded (patch)
tree 8b6bf137be41ebe93746c4958ab9106bbf5cc339
parent c05fbde6c870b7e6bc2f9bf642dc7d76215a496f (diff)
Use more basegfx deg<->rad functions, instead of direct formulas
Also make the functions constexpr.

Due to slight changes in floating-point arithmetics (90.0 instead of
180.0, M_PI2 instead of M_PI resp.), results might differ in last
digits (usually 17th decimal digit). This has lead to need to tweak
char2dump's PieChartTest unit test.

Bisected with: bibisect-linux64-6.2

Adding Cc: to Mike Kaganski
Comment 3 Mike Kaganski 2018-08-27 16:39:33 UTC
https://gerrit.libreoffice.org/59666
Comment 4 Commit Notification 2018-08-27 18:37:07 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=951f68a5ddfc7cf6a11bb91fcba0c56b7d933867

tdf#119531: use correct conversion direction

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2018-08-29 09:55:23 UTC
Verified in

Version: 6.2.0.0.alpha0+
Build ID: a922f56cbf25f78534cd2d36bf13a86a4f15d970
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: el-GR (ca_ES.UTF-8); Calc: threaded

@Mike Kaganski, Thanks for fixing this!!!