Created attachment 144533 [details] Screenshot of the failure We have tried to compile current master with VS 2017. While the compilation in itself succeeds, generating the msi installer fails with the error message on the screenshot. With VS 2015 and the same distro config we can generate the msi correctly.
Unfortunately, the real problem is mentioned in the build log much higher, not visible on the screenshot (and absent msm file is the result of that initial failure). Please provide a more complete build log (in text format).
oh, that is the merge module... still please the log is needed.
Created attachment 144566 [details] VS2017-MSI-installer-fails I attached the LOG file. (build.log) The build of libreoffice-6-0-6 branch was run with this configuration, on a Windows 10 Enterprise operating system under cygwin: --without-junit --without-helppack-integration --enable-extension-integration --enable-scripting-beanshell --enable-scripting-javascript --disable-ext-wiki-publisher --disable-ext-nlpsolver --disable-online-update --disable-breakpad --disable-odk --disable-gtk --with-myspell-dicts --enable-mergelibs --enable-pch --disable-ccache --disable-firebird-sdbc --with-ant-home=/cygdrive/c/cygwin64/source/apache-ant-1.9.5 --with-parallelism=8 --with-visual-studio=2017 --with-windows-sdk=8.1 --with-jdk-home=/cygdrive/c/Program Files (x86)/ojdkbuild/java-1.8.0-openjdk-1.8.0.181-1 --with-lang=en-US hu de fr it ru hr sk pl ro --with-package-format=msi --with-help --with-vendor=Unknown --enable-release-build
So, it turns out that it wasn't current master after all? it was 6.0.6? :-) (Btw, current master does not build with VS 2015.) It looks like https://cgit.freedesktop.org/libreoffice/core/commit/?id=2a055c05381824644cc9c71615578dbb9c6976e3 wasn't backported to 6.0 branch (simply because at the time when it was actual, VS 2017 included the _VC150_ msm, and now it is mainly built using VS 2015. So, you can cherry-pick the commit.
... and also https://cgit.freedesktop.org/libreoffice/core/commit/?id=6dce5d167ebbe1f69d2198b2809e0ae3e5451bd4 could be required - don't know if it is included in 6.0. I don't know what to do with this. You could propose the packports to the branch in gerrit, or you could close it WONTFIX. I don't know if this actually fits to still branch maintenance policy.
(In reply to Mike Kaganski from comment #4) > So, it turns out that it wasn't current master after all? it was 6.0.6? :-) > (Btw, current master does not build with VS 2015.) > No, master does not build (for us) with 2017. Look at the end of the attached file. 6-0 with 2015 builds fine, that's what he meant :).
(In reply to Gabor Kelemen from comment #6) > No, master does not build (for us) with 2017. Look at the end of the > attached file. ... ? Looking there, and what I see: > : PRODUCTVERSION=6.0 > ... > : BRANDPACKAGEVERSION=6.0 > ... > : UREPACKAGEVERSION=6.0.6.2.0 > ... > : PACKAGEVERSION=6.0.6.2.0 > ... > : UNIXBASISROOTNAME=libreoffice6.0 > ... > : ABOUTBOXPRODUCTVERSION=6.0.6.2.0 > ... > : BASEPRODUCTVERSION=6.0 > ... > : ERROR: ERROR: msm file not found: Microsoft_VC150_CRT_x86.msm ! at E:/libre/core/solenv/bin/modules/installer/windows/update.pm line 456.
Yes of course, it was LibreOffice-6-0-6. Creating an MSI installer from the current master with VS2017 works fine. (tested it with the same configuration except "--enable-release-build")
(In reply to Balázs Varga from comment #8) So the question is if cherry-picking the aforementioned commits improves things for you
Gabor, Balázs: Is this bug still relevant? Can you answer comment 9 please, or close it if it's outdated/fixed/WFM?
I assume it should be fine in master, 6-2 and 6-1. https://cgit.freedesktop.org/libreoffice/core/commit/?id=2a055c05381824644cc9c71615578dbb9c6976e3 should be cherry-picked if they want to build in 6-0 @Mike, thanks for your help. Closing as RESOLVED WONTFIX