Bug 119636 - XLSX file with 1500 comments in cells opens slow
Summary: XLSX file with 1500 comments in cells opens slow
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.1 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: filter:xlsx, haveBacktrace, perf
Depends on:
Blocks: XLSX-Comments
  Show dependency treegraph
 
Reported: 2018-09-01 18:33 UTC by Roman Kuznetsov
Modified: 2020-05-06 20:28 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example XLSX file with 1500 comments (60.02 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2018-09-01 18:34 UTC, Roman Kuznetsov
Details
Example ODS file with 1500 comments (23.26 KB, application/vnd.oasis.opendocument.spreadsheet)
2018-09-01 18:35 UTC, Roman Kuznetsov
Details
Callgrind output from master (fileopen xlsx) (6.25 MB, application/x-xz)
2018-09-24 07:16 UTC, Buovjaga
Details
This document is also open slowly (64.67 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2019-10-10 07:37 UTC, xiaohaodaye
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2018-09-01 18:33:56 UTC
Description:
Very long time opens XLSX file with 1500 comments in cells. About 50 sec in 

Version: 6.2.0.0.alpha0+ (x64)
Build ID: d0425778eef7ea20ccc19834c07d0b265f58baf0
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-08-08_03:06:53
Locale: ru-RU (ru_RU); Calc: CL

If I create ODS file with same content, then it opens about 6 sec

Steps to Reproduce:
1. Try open xlsx file from attach
2.
3.

Actual Results:
Very long time opens XLSX file with 1500 comments in cells

Expected Results:
XLSX file with 1500 comments in cells opens more fast (for example, as ODS with same content)


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Roman Kuznetsov 2018-09-01 18:34:40 UTC
Created attachment 144596 [details]
Example XLSX file with 1500 comments
Comment 2 Roman Kuznetsov 2018-09-01 18:35:10 UTC
Created attachment 144597 [details]
Example ODS file with 1500 comments
Comment 3 raal 2018-09-05 20:54:29 UTC
I can confirm with Version: 6.2.0.0.alpha0+
Build ID: 4b5fcd417587cfb9e6d8b61ecb037ab165eeb5b9
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk3; 
and 4.1

3 sec ODS, 20 sec XLSX
Comment 4 Buovjaga 2018-09-24 07:16:49 UTC
Created attachment 145131 [details]
Callgrind output from master (fileopen xlsx)

Arch Linux 64-bit
Version: 6.2.0.0.alpha0+
Build ID: 8b1501d80dc9d3f42c351c6e026fa737e116cae5
CPU threads: 8; OS: Linux 4.18; UI render: default; VCL: gtk3_kde5; 
Locale: fi-FI (fi_FI.UTF-8); Calc: threaded
Built on 23 September 2018
Comment 5 Roman Kuznetsov 2019-04-22 14:09:28 UTC
Noel, may be you will be interesting this bug
Comment 6 Xisco Faulí 2019-04-23 21:16:17 UTC
it takes 

real	0m12,171s
user	0m11,854s
sys	0m0,282s

in

Version: 6.3.0.0.alpha0+
Build ID: 0a04150b6eefb5feb7ecefaa5cd63dbac8c1574f
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Kompi, could you please recheck ?
Comment 7 Roman Kuznetsov 2019-04-24 13:57:53 UTC
(In reply to Xisco Faulí from comment #6)
> it takes 
> 
> real	0m12,171s
> user	0m11,854s
> sys	0m0,282s
> 
> in
> 
> Version: 6.3.0.0.alpha0+
> Build ID: 0a04150b6eefb5feb7ecefaa5cd63dbac8c1574f
> CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
> Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
> Calc: threaded
> 
> @Kompi, could you please recheck ?

I got 22 sec in build from 24 April 2019

Version: 6.3.0.0.alpha0+
Build ID: 951282a27a9dd4c64fc206fcbdd805b4cb602816
CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded

There is a progress here. But I see that file opens faster in Linux than in Windows. Another problem?
Comment 8 Xisco Faulí 2019-04-25 10:15:45 UTC
(In reply to Roman Kuznetsov from comment #7)
> 
> I got 22 sec in build from 24 April 2019

it doesn't sound like 'very long time' to me. Updating summary
Comment 9 Roman Kuznetsov 2019-04-25 10:42:50 UTC
(In reply to Xisco Faulí from comment #8)
> (In reply to Roman Kuznetsov from comment #7)
> > 
> > I got 22 sec in build from 24 April 2019
> 
> it doesn't sound like 'very long time' to me. Updating summary

but it's still in about 4 time more than ODS

I don't think it is "small delay"
Comment 10 b. 2019-05-30 18:32:01 UTC
comments are slow in calc anyway, since 'inherited from OO', and reported since #76324 and plenty subsequent, 

i - assume - your problem is not a single special bug, but just a facet of the / one major problem in design ...

at least it's helpless to work on it while the main issue remains, as the results would be covered by the overall delays.
Comment 11 xiaohaodaye 2019-10-10 07:37:26 UTC
Created attachment 154887 [details]
This document is also open slowly
Comment 12 Roman Kuznetsov 2020-01-10 13:34:17 UTC
takes 20 sec in

Version: 6.5.0.0.alpha0+ (x64)
Build ID: b6295e4a1b7735c148174f44f6d28221f4f52302
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded
Comment 13 Roman Kuznetsov 2020-05-06 20:28:29 UTC
it takes about 10 sec in

Version: 7.0.0.0.alpha0+ (x64)
Build ID: d8a52f21ce23a37f7d1137501...
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win; 
Locale: ru-RU (ru_RU); UI: en-US
Calc: threaded

and without skia it takes about 10 sec too