Bug 119696 - Fix miscellaneous issues for Norwegian spell checking support
Summary: Fix miscellaneous issues for Norwegian spell checking support
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Linguistic (show other bugs)
(earliest affected)
Hardware: All All
: medium normal
Assignee: Not Assigned
Depends on:
Blocks: Dictionaries
  Show dependency treegraph
Reported: 2018-09-04 16:18 UTC by Pander
Modified: 2018-09-25 17:59 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Note You need to log in before you can comment on or make changes to this bug.
Description Pander 2018-09-04 16:18:07 UTC
a) Norwegian spell checking files contain runnable code which is a security hazard. See https://cgit.freedesktop.org/libreoffice/dictionaries/tree/no/nb_NO.aff and https://cgit.freedesktop.org/libreoffice/dictionaries/tree/no/nn_NO.aff

b) Please, remove these comments with code from those files. Better keep these instructions in the README and other documentation files.

c) Several URLs in the files are not working anymore. Please fix all usage of https://alioth.debian.org/projects/spell-norwegian/ and http://no.speling.org to the URL that currently should be used.

d) The file https://cgit.freedesktop.org/libreoffice/dictionaries/tree/no/nb_NO.dic has 7915 entries (`grep /$ nb_NO.dic|wc -l`) which end on a slash `/` but have no flags. These trailing slashes should not occur and result in errors in new spell checking engine Nuspell https://nuspell.github.io/

e) Additionally, all files should be converted to UTF-8
Comment 1 Julien Nabet 2018-09-05 08:11:12 UTC
Olav: as Norwegian contact, thought you might be interested in this one.
Andras: as Dictionary expert, thought you might be interested in this one.
Comment 2 Andras Timar 2018-09-05 08:48:53 UTC
We (the LibreOffice project) are not the maintainers of Norwegian dictionary, we just copy the files from upstream. We use released oxt extension. I did not find the source, as you reported, project source URLs are not working any more. Maybe Olav knows the authors/developers of the dictionary.

On the other hand, I don't see why a) and b) are security issues (build instructions in comments), maybe my imagination is poor. 

c) As written above, it's the task of the original authors.

d) If trailing slashes cause problems in nuspell, maybe it should be fixed in nuspell. You cannot expect, that all dictionary maintainers will comply.

e) UTF-8 is useful, when loan words or proper names are part of the dictionary, that cannot be written with ISO-8859-1. Again, it's up to the authors. 

I tend to think that this bug report is invalid.