Bug 119724 - macOS: Large delay before the red spell checker lines show up after pasting the same content multiple times. Lots of time spend in Scheduler::ProcessTaskScheduling()
Summary: macOS: Large delay before the red spell checker lines show up after pasting t...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: All macOS (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: perf, regression
Depends on:
Blocks: macOS-UI-polish Spell-Checking
  Show dependency treegraph
 
Reported: 2018-09-06 12:15 UTC by Telesto
Modified: 2024-10-26 19:25 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (16.02 KB, application/vnd.oasis.opendocument.text)
2018-09-06 17:21 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2018-09-06 12:15:51 UTC
Description:
MacOS: Large delay before the red spell checker lines show up after pasting the same content multiple times. Lots of time spend in Scheduler::ProcessTaskScheduling() 

Steps to Reproduce:
1. Open the attached file
2. Use Instruments Time Profiler (not needed, but shows the ProcessTaskScheduling)
2. Enable the spell checker (ideally to non-english) (it's more the visual impact; not needed for reproducing)
2. CMD+A + CMD +C
3. Hold CMD+V for a while (around 30 pages).. Notice that the LibO keeps processing, when releasing CMD+V (which it didn't do before). And it takes a long time before the spell checker finishes

Actual Results:
LibO keeps processing 20 seconds after releasing the CMD+V

Expected Results:
CPU usage should drop within 2 seconds or so


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.2.0.0.alpha0+
Build ID: 7cb6dc2652ce7e2e7d9ec7464bb1eed0d93306d7
CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2018-08-29_09:02:27
Locale: nl-NL (nl_NL.UTF-8); Calc: threaded
Comment 1 Telesto 2018-09-06 12:18:54 UTC
Setting to NEEDINFO for now.. Build I used is to old
Comment 2 Telesto 2018-09-06 12:41:19 UTC
Also found in
Version: 6.2.0.0.alpha0+
Build ID: 76bf3939b0583212a56c317c85aea110f8ac6fee
CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2018-07-27_06:01:47
Locale: nl-NL (nl_NL.UTF-8); Calc: group threaded

So probably unrelated to recent timer changes
Comment 3 Telesto 2018-09-06 17:21:24 UTC
Created attachment 144721 [details]
Example file
Comment 4 Alex Thurgood 2018-09-14 11:09:11 UTC
@Telesto : confirming with 

Version: 6.2.0.0.alpha0+
Build ID: 0b06762ff19a804d3b86167ae3012811662412f1
CPU threads: 4; OS: Mac OS X 10.13.6; UI render: default; 
Locale: fr-FR (fr_FR.UTF-8); Calc: threaded

and with repeated paste operation (continuous Cmd-V held down).
Comment 5 Alex Thurgood 2018-09-14 11:13:20 UTC
It gets so bad to the point of not even showing the redlining. Reducing the window and redisplaying the window again, cause the red lines to be redrawn.
Comment 6 Alex Thurgood 2018-09-14 11:13:54 UTC
I have a vague recollection that this behaviour isn't new though...
Comment 7 Telesto 2018-09-14 11:39:01 UTC
No repro with
Version: 4.3.7.2
Build ID: 8a35821d8636a03b8bf4e15b48f59794652c68ba
Comment 8 Dennis Roczek 2024-06-24 13:39:41 UTC
No repro with

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c39e4f6b8a942680bc7250177c34fd034a0605e0
CPU threads: 4; OS: macOS 11.7.10; UI render: Skia/Metal; VCL: osx
Locale: de-DE (de_DE.UTF-8); UI: en-US
Calc: threaded

with an really old macbook from 2014. Works fast. Is it still a problem?
Comment 9 Alex Thurgood 2024-06-24 17:46:13 UTC
(In reply to Dennis Roczek from comment #8)
 
> with an really old macbook from 2014. Works fast. Is it still a problem?

Currently can't test due to bug 109090
Comment 10 steve 2024-10-26 10:29:28 UTC
Version: 25.2.0.0.alpha0+ (AARCH64) / LibreOffice Community
Build ID: 3a8278c42e14b03eb57987adf33b6d61bfb3f856
CPU threads: 12; OS: macOS 15.0.1; UI render: Skia/Metal; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Pasted until I had 32 pages. Spellcheck underline was there immediately, no delay whatsoever.

This is true when then copying the 32 pages a few times going up to 222 pages.

@Telesto: could you re-test and confirm or re-open if needed please.
Comment 11 Telesto 2024-10-26 19:25:53 UTC
I don't recall the past experience. It seems pretty decent now
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c69b16a0f859d71a101e2c138887e7975ec71e2a
CPU threads: 8; OS: macOS 14.5; UI render: Skia/Metal; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded