Bug 119835 - EDITING: Reorder rolled-up custom animations incorrectly changes animation order
Summary: EDITING: Reorder rolled-up custom animations incorrectly changes animation order
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Brian Fraser
URL:
Whiteboard: target:6.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-13 06:33 UTC by Brian Fraser
Modified: 2018-10-02 12:52 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Sample presentation to demonstrate re-ordering failure. (13.24 KB, application/vnd.oasis.opendocument.presentation)
2018-09-13 06:33 UTC, Brian Fraser
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Fraser 2018-09-13 06:33:54 UTC
Created attachment 144829 [details]
Sample presentation to demonstrate re-ordering failure.

Moving a rolled-up set of text-animations down to be the last animation for a slide causes the order of the animations inside the rolled-up set to be reversed. 

Attached presentation is useful for demonstrating the incorrect reordering.

Steps to reproduce:
1. Have 1st and 2nd level text in a text box; add it as a custom animation.
(Will have 1st level appear on click, 2nd level appears with it).
2. Have another element (like a shape); add it as a custom animation (appear).
3. In the Animations side-bar, roll-up the 2 text animations (so they show as one line).
4. Select the rolled-up text animations and click the 'Move Down' button to move it to be the last animation on the slide.

Current Behaviour:
- Rolled-up text animations are moved down
- Order of animations in rolled-up set is reversed (the bug!)

Expected Behaviour:
Rolled-up text animations are moved down and the animations inside the rolled-up group are not reordered.


Tested under Windows and Linux. Present in 6.1.0.3 (x64)
Comment 1 Xisco Faulí 2018-09-18 12:01:36 UTC
Hello Brian Fraser,
I see you have assigned this issue to yourself.
Do you plan to work on fixing this?
Comment 2 Brian Fraser 2018-09-18 16:49:51 UTC
(In reply to Xisco Faulí from comment #1)
> Do you plan to work on fixing this?

Yes, I have a patch in the works. Thank you for asking!
Comment 3 Brian Fraser 2018-10-02 05:46:56 UTC
Patch merged into code to resolve this issue.
https://gerrit.libreoffice.org/#/c/60707/