LO's .ui files have accessibility issues which can be reported by the gla11y tool. The warnings for the existing issues are currently suppressed by solenv/sanitizers/ui/*.supp files, but the long-term goal is to just fix them. This EasyHack is about fixing them, the procedure details are documented on https://wiki.documentfoundation.org/Development/Accessibility#Fixing_existing_issues and more generally the documentation for warnings is on https://wiki.documentfoundation.org/Development/Accessibility#Automatic_.ui_testing
Added this to the Google Code-In Ideas page: https://wiki.documentfoundation.org/Mentoring_Programs/Task_ideas_for_Google_Code-in#Development
Having tried LO with a screen reader (Orca), I've noticed that the quality or style of the speech output varies a lot, not sure how to improve this. In printerpaperpage.ui, fixing the warnings suppressed in solenv/sanitizers/ ui/vcl.suppr does not have any effect on the screen reader output. Example: next to "Color:" choose "Greyscale". Screen reader will say "Greyscale", but in printdialog.ui, if you choose "4" next to "Number of pages:", the screen reader will say "Number of pages, 4". In the first case it should(?) say "Color, greyscale". Again, not sure how to fix this.
Rasmus Jonsson committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/4a4ac352dc73fce0ef5fe017f1101e290e81fb6f%5E%21 tdf#119931 Fix accessibility warnings in printerpaperpage.ui It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rasmus Jonsson committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/4ba6388c4507e3c93ba130eeddb616b43657561b%5E%21 tdf#119931 Fix accessibility warnings in chinesedictionary.ui It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
> fixing the warnings suppressed in solenv/sanitizers/ ui/vcl.suppr does not have any effect on the screen reader output. Well, it did for the warnings that I fixed earlier :) Just like compiler warnings, fixing all warnings does not necessarily fix all bugs, in some cases some work is needed in actual C code or even Orca itself. Of course, it doesn't mean we shouldn't work on fixing warnings: the ones which show up really do point at something being broken which should be fixed. For instance, about "Color:", something seems odd in Orca for all labelled comboboxes, it's not specific to this particular case, so something is to be fixed in Orca or Libreoffice in general, but fixing the warning in the .ui file is needed *too* to fix the labelling. "Number of pages:" is not a combobox, so it is not affected by the issue. Anyway, thanks for your work on this, it does help even if that sometimes can't be seen in Orca yet :)
(In reply to Samuel Thibault from comment #5) > > fixing the warnings suppressed in solenv/sanitizers/ > ui/vcl.suppr does not have any effect on the screen reader output. > > Well, it did for the warnings that I fixed earlier :) Yes in printdialog.ui there was an effect, hence my confusion when there was no effect in the other dialogues! As you say there's apparently something else going on.
Removing needsUX, feel free to ask anyway in case of questions. And please resolve the issue as fixed when done.
Just FTR: there are a couple thousand warnings to fix, so we can't expect this to be done soon :)
(In reply to Samuel Thibault from comment #8) > Just FTR: there are a couple thousand warnings to fix, so we can't expect > this to be done soon :) Indeed, many many .ui files to be worked through, and even then there are many warnings that I'm not sure about so it will probably stay unresolved even after I'm done. I'll try to wrap it up as soon as possible.
Rasmus Jonsson committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/3f3d8a769967918d021b2bf36256cbff420850ef%5E%21 tdf#119931 Fix a11y warnings in classificationdialog.ui It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rasmus Jonsson committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/43b2d7f5a2c1bc46f6bad9b932805f9142bd7407%5E%21 tdf#119931 fix a11y warnings in docking3deffects.ui It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rasmus Jonsson committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/922f3d2f10746ab25deeb5ea4ae78795524e6744%5E%21 tdf#119931 Fix a11y warnings in compressgraphicdialog.ui It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Samuel Thibault committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/d422a9d0cb914260192fbc68305db088af022204%5E%21 tdf#119931 Fix a11y warnings in classificationdialog.ui It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/219f3f3c169ed9f7a39417cdddbd652228230a6a tdf#119931 fix a11y warnings in cui/uiconfig/ui/aboutdialog.ui It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a27f9de5f738b245ef2534e6a3fb0e7d3393bc04 tdf#119931 fix a11y warnings in qrcodegen.ui It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
diwanshu885 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/db12f83a14c03ce81de42a927590a212039aea11 tdf#119931 Fix accessibility warnings It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
shubham656 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c87723180ccfe11e63823ff8f17d9370d98188f8 tdf#119931 Fix accessibility warnings It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
homeboy445 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/046c5daba237f8f9ad510dfa7fad61e7e32d896b tdf#119931 Fix accessibility warnings It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
msrijita18 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f25d5cd3d814d59aabab889b0fd6526cee3e57be tdf#119931 Fix accessibility warnings It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Heiko Tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3170799ce2506b9251609fb1e675f8ba98241cc3 Related tdf#119931 - Fix accessibility warnings It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Re-evaluating the EasyHack in 2022 This issue is still relevant, as there are still big suppression files remaining. $ ls -lh solenv/sanitizers/ui/*suppr|awk '{print $5 " " $9}' 18K solenv/sanitizers/ui/cui.suppr 6.1K solenv/sanitizers/ui/dbaccess.suppr 1.7K solenv/sanitizers/ui/desktop.suppr 2.0K solenv/sanitizers/ui/filter.suppr 677 solenv/sanitizers/ui/formula.suppr 343 solenv/sanitizers/ui/fps.suppr 824 solenv/sanitizers/ui/libreofficekit.suppr 3.9K solenv/sanitizers/ui/sfx.suppr 3.3K solenv/sanitizers/ui/svt.suppr 6.7K solenv/sanitizers/ui/svx.suppr 1.4K solenv/sanitizers/ui/uui.suppr 2.8K solenv/sanitizers/ui/vcl.suppr 3.2K solenv/sanitizers/ui/xmlsec.suppr Please note that they are .suppr files, and not .supp. It is a typo in the first comment.
Remaining instances: $ wc -l solenv/sanitizers/ui/*suppr 225 solenv/sanitizers/ui/cui.suppr 76 solenv/sanitizers/ui/dbaccess.suppr 20 solenv/sanitizers/ui/desktop.suppr 25 solenv/sanitizers/ui/filter.suppr 9 solenv/sanitizers/ui/formula.suppr 4 solenv/sanitizers/ui/fps.suppr 9 solenv/sanitizers/ui/libreofficekit.suppr 52 solenv/sanitizers/ui/sfx.suppr 40 solenv/sanitizers/ui/svt.suppr 85 solenv/sanitizers/ui/svx.suppr 18 solenv/sanitizers/ui/uui.suppr 38 solenv/sanitizers/ui/vcl.suppr 37 solenv/sanitizers/ui/xmlsec.suppr 638 total
Rasenkai committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e5402f1b1f5d44d5e40eede80ae05303036a4efe tdf#119931 Fix accessibility warnings It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
nirnay committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2c0669846fe26dae2bb64308517db685037e2cf9 tdf#119931 Fix accessibility warnings in dbaccess It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Adam Seskunas committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e4c8f63c90ad8396f22186045399fabcd65958cd tdf#119931 Fix accessibility warnings It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Venetia committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a6db6af4822d6aea4b0629c9fe660a758b7fcba1 tdf#119931 Fix accessibility warnings in sw/uiconfig It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.