Description: In general LO dialogs works on a way that all features can used by keyboard only. However in Line dialog we can't change the tab page (e.g. Line, Line Style, Arrow Styles), by TAB-ing to the label of the current tab page. In other dialogs (for example Area dialog) we can use TAB to move the focus to the label of the tab page and then use arrow keys to change the tab page, but this does not work in case of Line dialog. Steps to Reproduce: 1. Open Writer 2. Insert a shape 3. Right click on shape -> Line... 4. Move the focus with TAB Actual Results: We can't move the focus to the tab page label using TAB key and so can't switch to a different tab page. Expected Results: Should work similar to other dialogs (see Area dialog) and we should be able to change the tab page with TAB and arrow keys Reproducible: Always User Profile Reset: No Additional Info:
Created attachment 145111 [details] Screenshot about Area dialog showing how it looks like when the tab page label has the focus
Confirm it on Version: 6.2.0.0.alpha0+ Build ID: 66232248ff55639052ddb76918d555e21dc9c46b CPU threads: 4; OS: Linux 4.15; UI render: GL; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2018-09-20_19:40:04 Locale: ro-RO (ro_RO.UTF-8); Calc: threaded Shape - Area - we can focus on another tab Shape - Line - we can't change to another tab
Reproduced in Version: 5.2.0.0.alpha0+ Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53 Threads 4; Ver: 4.10; Render: default; but not in Version: 5.0.0.0.alpha1+ Build ID: 0db96caf0fcce09b87621c11b584a6d81cc7df86 Locale: ca-ES (ca_ES.UTF-8)
Actually, this is a more recent regression. https://cgit.freedesktop.org/libreoffice/core/commit/?id=3014e5f362c77c546452d45fcde96fcbae27235e author Caolán McNamara <caolanm@redhat.com> 2018-04-29 21:15:22 +0100 committer Caolán McNamara <caolanm@redhat.com> 2018-04-30 11:41:54 +0200 commit 3014e5f362c77c546452d45fcde96fcbae27235e (patch) tree afbefbd2f10bbf971dd52ea0732031ee009c3d30 parent 5e71673ae0bbd4c0c1b32a1269155b4cd2cb5f45 (diff) hook up can-focus to ability to tab into the widget Bisected with: bibisect-linux64-6.1 Adding Cc: to Caolán McNamara
the notebook should have can_focus of true
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=fee3669a3395133a9e47ff2f0a96159cb3eefb89 tdf#120055 line dialog notebook should be can-focus It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
that should do it
Verified locally! @Caolán, thanks for the quick fix! Cherry-picked to 6.1 -> https://gerrit.libreoffice.org/#/c/61247/ Not reproduced in Versió: 6.0.6.2 ID de la construcció: 1:6.0.6-0ubuntu0.16.04.1 Fils de CPU: 4; SO: Linux 4.15; Renderitzador de la IU: per defecte; VCL: gtk2; Configuració local: ca-ES (ca_ES.UTF-8); Calc: group
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2c2ecb7eaa448f33162ce60154af207228ac05a8&h=libreoffice-6-1 tdf#120055 line dialog notebook should be can-focus It will be available in 6.1.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.