Bug 120157 - Toolbars UI - background shading on selected action buttons offset to left of button and smaller than button surface
Summary: Toolbars UI - background shading on selected action buttons offset to left of...
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
(earliest affected)
Hardware: All macOS (All)
: high major
Assignee: Not Assigned
Keywords: bibisectRequest, regression
: 120251 (view as bug list)
Depends on:
Blocks: Icon-Themes
  Show dependency treegraph
Reported: 2018-09-27 14:13 UTC by Alex Thurgood
Modified: 2019-07-05 08:37 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:

Offset background shading of action buttons (65.18 KB, image/png)
2018-09-27 14:19 UTC, Alex Thurgood
Character dialog (332.67 KB, image/png)
2018-11-07 11:47 UTC, Telesto
Border dialog (369.58 KB, image/png)
2018-11-07 11:55 UTC, Telesto
Template selector (331.81 KB, image/png)
2018-11-07 17:48 UTC, Telesto

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Thurgood 2018-09-27 14:13:18 UTC
Following on from bug 120152, there is an additional problem in which the shading of any of the selected action buttons in the Add Field dialog is offset to the left of the corresponding button.

Steps to Reproduce:
1. Open any Base file
2. Go to the Reports section and choose 'Create report in design view'
3. Select any table
4. Click on a field name in the dialog and then an action button in the main menu of that window

Actual Results:
Background shading of selected action button is offset to left of button

Expected Results:
Shading of button indicating that the action button has been selected should match the dimensions of the button

Reproducible: Always

User Profile Reset: No

Additional Info:
Comment 1 Alex Thurgood 2018-09-27 14:19:25 UTC
The problem is also evident in the main Base window with the action buttons on the left hand side.

Screenshot provided to show.
Comment 2 Alex Thurgood 2018-09-27 14:19:54 UTC
Created attachment 145218 [details]
Offset background shading of action buttons
Comment 3 Drew Jensen 2018-09-27 15:52:10 UTC
Using Ubuntu 18.04 (64 bit, gnome) and 6.2Alpha
I tried this with vcl=gen, gtk, gl and in all these different setting under gnome I don't see any shadow effect at all, so I can't confirm or deny ;)
Comment 4 Alex Thurgood 2018-09-28 09:03:24 UTC
@Drew - thanks for testing.

Seems like it could be MacOS only then.

@Heiko : any ideas ?
Comment 5 Heiko Tietze 2018-10-01 14:01:36 UTC
(In reply to Alex Thurgood from comment #4)
> @Heiko : any ideas ?

I can confirm the context dependency. On Linux/gtk2 no problem, macOS/master the drawing is scrambled (the button dimension is okay for the selection, though good be a bit larger, but redraw fails and sometimes one or more/all buttons are shaded).

However I don't thing it's a big show stopper, as moving the cursor around helps to identify the selection if there wouldn't be any clue from the content area. So reset to medium/normal. The regression should be solved anyway.
Comment 6 Xisco Faulí 2018-10-01 17:00:01 UTC
I can't reproduce it in

Build ID: 3d39dad6d93c979ac64244ecb9acfbd8a5fbd6c6
CPU threads: 8; OS: Mac OS X 10.13.6; UI render: default; 
Locale: en-US (en_ES.UTF-8); Calc: threaded
Comment 7 Alex Thurgood 2018-10-02 06:44:12 UTC
*** Bug 120251 has been marked as a duplicate of this bug. ***
Comment 8 Alex Thurgood 2018-10-02 06:46:09 UTC
This problem seems to apply to toolbars in more than just the Base module, see duplicate bug 120251.

Upping severity, priority.
Comment 9 Julien Nabet 2018-10-02 07:19:05 UTC
Alex: don't hesitate to make several actions in one time when it's possible to reduce spams from bugzilla :-)
Comment 10 Alex Thurgood 2018-10-02 07:22:41 UTC
(In reply to Julien Nabet from comment #9)
> Alex: don't hesitate to make several actions in one time when it's possible
> to reduce spams from bugzilla :-)

I try, but am on a flaky internet connection today :-)
Comment 11 Telesto 2018-11-07 11:47:39 UTC
Created attachment 146388 [details]
Character dialog

Wrong offset gray selection block
Comment 12 Telesto 2018-11-07 11:55:50 UTC
Created attachment 146390 [details]
Border dialog

Not sure if this is the same, but spacing between border of the drop down list and the content is slightly off
Comment 13 Telesto 2018-11-07 17:48:50 UTC
Created attachment 146409 [details]
Template selector
Comment 14 Xisco Faulí 2018-11-19 16:50:45 UTC
I can't reproduce the problem with the impress templates in

Build ID: afd4f48d164ca72a024159e0c6b7a49147351f64
CPU threads: 8; OS: Mac OS X 10.13.6; UI render: default; VCL: osx; 
Locale: en-US (en_ES.UTF-8); UI-Language: en-US
Calc: threaded
Comment 15 Alex Thurgood 2019-07-05 08:37:35 UTC
Seems to work for me now in

Build ID: 75d35ef8df1936dd93d5919b688abcaddb58bee8
CPU threads: 4; OS: Mac OS X 10.14.5; UI render: default; VCL: osx; 
Locale: fr-FR (fr_FR.UTF-8); UI-Language: en-US
Calc: threaded