Bug 120170 - Sidebar: Escape key press in floating sidebar Style or Character panel comboboxes sends focus to document view
Summary: Sidebar: Escape key press in floating sidebar Style or Character panel combob...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Jim Raykowski
URL:
Whiteboard: target:6.4.0 target:6.3.0.1
Keywords:
Depends on:
Blocks: Sidebar-Properties
  Show dependency treegraph
 
Reported: 2018-09-27 20:12 UTC by Jim Raykowski
Modified: 2019-06-21 01:16 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Raykowski 2018-09-27 20:12:41 UTC
Steps to reproduce in Writer or Calc:

1) Open Sidebar using Menu > View > Sidebar or Ctrl+F5
2) Undock Sidebar using tab bar Menu > Undock or grab deck title bar and drag
3) Open Properties deck
4) Click on any of the comboxes in the Style or Character panel
5) Press Escape key

Results:
Focus is in document view

Expected Results:
Focus is on panel title
Comment 1 Buovjaga 2018-10-23 13:23:55 UTC
Repro.

Arch Linux 64-bit
Version: 6.2.0.0.alpha0+
Build ID: 9a373521d7a328197a4bf9abeb0a981b7acba896
CPU threads: 8; OS: Linux 4.18; UI render: default; VCL: gtk3_kde5; 
Locale: fi-FI (fi_FI.UTF-8); Calc: threaded
Built on 19 October 2018
Comment 2 Jim Raykowski 2018-12-02 00:08:18 UTC
gerrit link to proposed patch:
https://gerrit.libreoffice.org/#/c/64417/
Comment 3 Buovjaga 2018-12-02 08:45:48 UTC
(In reply to Jim Raykowski from comment #2)
> gerrit link to proposed patch:
> https://gerrit.libreoffice.org/#/c/64417/

I confirm the patch gives expected results.
Comment 4 Commit Notification 2019-01-06 04:28:25 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/144ee02fc714f2f022e5046aeec2b46cd4cd1476%5E%21

tdf#120170 Use parent key input handler for controls that use subedit

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2019-01-09 01:25:46 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/16dbaf8e4a487c75f5977f5f4febdeae4466c264%5E%21

Revert "tdf#120170 Use parent key input handler for controls that use subedit"

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Jim Raykowski 2019-01-09 02:22:07 UTC
I reverted this patch because it caused a regression reported in bug 122570
Comment 7 Jim Raykowski 2019-05-26 00:20:17 UTC
I don't repro this with Windows
 
Version: 6.3.0.0.alpha1+ (x64)
Build ID: 7f3d3e74fdcffb55da7fd7f55ac4c1f85d35745c
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2019-05-24_22:08:51
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

But still repro with Linux current master using SAL_USE_VCLPLUGIN's gen,gtk,and gtk3

Why this works correctly for Windows and not for Linux is currently beyond me. The best I can do at this time is to provide a hack that prevents focus from being set to the document window if escape key is pressed in a style, font name, or font size box contained in a sidebar tool box.

Here is this approach:
https://gerrit.libreoffice.org/#/c/72970/
Comment 8 Commit Notification 2019-06-13 21:07:38 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/c81055eb075efffa9cd123913a684ac3258903d5%5E%21

tdf#120170 Prevent escape key press focus to document

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2019-06-18 12:11:29 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/+/d10b4015b07aa717b6377f46f58f29b9988ec84f%5E%21

tdf#120170 Prevent escape key press focus to document

It will be available in 6.3.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.