Created attachment 145243 [details] radioButtons.Form.xls: optionbutton's should toggle, not both enable. Two radio button ought to be mutually exclusive, but starting early in 6.2 master that stopped working at source 726d7e7b8b50dca9914329dbfd9491f7c8961f68 source a28a839b9f9eeec1544c5ceeeabe7b1083ce1655 source 4b4942224b550235da228655677b5c068a053254 likely due to SOSAW080: Derive SdrObjGroup from SdrObjList CC'd Armin Le Grand My guess is that sc/source/filter/excel/xiescher.cxx's Reference< XControlModel > xCtrlModel = XclControlHelper::GetControlModel( pTbxObj->mxShape ); is the problem because a ControlModel isn't found.
Confirmed on ubuntu 16.04 x64 with Version: 6.2.0.0.alpha0+ Build ID: ad6adb1bfadf49af3187a0bb3ceffbf355e9eed1 CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-09-29_02:45:20 Locale: en-US (en_US.UTF-8); Calc: threaded Unconfirmed with Version: 6.1.0.0.alpha1+ Build ID: 47dc3115f12ff16dc326b6edd12c46e6a6ef1843 CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-05-17_00:32:17 Locale: en-US (en_US.UTF-8); Calc: group
Still reproducible in Version: 6.2.0.0.alpha0+ Build ID: e9c1cbce903d325b1e19602d72765511589f5bf2 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: threaded and now reproducible in Versión: 6.1.2.1 Id. de compilación: 65905a128db06ba48db947242809d14d3f9a93fe Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; Configuración regional: es-ES (es_ES); Calc: group threaded after https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-6-1&id=1ebb77fd17b417d92ab48fcef56a0230c5750de2 Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=4b4942224b550235da228655677b5c068a053254 Adding Cc: to Armin Le Grand
Dear Justin L, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Still reproducible in Version: 6.4.0.0.alpha1+ (x86) Build ID: fe2c63e494ea66042406ad71234ebe076dec07dc CPU threads: 4; OS: Windows 10.0 Build 17763; UI render: GL; VCL: win;
Still repo in Version: 6.5.0.0.alpha0+ (x64) Build ID: 314f15bff08b76bf96acf99141776ef64d2f1355
I don't know why bug 79542 is only See Also, but looks duplicate to me. *** This bug has been marked as a duplicate of bug 79542 ***
From Comment 1: 6.1.0.0.alpha1+ Build ID: 47dc3115f12ff16dc326b6edd12c46e6a6ef1843 worked. This is not a dupe of bug 79542. Bug 120177 is a regression. Bug 79542 is inherited from OOo.
(In reply to Luke from comment #7) > Bug 120177 is a regression. Not a dupe of bug 79542 inherited from OOo. If it looks like regression and behaves like regression, it still may not be.. We should look into bugs to make a conclusion. Bug 79542 is Inherited but changed in the same commit that makes this one "regression". If you saved this XLS as ODS before regression, radios didn't work. They never had a group as XLSX. So basically this didn't really work fine, even if appeared so before. In Excel, radio needs to be connected with a cell in the worksheet if value is needed or for multiple groups, if group box is not used. In this example that's not the case. Example from Bug 79542 is more complex and somewhat better. Key problem in both examples is that there's not autogroup on XLS import. I closed this one with intent to focus on the whole issue, having commit there and duplicate info, nothing is lost, on the contrary. I didn't expect that Armin would "fix" this as it makes no sense. I think that 4 years prove me right. So I duplicate again. *** This bug has been marked as a duplicate of bug 79542 ***
Not an exact duplicate of bug 79542. This one actually ought to have been handled by the existing code (it has mnNextInGroup) and thus follows a different code path. Treat as a separate bug because my fixes for the other bug wouldn't impact this example at all. Although I must say, the problem with xCtrlModel is the same problem I had with creating a "proper fix" for the other bug. So did a GroupBox object do something after all in LO way back in the day? (Armin's patch is so huge it is impossible to make any sense out of it.)
(In reply to Justin L from comment #0) > My guess is that sc/source/filter/excel/xiescher.cxx's > Reference< XControlModel > xCtrlModel = XclControlHelper::GetControlModel( > pTbxObj->mxShape ); > is the problem because a ControlModel isn't found. I'm guessing XclControlHelper needs a redesign to store an SdrObject* instead of a shape, so it can access a previously inserted page object. Armin, can you comment on this?
This seems to be fixed in 7.5 since https://git.libreoffice.org/core/+/17e27b4a19f22b912460f090b754d11f9a32fb7f author Noel Grandin <noel.grandin@collabora.co.uk> Tue Sep 06 14:28:22 2022 +0200 committer Noel Grandin <noel.grandin@collabora.co.uk> Tue Sep 06 18:05:24 2022 +0200 tdf#150756 - Assertion when opening report for editing Now only one of the option buttons can be selected at the same time. Thanks Noel for making this go away :)
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/332ac45c73952af7e2c2a868fc03e17d96a7de2c tdf#120177: sc_subsequent_export_test4: Add unittest It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.