Bug 120177 - FILEOPEN XLS: Radio button Form controls no longer grouped
Summary: FILEOPEN XLS: Radio button Form controls no longer grouped
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.1.2.1 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.5.0
Keywords: bibisected, bisected, filter:xls, regression
Depends on:
Blocks: Form-Controls Regressions-AW080 79542
  Show dependency treegraph
 
Reported: 2018-09-28 07:42 UTC by Justin L
Modified: 2023-05-15 23:03 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
radioButtons.Form.xls: optionbutton's should toggle, not both enable. (13.50 KB, application/vnd.ms-excel)
2018-09-28 07:42 UTC, Justin L
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Justin L 2018-09-28 07:42:41 UTC
Created attachment 145243 [details]
radioButtons.Form.xls: optionbutton's should toggle, not both enable.

Two radio button ought to be mutually exclusive, but starting early in 6.2 master that stopped working at
    source 726d7e7b8b50dca9914329dbfd9491f7c8961f68
    source a28a839b9f9eeec1544c5ceeeabe7b1083ce1655
    source 4b4942224b550235da228655677b5c068a053254

likely due to SOSAW080: Derive SdrObjGroup from SdrObjList
CC'd Armin Le Grand

My guess is that sc/source/filter/excel/xiescher.cxx's
Reference< XControlModel > xCtrlModel = XclControlHelper::GetControlModel( pTbxObj->mxShape );
is the problem because a ControlModel isn't found.
Comment 1 MM 2018-09-30 10:48:08 UTC
Confirmed on ubuntu 16.04 x64 with Version: 6.2.0.0.alpha0+
Build ID: ad6adb1bfadf49af3187a0bb3ceffbf355e9eed1
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-09-29_02:45:20
Locale: en-US (en_US.UTF-8); Calc: threaded

Unconfirmed with Version: 6.1.0.0.alpha1+
Build ID: 47dc3115f12ff16dc326b6edd12c46e6a6ef1843
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-05-17_00:32:17
Locale: en-US (en_US.UTF-8); Calc: group
Comment 2 Xisco Faulí 2018-10-01 16:16:26 UTC
Still reproducible in

Version: 6.2.0.0.alpha0+
Build ID: e9c1cbce903d325b1e19602d72765511589f5bf2
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: threaded

and now reproducible in

Versión: 6.1.2.1
Id. de compilación: 65905a128db06ba48db947242809d14d3f9a93fe
Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; 
Configuración regional: es-ES (es_ES); Calc: group threaded

after

https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-6-1&id=1ebb77fd17b417d92ab48fcef56a0230c5750de2

Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=4b4942224b550235da228655677b5c068a053254

Adding Cc: to Armin Le Grand
Comment 3 QA Administrators 2019-10-02 02:56:31 UTC Comment hidden (obsolete)
Comment 4 Luke 2019-11-05 01:10:27 UTC Comment hidden (obsolete)
Comment 5 Luke 2020-01-07 17:01:48 UTC
Still repo in Version: 6.5.0.0.alpha0+ (x64)
Build ID: 314f15bff08b76bf96acf99141776ef64d2f1355
Comment 6 Timur 2022-03-11 13:08:10 UTC Comment hidden (obsolete)
Comment 7 Luke 2022-03-14 22:08:07 UTC Comment hidden (obsolete)
Comment 8 Timur 2022-06-09 14:20:41 UTC Comment hidden (obsolete)
Comment 9 Justin L 2022-08-05 13:16:39 UTC Comment hidden (obsolete, wisdom)
Comment 10 Justin L 2022-08-09 11:51:19 UTC
(In reply to Justin L from comment #0)
> My guess is that sc/source/filter/excel/xiescher.cxx's
> Reference< XControlModel > xCtrlModel = XclControlHelper::GetControlModel(
> pTbxObj->mxShape );
> is the problem because a ControlModel isn't found.
I'm guessing XclControlHelper needs a redesign to store an SdrObject* instead of a shape, so it can access a previously inserted page object.

Armin, can you comment on this?
Comment 11 Gabor Kelemen (allotropia) 2023-05-08 15:06:39 UTC
This seems to be fixed in 7.5 since

https://git.libreoffice.org/core/+/17e27b4a19f22b912460f090b754d11f9a32fb7f

author	Noel Grandin <noel.grandin@collabora.co.uk>	Tue Sep 06 14:28:22 2022 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	Tue Sep 06 18:05:24 2022 +0200

tdf#150756 - Assertion when opening report for editing

Now only one of the option buttons can be selected at the same time.

Thanks Noel for making this go away :)
Comment 12 Commit Notification 2023-05-09 09:55:30 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/332ac45c73952af7e2c2a868fc03e17d96a7de2c

tdf#120177: sc_subsequent_export_test4: Add unittest

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.