Description: In the shape Position and Size dialog, LO has a Rotation tab page with a nice "rotation clock" where the user can select the rotation angle. When I try to travel through the dialog with TAB key, it seems TAB stops at this clock even if we can't do anything with that item. I think the best would be to make TABing just jump over that item. It's not usefull to stop there and also we can set the rotation angle in the input field next to it anyway. Steps to Reproduce: 1. Open writer 2. Insert a shape 3. Right click on the shape and open Position and Size dialog 4. Select Rotation tab page 5. Move focus through the dialog with TAB Actual Results: Tab stops at the "rotation clock" Expected Results: Tab should not stop at the "rotation clock" Reproducible: Always User Profile Reset: No Additional Info:
Code pointer: The Rotation tab page GUI description file cui/uiconfig/ui/rotationtabpage.ui The related widget property is can_focus which specifies whether the widget can get the focus by tab.
Also worth to check: https://wiki.documentfoundation.org/Development/WidgetLayout#Widget_Layout
Hi Tamás, i can't reproduce it in Versión: 6.1.2.1 Id. de compilación: 65905a128db06ba48db947242809d14d3f9a93fe Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; Configuración regional: es-ES (es_ES); Calc: group threaded nor in Version: 6.2.0.0.alpha0+ Build ID: 8ea0b0f4dc5eba2d0bafc2e42415ef1824ff604e CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; Locale: ca-ES (ca_ES.UTF-8); Calc: threaded are you sure it stops for you in the rotation clock ? After Angle's box, it lands in the Ok button
(In reply to Xisco Faulí from comment #3) > Hi Tamás, > > i can't reproduce it in > > Versión: 6.1.2.1 > Id. de compilación: 65905a128db06ba48db947242809d14d3f9a93fe > Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; > Configuración regional: es-ES (es_ES); Calc: group threaded > > nor in > > Version: 6.2.0.0.alpha0+ > Build ID: 8ea0b0f4dc5eba2d0bafc2e42415ef1824ff604e > CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; > Locale: ca-ES (ca_ES.UTF-8); Calc: threaded > > are you sure it stops for you in the rotation clock ? > After Angle's box, it lands in the Ok button Hi Xisco, Yes, I'm sure. It's better to test on Windows, because there the actual focus is visible in most of the cases. While on linux, at least at my side, there is no focus indicator for buttons for example. It needs to push space to see where is the actual focus. It can't land on OK button after angle's box, because there are a Help and a Reset button before. You might see an extra blue border around OK button, but it's not the focus (which moves by TAB), but it shows the button which will be "pushed" by enter.
Fixed the issue on my local machine. Now submitting the patch.
Please review the patch: https://gerrit.libreoffice.org/#/c/65867/
Just reformatted the patch with "tdf#120195" in the first line of commit message, which automatically tie your patch to this bug report. It has no influence of ownership, but mentioning the bug number in this form (first line) makes always sure that the bug report will updated with the commit when your change/patch is merged.
s/reformatted/reformat it to tdf#120195
Changed the commit message to "tdf#120195 tab focus removed" .
Aditya committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/59f73a9d8284cb3f89b7be0f3539aa209ea17291%5E%21 tdf#120195 tab focus removed It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.