Bug Hunting Session
Bug 120243 - Remove old idle workaround ...
Summary: Remove old idle workaround ...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
(earliest affected)
Hardware: All All
: medium normal
Assignee: Not Assigned
Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
Depends on:
Blocks: Conditional-Formatting-Editing
  Show dependency treegraph
Reported: 2018-10-01 15:21 UTC by Michael Meeks
Modified: 2019-12-10 22:56 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2018-10-01 15:21:52 UTC
This code:

IMPL_LINK(ScCondFormatList, TypeListHdl, ListBox&, rBox, void)

Has a comment referring to bug#79021 - since the advent of VclPtr and sensible references on VCL Widgets we should no longer need this workaround. It would be good to simplify this code by doing the AfterTypeListHdl inside this code location rather than deferring it.

Thanks !
Comment 1 Michael Meeks 2018-10-01 15:22:54 UTC
Making an easy-hack of this.
Comment 2 Advait Ranade 2019-12-09 06:37:32 UTC
Hello, I'm new to open source. I want to solve this bug. I went through condformatdlg.cxx, I also read few articles related and I think making changes in class ScCondFormatList will do the work and this is because the name of the class is intuitive. But I don’t know what to do from here. Please guide me for the same. 

Thank you.
Comment 3 Michael Meeks 2019-12-10 22:56:30 UTC
Do the work of the AfterTypeListHdl inside the callback instead of inside a (now un-necessary) PostMessage - merge the two methods, compile, test it heavily and submit a patch =) That is what the bug description tried to say.