Bug 120296 - Sidebar: Crash after tab bar customization
Summary: Sidebar: Crash after tab bar customization
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: All All
: high major
Assignee: Not Assigned
URL:
Whiteboard: target:6.2.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2018-10-04 00:33 UTC by Jim Raykowski
Modified: 2018-11-06 10:17 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Raykowski 2018-10-04 00:33:35 UTC 
Steps to reproduce in Writer:

1) Open Sidebar (Menu > View > Sidebar or Ctrl+F5)
2) Click on the Gallery tab 
3) Click on the Sidebar Settings tab
4) Click on Customization
5) Click on Properties
6) Click on Gallery tab

Results: Crash

Patch for bug 119630 fixes this crash.
Comment 1 Xisco Faulí 2018-10-04 14:46:55 UTC 
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=2c92b886b7538c4786a4d9a33cbcfe694daf1f62

author	Jim Raykowski <raykowj@gmail.com>	2018-08-26 18:01:09 -0800
committer	Caolán McNamara <caolanm@redhat.com>	2018-08-29 16:38:28 +0200
commit 2c92b886b7538c4786a4d9a33cbcfe694daf1f62 (patch)
tree 618e2aec5e5e37f6798035c10790ec75254ec3dc
parent 17d8f6b0d78c11ac40a335917b3576f13d1e1b9d (diff)
tdf#119461 Fix focus hidden on deck collapse
Makes Space key behavior the same as mouse click. Focus remains on the
tab button when the deck collapses.

Makes Enter key never collapses the deck but to open if collapsed and
always place focus on the first panel title.

Bisected with: bibisect-linux64-6.2
Comment 2 Jim Raykowski 2018-10-31 20:19:23 UTC 
Hi All,

The merged patch for bug 119630 fixes this bug.
Comment 3 Xisco Faulí 2018-11-02 18:09:04 UTC 
Verified in

Version: 6.2.0.0.alpha1+
Build ID: 5929d8ea469a971aa77371ed4b841c90a36e7da5
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: threaded

@Jim Raykowski, Should this issue be closed now ?