Created attachment 145448 [details]
An ODP that fails to save as PPT(X)
Saving this document (a minimized document from https://ask.libreoffice.org/en/question/167707/write-error-while-exporting-odp-as-pptx-formatted-file/) as PPT(X) gives error:
For Save a Copy:
> Error saving the document PPTFail:
> General Error.
> General input/output error.
For Save As:
> Error saving the document PPTFail:
> Write Error.
> The file could not be written.
Fails with current master, and with Version: 184.108.40.206 (x64)
Build ID: 65905a128db06ba48db947242809d14d3f9a93fe
CPU threads: 12; OS: Windows 10.0; UI render: GL;
Locale: ru-RU (ru_RU); Calc: CL
and with LibreOffice 220.127.116.11 20m0(Build:2)
Linux niggahme 4.9.0-6-amd64 #1 SMP Debian 4.9.82-1+deb9u3 (2018-03-02) x86_64 GNU/Linux
(as reported in original AskLibO question).
Also fails with Version: 18.104.22.168
Build ID: 62ad5818884a2fc2e5780dd45466868d41009ec0
But saves OK with Version: 22.214.171.124
Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71
The problem is the "Title2" master page, deleting which resolves the issue, and assigning which to a page gives failed assertions in master build:
Microsoft Visual C++ Runtime Library
Expression: !(bListeningAlready && eDuplicateHanding == DuplicateHandling::Unexpected) && "duplicate listener, try building with DBG_UTIL to find the other insert site."
For information on how your program can cause an assertion
failure, see the Visual C++ documentation on asserts
(Press Retry to debug the application - JIT must be enabled)
Abort Retry Ignore
A code pointer: returning the error happens in PPTWriterBase::exportPPT (sd/source/filter/eppt/pptx-epptbase.cxx), in the code
> for ( i = 0; i < mnMasterPages; i++ )
> if ( !CreateSlideMaster( i ) )
which later calls SdMasterPage::getBackground (sd/source/ui/unoidl/unopage.cxx), where
> rValue <<= Reference< beans::XPropertySet >( xFamily->getByName( aStyleName ), UNO_QUERY_THROW );
*** Bug 120381 has been marked as a duplicate of this bug. ***
Confirmed on windows 7 x64 with Version: 126.96.36.199 (x64)
Build ID: 5d2cb2a5dd04fe174b336488731eb50bbb5faed3
CPU threads: 3; OS: Windows 6.1; UI render: default
Only saving to ppt gives the error, not when saving to pptx.
Created attachment 145466 [details]
With LO Versiune: 188.8.131.52 I could opened the file and save as PPTX. And then open the pptx file. No error.
Identificator construire: 1:6.0.6-0ubuntu0.18.04.1
Fire CPU: 4; OS: Linux 4.15; Redare UI: implicit; VCL: gtk3;
Setări regionale: ro-RO (ro_RO.UTF-8); Calc: group threaded
With LO Version: 184.108.40.206.alpha0+ I could opened the file, save as PPTX, but get an error after opening PPTX file. See the image.
Build ID: e539a492597c7312a8d0cccb4b386341bd4ec84a
CPU threads: 4; OS: Linux 4.15; UI render: GL; VCL: gtk2;
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-10-05_00:43:34
Locale: ro-RO (ro_RO.UTF-8); Calc: threaded
(In reply to BogdanB from comment #4)
> Created attachment 145466 [details]
> With LO Version: 220.127.116.11.alpha0+ I could opened the file, save as PPTX, but
> get an error after opening PPTX file. See the image.
> Build ID: e539a492597c7312a8d0cccb4b386341bd4ec84a
> CPU threads: 4; OS: Linux 4.15; UI render: GL; VCL: gtk2;
> TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
> Locale: ro-RO (ro_RO.UTF-8); Calc: threaded
Yes, with v18.104.22.168 i'm getting an error when trying to load the pptx file.
Which is a different problem then getting the error when saving as ppt.
Yes, sorry for the noise about PPTX - my fault, assumed that the description on the Ask site is accurate, and only tested PPT part.
As MM stated in comment 5, the error on opening should be treated as a different problem. It might happen that it would be fixed by fixing this, though, but until then, let's concentrate here on the PPT part.
This seems to have begun at the below commit.
Adding Cc: to Tobias Lippert; Could you possibly take a look at this one?
4d136132a55af35f66dd60d33d5c767cb29404af is the first bad commit
Author: Matthew Francis <email@example.com>
Date: Thu May 28 20:04:07 2015 +0800
Author: Tobias Lippert <firstname.lastname@example.org>
AuthorDate: Wed Mar 5 20:06:39 2014 +0100
Commit: Caolán McNamara <email@example.com>
CommitDate: Tue Mar 11 08:54:37 2014 -0500
fdo#30770 - Speed up xslx import
Reviewed-by: Caolán McNamara <firstname.lastname@example.org>
Tested-by: Caolán McNamara <email@example.com>
I will. But I am currently involved in another project. It will probably be in the magnitude of 6 weeks before I get to it. If this is urgent, someone else should have a look.
Dear Tobias Lippert,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assigned it back to yourself if you're still working on this.
Date: Thu Mar 14 06:22:38 2019 +0100
previous sha: ed901c336ff0b99291ffe53be6bd762abcccf55c
author Mike Kaganski <firstname.lastname@example.org> 2019-03-13 22:44:44 +0100
committer Mike Kaganski <email@example.com> 2019-03-14 06:16:23 +0100
commit 362082b57b2d6e9119acb3fb033aefcbce8cf8bb (patch)
parent ed901c336ff0b99291ffe53be6bd762abcccf55c (diff)
Only return elements with both name and predicate matching arguments
... otherwise, after first stylesheet with matching name but failing
predicate, next stylesheet that matches predicate is returned, regardless
what is its name.
See commit b37b299d5228beeecb913980780f463756c5a878.
So, Mike reported and fixed for PPT. I don't repro for PPTX.
working well in
Version: 22.214.171.124.alpha0+ / LibreOffice Community
Build ID: 1a99b4e44190e182d56a04678850d62635d74c65
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US